From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758349AbcH3Laf (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 07:30:35 -0400
Received: from cit-hm8-mail01.bmw-carit.de ([212.118.206.84]:64449 "EHLO
        cit-hm8-gw01.bmw-carit.de" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1758281AbcH3Lae (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 07:30:34 -0400
X-CTCH-RefID: str=0001.0A0C0202.57C56E54.01D3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0
Subject: Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints
To: Binoy Jayan <binoy.jayan@linaro.org>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
References: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org>
 <1472552924-22297-3-git-send-email-binoy.jayan@linaro.org>
CC: Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        <linux-kernel@vger.kernel.org>, Masami <masami.hiramatsu@linaro.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Message-ID: <fba4d013-5bfa-54af-fa96-483b71964f7c@bmw-carit.de>
Date: Tue, 30 Aug 2016 13:30:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1472552924-22297-3-git-send-email-binoy.jayan@linaro.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.10.50.53]
X-ClientProxiedBy: CIT-HM8-EX01.bmw-carit.intra (10.40.100.13) To
 CIT-HM8-EX01.bmw-carit.intra (10.40.100.13)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Binoy,

On 08/30/2016 12:28 PM, Binoy Jayan wrote:
> +static inline void trace_latency_preempt_mark_ts(enum latency_type ltype)
> +{
> +	this_cpu_write(lat_ts[ltype], (cycle_t) trace_clock_local());
> +}
> +
> +static inline void latency_trace(enum latency_type type)
> +{
> +	trace_latency_preempt(type,
> +		(cycle_t) trace_clock_local() - this_cpu_read(lat_ts[type]));
> +}

As Masami has pointed out, the prefix trace_ should not be used. Also 
having trace_latency_ and latency_trace_ is kind of confusing. What 
about {start|stop}_latency_timing()? It would match the existing 
{start|stop}_critical_timing(). Or is it too close and it leads to 
confusion?

Another idea is {start|stop}_latency_preempt(). This matches the 
trace_latency_preempt_enable() function.

cheers,
daniel