From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v3 00/24] pic/ioapic/irqchip cleanups + minor fixes Date: Wed, 12 Apr 2017 21:59:39 +0200 Message-ID: References: <20170407085041.5257-1-david@redhat.com> <20170412185805.GC20145@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, Paolo Bonzini , Peter Xu To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbdDLT7s (ORCPT ); Wed, 12 Apr 2017 15:59:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 713FBF3D64 for ; Wed, 12 Apr 2017 19:59:47 +0000 (UTC) In-Reply-To: <20170412185805.GC20145@potion> Sender: kvm-owner@vger.kernel.org List-ID: On 12.04.2017 20:58, Radim Krčmář wrote: > 2017-04-07 10:50+0200, David Hildenbrand: >> My attempt to further cleanup pic/ioapic checks using irqchip_mode + other >> cleanups in that area. >> >> The goal is to only check against irqchip_mode and not to rely on >> vpic/vioapic variables anymore to test for existence of pic/ioapic. This >> will avoid any possible races when creating the kernel irqchip fails. > > Looks good, applied to kvm/queue to get testing, thanks. > > I have noted cosmetical changes for barriers, but they are not big > enough to need a v4 of the series. > Thanks, feel free to fix this up if you like. I think this should work with and without these barriers, so it doesn't matter. -- Thanks, David