From: Arnout Vandecappelle <arnout@mind.be>
To: Francois Perrad <fperrad@gmail.com>, buildroot@busybox.net
Cc: Vadim Kochan <vadim4j@gmail.com>,
Serhiy Boiko <serhiy.boiko@plvision.eu>
Subject: Re: [Buildroot] [PATCH] package/mstpd: new package
Date: Sun, 26 Sep 2021 23:42:18 +0200 [thread overview]
Message-ID: <fba75762-e27c-7530-b133-b11735c24c7b@mind.be> (raw)
In-Reply-To: <20210920192442.2784967-1-francois.perrad@gadz.org>
Hi Francois,
On 20/09/2021 21:24, Francois Perrad wrote:
[snip]
> diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk
> new file mode 100644
> index 000000000..0e5c9714c
> --- /dev/null
> +++ b/package/mstpd/mstpd.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# mstpd
> +#
> +################################################################################
> +
> +MSTPD_VERSION = 0.0.9
> +MSTPD_SITE = $(call github,mstpd,mstpd,$(MSTPD_VERSION))
> +MSTPD_AUTORECONF = YES
> +MSTPD_LICENSE = GPL-2.0
There is actually hmac_md5.c that has a different license. So I added that
one, and I added it to LICENSE_FILES as well and to the hash file.
> +MSTPD_LICENSE_FILES = LICENSE
> +
Vadim (in Cc) posted the same package a year ago. He had
+# mstpd requires that it is installed into /sbin, not /usr/sbin
+MSTPD_CONF_OPTS = \
+ --sbindir=/sbin
which he later explained with "it should point to /sbin because
Linux's bridge implementation calls /sbin/bridge-stp in case the STP
handling is delegated to user space." - which sounds pretty feasible to me...
Did you test this with STP and with a non-unified /usr?
I've anyway alreayd applied as-is to master (with the license fix), but please
check if the --sbindir is needed.
Regards,
Arnout
> +$(eval $(autotools-package))
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-26 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 19:24 [Buildroot] [PATCH] package/mstpd: new package Francois Perrad
2021-09-26 21:42 ` Arnout Vandecappelle [this message]
2021-09-27 8:02 ` Vadym Kochan
2021-09-28 8:08 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2020-09-19 20:19 Vadym Kochan
2020-09-22 19:58 ` Thomas Petazzoni
2020-09-22 20:16 ` vadim4j at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba75762-e27c-7530-b133-b11735c24c7b@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
--cc=fperrad@gmail.com \
--cc=serhiy.boiko@plvision.eu \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.