[MPTCP] Re: [PATCH 0/3] mptcp: just another recvmsg refactor

[Matthieu Baerts <matthieu.baerts at tessares.net>]

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

Hi Paolo,

On 15/10/2019 22:39, Paolo Abeni wrote:
> On Tue, 2019-10-15 at 17:44 +0200, Paolo Abeni wrote:
>> I think this 3 patches should be squashed into
>> "mptcp: Implement MPTCP receive path", but the resulting one will be likely
>> too huge; possibly splitting the resulting code in 2 different patches would
>> be nicer. Additionally "mptcp: Implement MPTCP receive path" has some chunks
>> that should be likely moved to some other patches (e.g. ULP RCU fixes).
>>
>> What if - after the eventuall accept - I publish the resulting code of the
>> above squashing somewhere?
> 
> Since I'm an incurable optimist, I went ahead and pushed the rebase
> here:

Thank you for this work!

> https://github.com/pabeni/mptcp/tree/mptcp-proposal-recvmsg_rebase_7
> 
> Squashed:
> "mptcp: flush duplicate data at data_ready() time"
> and
> "mptcp: move some helper into the header file"
>    into "mptcp: Implement MPTCP receive path"
>      (and rewrote the commit message)
> 
> "mptcp: harmonize locking on all socket operations."
>    partially in
>      "mptcp: Associate MPTCP context with TCP socket"
>    and partially in
>      "mptcp: Create SUBFLOW socket for incoming connections"
> 
> Moved the RCU bits from "mptcp: Implement MPTCP receive path"
> into:
>    "mptcp: Associate MPTCP context with TCP socket"
> 
> Moved the options/ack_seq bits from "mptcp: Implement MPTCP receive
> path" into:
>    "mptcp: Write MPTCP DSS headers to outgoing data packets"
> 
> Rebased "mptcp: recvmsg() can drain data from multiple subflows" on top
> of "mptcp: Implement MPTCP receive path"
> 
> Removed a few intentation issue.
> 
> I checked for build issue only on the modified patches.
> 
> The overall diff from current export branch plus the pending patches is
> reported below.

Which ref of the "export" branch did you use? This branch has been 
overridden 3 times yesterday:
- around 3.52am: a rebase on latest net-next
- around 2.42pm: to include "selftests: allow compilation on older systems"
- around 5.23pm: to include "mptcp:pm: some cleanup"

Note that a rebase on latest net-next was done this night by the CI but 
that's easy to re-do.

Will you include the change proposed by Mat in a new rebase?

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium