All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
Date: Tue, 17 Aug 2021 21:48:39 +0200	[thread overview]
Message-ID: <fbca1ffe-443e-8684-2ad3-97a6198f857c@mind.be> (raw)
In-Reply-To: <20210813211648.3483726-1-fontaine.fabrice@gmail.com>



On 13/08/2021 23:16, Fabrice Fontaine wrote:
> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
> 
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 I've extended the commit message a bit to explain why it only happens with PPD.

 Regards,
 Arnout

> ---
>  package/fontconfig/fontconfig.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
> index d59e893d4d..e34acde534 100644
> --- a/package/fontconfig/fontconfig.mk
> +++ b/package/fontconfig/fontconfig.mk
> @@ -11,9 +11,11 @@ FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
>  FONTCONFIG_AUTORECONF = YES
>  FONTCONFIG_INSTALL_STAGING = YES
>  FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
> -	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux)
> +	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
> +	$(TARGET_NLS_DEPENDENCIES)
>  HOST_FONTCONFIG_DEPENDENCIES = \
> -	host-freetype host-expat host-pkgconf host-gperf host-util-linux
> +	host-freetype host-expat host-pkgconf host-gperf host-util-linux \
> +	host-gettext
>  FONTCONFIG_LICENSE = fontconfig license
>  FONTCONFIG_LICENSE_FILES = COPYING
>  FONTCONFIG_CPE_ID_VENDOR = fontconfig_project
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-08-17 19:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 21:16 [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS Fabrice Fontaine
2021-08-15  7:25 ` Thomas Petazzoni
2021-08-15  7:38   ` Fabrice Fontaine
2021-08-17 19:48 ` Arnout Vandecappelle [this message]
2021-09-04 21:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbca1ffe-443e-8684-2ad3-97a6198f857c@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.