From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE36C433E0 for ; Fri, 26 Jun 2020 02:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF5092088E for ; Fri, 26 Jun 2020 02:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgFZCjI (ORCPT ); Thu, 25 Jun 2020 22:39:08 -0400 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:45164 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728099AbgFZCjI (ORCPT ); Thu, 25 Jun 2020 22:39:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id E083318029210; Fri, 26 Jun 2020 02:39:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: duck56_1f0ce8a26e51 X-Filterd-Recvd-Size: 4537 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Fri, 26 Jun 2020 02:39:04 +0000 (UTC) Message-ID: Subject: Re: [net-next v3 05/15] iecm: Add basic netdevice functionality From: Joe Perches To: Jeff Kirsher , davem@davemloft.net Cc: Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Date: Thu, 25 Jun 2020 19:39:03 -0700 In-Reply-To: <20200626020737.775377-6-jeffrey.t.kirsher@intel.com> References: <20200626020737.775377-1-jeffrey.t.kirsher@intel.com> <20200626020737.775377-6-jeffrey.t.kirsher@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > This implements probe, interface up/down, and netdev_ops. trivial notes: > diff --git a/drivers/net/ethernet/intel/iecm/iecm_lib.c b/drivers/net/ethernet/intel/iecm/iecm_lib.c [] > @@ -194,7 +298,24 @@ static int iecm_vport_rel(struct iecm_vport *vport) > */ > static void iecm_vport_rel_all(struct iecm_adapter *adapter) > { > - /* stub */ > + int err, i; > + > + if (!adapter->vports) > + return; > + > + for (i = 0; i < adapter->num_alloc_vport; i++) { > + if (!adapter->vports[i]) > + continue; > + > + err = iecm_vport_rel(adapter->vports[i]); > + if (err) > + dev_dbg(&adapter->pdev->dev, > + "Failed to release adapter->vport[%d], err %d,\n", odd comma > + i, err); > + else > + adapter->vports[i] = NULL; > + } > + adapter->num_alloc_vport = 0; If one of these fails to release, why always set num_alloc_vport to 0? > @@ -273,7 +483,40 @@ static void iecm_init_task(struct work_struct *work) > */ > static int iecm_api_init(struct iecm_adapter *adapter) > { > - /* stub */ > + struct iecm_reg_ops *reg_ops = &adapter->dev_ops.reg_ops; > + struct pci_dev *pdev = adapter->pdev; > + > + if (!adapter->dev_ops.reg_ops_init) { > + dev_err(&pdev->dev, "Invalid device, register API init not defined.\n"); inconsistent uses of periods after logging messages. > + return -EINVAL; > + } > + adapter->dev_ops.reg_ops_init(adapter); > + if (!(reg_ops->ctlq_reg_init && reg_ops->vportq_reg_init && > + reg_ops->intr_reg_init && reg_ops->mb_intr_reg_init && > + reg_ops->reset_reg_init && reg_ops->trigger_reset)) { > + dev_err(&pdev->dev, "Invalid device, missing one or more register functions\n"); Most are without period. > + return -EINVAL; > + } > + > + if (adapter->dev_ops.vc_ops_init) { > + struct iecm_virtchnl_ops *vc_ops; > + > + adapter->dev_ops.vc_ops_init(adapter); > + vc_ops = &adapter->dev_ops.vc_ops; > + if (!(vc_ops->core_init && vc_ops->vport_init && > + vc_ops->vport_queue_ids_init && vc_ops->get_caps && > + vc_ops->config_queues && vc_ops->enable_queues && > + vc_ops->disable_queues && vc_ops->irq_map_unmap && > + vc_ops->get_set_rss_lut && vc_ops->get_set_rss_hash && > + vc_ops->adjust_qs && vc_ops->get_ptype)) { style trivia: Sometimes it's clearer for human readers if all the tests are separated on individual lines. > diff --git a/drivers/net/ethernet/intel/iecm/iecm_virtchnl.c b/drivers/net/ethernet/intel/iecm/iecm_virtchnl.c [] > @@ -594,6 +642,25 @@ static bool iecm_is_capability_ena(struct iecm_adapter *adapter, u64 flag) > */ > void iecm_vc_ops_init(struct iecm_adapter *adapter) > { > - /* stub */ Maybe add a temporary for adapter->dev_ops.vc_ops to reduce visual clutter? > + adapter->dev_ops.vc_ops.core_init = iecm_vc_core_init; > + adapter->dev_ops.vc_ops.vport_init = iecm_vport_init; > + adapter->dev_ops.vc_ops.vport_queue_ids_init = > + iecm_vport_queue_ids_init; > + adapter->dev_ops.vc_ops.get_caps = iecm_send_get_caps_msg; > + adapter->dev_ops.vc_ops.is_cap_ena = iecm_is_capability_ena;