All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>,
	Rami Rosen <ramirose@gmail.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand
Date: Wed, 20 Mar 2019 13:29:22 +0000	[thread overview]
Message-ID: <fbec222d-1b11-5802-08cc-bb3fd2b19eb8@intel.com> (raw)
In-Reply-To: <CAJFAV8yunZ0Ay27ZV_RYCeWJQYWf-kvNz6OyraBb3dcus-PVfg@mail.gmail.com>

On 3/20/2019 12:44 PM, David Marchand wrote:
> On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 3/20/2019 10:02 AM, David Marchand wrote:
>     > Add a new "show/clear fwd stats all" command to display fwd and port
>     > statistics on the fly.
> 
>     Won't this be duplicating existing commands:
>     "show port stats all|<port_id>"
>     "clear port stats all|<port_id>"
> 
>     What benefit "show/clear fwd stats all" adds against existing ones?
> 
> 
> Forwarding engines like "iofwd" maintain software statistics like "fwd_dropped"
> which gives you how much of the packets to be transmitted could not make it to
> the "wire".
> "show port stats" won't give you those stats.
> 
> You could stop/start the forwarding to get them, but when debugging you most
> likely do not want to stop the forwarding.
> I have been using this while tracking drops in a PVP setup.

I see, they are slightly different, no objection from me.

  reply	other threads:[~2019-03-20 13:29 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 15:42 [PATCH 0/5] display testpmd forwarding engine stats on the fly David Marchand
2019-02-14 15:42 ` [PATCH 1/5] app/testpmd: remove unused fwd_ctx field David Marchand
2019-02-18 19:55   ` Rami Rosen
2019-02-14 15:42 ` [PATCH 2/5] app/testpmd: add missing newline when showing statistics David Marchand
2019-02-19  5:48   ` Rami Rosen
2019-02-14 15:42 ` [PATCH 3/5] app/testpmd: add missing transmit errors stats David Marchand
2019-02-14 16:30   ` Bruce Richardson
2019-02-14 17:39     ` David Marchand
2019-02-14 18:51       ` David Marchand
2019-02-15  8:57         ` Thomas Monjalon
2019-02-15  9:33           ` David Marchand
2019-02-15 14:05             ` Bruce Richardson
2019-02-15 14:13               ` Wiles, Keith
2019-02-15 15:04               ` David Marchand
2019-02-15 16:19                 ` Thomas Monjalon
2019-02-15 17:32                   ` David Marchand
2019-02-15 18:15                     ` Ananyev, Konstantin
2019-02-15 18:31                       ` David Marchand
2019-02-15 18:42                         ` Ananyev, Konstantin
2019-02-15 19:38                           ` Thomas Monjalon
2019-02-16  0:37                             ` Stephen Hemminger
2019-02-16 13:23                               ` Ananyev, Konstantin
2019-02-16 12:50                             ` Ananyev, Konstantin
2019-02-20  8:33                               ` David Marchand
2019-02-24 11:55                                 ` Ananyev, Konstantin
2019-02-14 15:42 ` [PATCH 4/5] app/testpmd: remove useless casts on statistics David Marchand
2019-02-14 15:42 ` [PATCH 5/5] app/testpmd: display/clear forwarding stats on demand David Marchand
2019-03-11 15:35 ` [PATCH v2 0/4] display testpmd forwarding engine stats on the fly David Marchand
2019-03-11 15:35   ` [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field David Marchand
2019-03-19 18:29     ` [dpdk-stable] " Ferruh Yigit
2019-03-11 15:35   ` [PATCH v2 2/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-11 15:53     ` Andrew Rybchenko
2019-03-11 15:35   ` [PATCH v2 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-11 15:57     ` Andrew Rybchenko
2019-03-11 16:03       ` David Marchand
2019-03-11 15:35   ` [PATCH v2 4/4] app/testpmd: display/clear forwarding stats on demand David Marchand
2019-03-20 10:02   ` [PATCH v3 0/4] display testpmd forwarding engine stats on the fly David Marchand
2019-03-20 10:02     ` [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-20 13:49       ` Andrew Rybchenko
2019-03-20 10:02     ` [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-20 13:55       ` Andrew Rybchenko
2019-03-20 10:02     ` [PATCH v3 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-20 13:58       ` Andrew Rybchenko
2019-03-20 10:02     ` [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand David Marchand
2019-03-20 12:25       ` Ferruh Yigit
2019-03-20 12:44         ` David Marchand
2019-03-20 13:29           ` Ferruh Yigit [this message]
2019-03-21 18:50       ` Ferruh Yigit
2019-03-21 20:34         ` David Marchand
2019-03-22 13:37     ` [PATCH v4 0/4] display testpmd forwarding engine stats on the fly David Marchand
2019-03-22 13:37       ` [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-22 17:03         ` Maxime Coquelin
2019-03-22 17:17         ` Maxime Coquelin
2019-03-22 17:23           ` David Marchand
2019-03-22 17:31             ` Andrew Rybchenko
2019-03-22 17:35         ` Andrew Rybchenko
2019-03-22 17:43           ` David Marchand
2019-03-23 19:12             ` David Marchand
2019-03-25  6:34               ` Andrew Rybchenko
2019-03-22 13:37       ` [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-22 17:06         ` Maxime Coquelin
2019-03-22 13:37       ` [PATCH v4 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-22 17:11         ` Maxime Coquelin
2019-03-22 13:37       ` [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand David Marchand
2019-03-22 17:22         ` Maxime Coquelin
2019-03-25  8:51       ` [PATCH v5 0/4] display testpmd forwarding engine stats on the fly David Marchand
2019-03-25  8:51         ` [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-25  8:55           ` Andrew Rybchenko
2019-03-25  8:51         ` [PATCH v5 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-25  8:51         ` [PATCH v5 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-25  8:51         ` [PATCH v5 4/4] app/testpmd: display/clear forwarding stats on demand David Marchand
2019-03-25 14:05         ` [PATCH v5 0/4] display testpmd forwarding engine stats on the fly Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbec222d-1b11-5802-08cc-bb3fd2b19eb8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=ramirose@gmail.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.