From: Lee Duncan <lduncan@suse.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.com>, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 4/7] iscsi: Use scsi_get_pos() instead of scsi_get_lba()
Date: Sun, 9 May 2021 18:14:08 -0700 [thread overview]
Message-ID: <fbf33a76-18b5-008c-a28d-09ae158f0c24@suse.com> (raw)
In-Reply-To: <20210509214307.4610-5-bvanassche@acm.org>
On 5/9/21 2:43 PM, Bart Van Assche wrote:
> Use scsi_get_pos() instead of scsi_get_lba() since the name of the latter
> is confusing. Additionally, use lower_32_bits() instead of open-coding it.
> This patch does not change any functionality.
>
> Cc: Lee Duncan <lduncan@suse.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/isci/request.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
> index e7c6cb4c1556..1c25f28385fd 100644
> --- a/drivers/scsi/isci/request.c
> +++ b/drivers/scsi/isci/request.c
> @@ -341,7 +341,7 @@ static void scu_ssp_ireq_dif_insert(struct isci_request *ireq, u8 type, u8 op)
> tc->reserved_E8_0 = 0;
>
> if ((type & SCSI_PROT_DIF_TYPE1) || (type & SCSI_PROT_DIF_TYPE2))
> - tc->ref_tag_seed_gen = scsi_get_lba(scmd) & 0xffffffff;
> + tc->ref_tag_seed_gen = lower_32_bits(scsi_get_pos(scmd));
> else if (type & SCSI_PROT_DIF_TYPE3)
> tc->ref_tag_seed_gen = 0;
> }
> @@ -369,7 +369,7 @@ static void scu_ssp_ireq_dif_strip(struct isci_request *ireq, u8 type, u8 op)
> tc->app_tag_gen = 0;
>
> if ((type & SCSI_PROT_DIF_TYPE1) || (type & SCSI_PROT_DIF_TYPE2))
> - tc->ref_tag_seed_verify = scsi_get_lba(scmd) & 0xffffffff;
> + tc->ref_tag_seed_verify = lower_32_bits(scsi_get_pos(scmd));
> else if (type & SCSI_PROT_DIF_TYPE3)
> tc->ref_tag_seed_verify = 0;
>
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
next prev parent reply other threads:[~2021-05-10 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 21:43 [PATCH 0/7] Rename scsi_get_lba() into scsi_get_pos() Bart Van Assche
2021-05-09 21:43 ` [PATCH 1/7] Introduce scsi_get_pos() Bart Van Assche
2021-05-09 21:43 ` [PATCH 2/7] iser: Use scsi_get_pos() instead of scsi_get_lba() Bart Van Assche
2021-05-09 21:43 ` [PATCH 3/7] zfcp: " Bart Van Assche
2021-05-09 21:43 ` [PATCH 4/7] iscsi: " Bart Van Assche
2021-05-10 1:14 ` Lee Duncan [this message]
2021-05-09 21:43 ` [PATCH 5/7] qla2xxx: " Bart Van Assche
2021-05-09 21:43 ` [PATCH 6/7] ufs: Fix the tracing code Bart Van Assche
2021-05-09 21:43 ` [PATCH 7/7] Remove scsi_get_lba() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf33a76-18b5-008c-a28d-09ae158f0c24@suse.com \
--to=lduncan@suse.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.