From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A5C1C433EF for ; Mon, 2 May 2022 16:00:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B75C383E0E; Mon, 2 May 2022 18:00:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651507219; bh=KzecSbKVcUquWD8n6WDlSr2WgIguQj1J3aMgIOUMkWc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w6Ln/3gHSfscE0/fc2qKdsu5UXiQtga/Ed16S2sSexQESBuZYQuD0zzBNddA4it5x r6aYGc3APiUAhpywoObjMkSnUkhP5ElYkSZa+OKDPQcz8XnJGUbZiEhwoXH5R0g7AY MaAFyyFujUtaGgRAN9DU7m+1eRDsjroWPBgkuYub2lP0UK0Ef85N3abh7gAqfQJZL6 3zkhLiGZG1DH+159VRBvOk5dSImYxYUk4cHdKijP8Yu0MDeaKkPWx9HII2MB8X1XCt 0CGQr+eFRLQFevQHBs2QFUk8XfHrk68+1yb32pYJ0axRsWkxVz/HKpv7xS2ENlcdRT xIUczgMH0o1Pg== Received: by phobos.denx.de (Postfix, from userid 109) id 5E17C83E0E; Mon, 2 May 2022 18:00:17 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C20AC83E96 for ; Mon, 2 May 2022 18:00:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4KsSV44kqNz9sVy; Mon, 2 May 2022 18:00:12 +0200 (CEST) Message-ID: Date: Mon, 2 May 2022 18:00:08 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 00/52] mips: octeon: Add ethernet support Content-Language: en-US From: Stefan Roese To: u-boot@lists.denx.de, daniel.schwierzeck@gmail.com Cc: awilliams@marvell.com, cchavva@marvell.com References: <20220407071154.51997-1-sr@denx.de> In-Reply-To: <20220407071154.51997-1-sr@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Daniel, On 07.04.22 09:11, Stefan Roese wrote: > This patchset adds the networking files and drivers including device > helper headers and C files. Please excuse the massive amount of files > in this patch series. Also the sometimes huge files (mostly headers > with register definitions) that I needed to include. > > The infrastructure code with all the headers is ported mistly without > any intended functional changes from the 2013 Cavium / Marvell U-Boot > version. It has undergone many hours of extensive code cleanup and > reformatting. Some of it done by using tools (checkpatch, Lindent, clang > format etc) and also some of it done manually, as I couldn't find some > tools that could do the needed work in a reliable and functional way. > The result is that checkpatch now only throws a "few" warnings that are > left. Some of those can't be removed without an even more extensive > cleanup / rewrite of the code, like the addition of typedefs. > > The added header, helper and infrastructure files in the first part of > the patch-series (patches 1-43) are the foundation, that is used by the > main Octeon U-Boot ethernet driver (patch 50/52). Patches 47-49 add the > DT nodes and properties to the corresponding dtsi / dts files. Patches > 51 & 52 finally enable the ethernet support both MIPS Octeon boards, > EBB7304 & NIC23. > > All this is tested on the 2 Cavium / Marvell MIPS Octeon boards: > EBB7304 & NIC23 > > This patchset including the small Marvell PHY patches is available in > this gitlab branch: > > https://source.denx.de/u-boot/custodians/u-boot-marvell/-/tree/mips-octeon-ethernet-v2-2022-04-07 > > Changes in v2: > - As suggested by Daniel, remove all unreferenced functions from the source > code by manually inspecting u-boot.map [1] > - Rebased on latest TOT > > [1] Here the diffstat comarison between v1 and v2: > v1: 77 files changed, 42315 insertions(+), 586 deletions(-) > v2: 78 files changed, 33672 insertions(+), 2524 deletions(-) > > Thanks, > Stefan Daniel, do you have any comments on this patchset? Tom has assigned it to me in patchwork and I would really like to get it merged into mainline, if possible. So if you don't have any obejctions, then I would pull it via the Marvell tree soon. Thanks, Stefan