From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbdF2ME2 (ORCPT ); Thu, 29 Jun 2017 08:04:28 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:63427 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbdF2MEV (ORCPT ); Thu, 29 Jun 2017 08:04:21 -0400 X-AuditID: cbfec7f2-f797e6d000004438-53-5954ecc284fc Subject: Re: [PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue To: Thierry Escande , Jacek Anaszewski , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Pietrasiewicz Message-id: Date: Thu, 29 Jun 2017 14:04:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <1498579734-1594-5-git-send-email-thierry.escande@collabora.com> Content-type: text/plain; charset=utf-8; format=flowed Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7qH3oREGqxfJmdxe+sGFovLu+aw WfRs2MpqsWzTHyaL/quX2BxYPXbcXcLosXPWXXaPTas62Tw+b5ILYInisklJzcksSy3St0vg yjh8vZGxYJZgReu72AbG17xdjJwcEgImEsfPzGGHsMUkLtxbz9bFyMUhJLCUUeLsptnsEM5n Rolvz96xwnQ8aVjIDJFYxigx5/MzqKoXjBLHt/SzgVQJCyRLLLj6iRUkISIwgVHiwLadYEuY BWwlOg51soDYbALGEnsPdjCC2LwCdhKtp9aCrWARUJXYfv4FmC0qECGxaNJEdogaQYkfk++B 9XIK+Erca73GBDHTSuLZv1ZWCFtcorn1JguELS+xec1bZoiz57FLvNnk18XIAWTLSmw6ABV2 kehv3sgEYQtLvDq+BRoWMhKXJ3ezgNwvITCZUWLDzQ9QznZGibXHTkDDwlri8PGLUIv5JCZt m84MsYBXoqNNCKLEQ2LKvBZWiLCjxMpViZDAeswo0fC1k30Co8IsJK/NQvLOLCTvzELyzgJG llWMIqmlxbnpqcXGesWJucWleel6yfm5mxiBKeb0v+OfdjB+PWF1iFGAg1GJh5dhbXCkEGti WXFl7iFGCQ5mJRFe5hchkUK8KYmVValF+fFFpTmpxYcYpTlYlMR5uU5dixASSE8sSc1OTS1I LYLJMnFwSjUwZsxK9jQ7Eiozxb+Iuz8+pSPr66LcYJ5Z8bPFgw/6ZEdPWXVjWeff62sF3yc+ FHmf8yZCU57NpvrKEjsZJubyEy+CdvjKzVOccWCpYUJjVoRP4yfNN9ndP5qmBQg7RZ05sEW3 2/3zpkuWAT8jby69b/9+mvjvD06itqH302SYpAumqL42yDirxFKckWioxVxUnAgAgUtgeS0D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t/xq7oH34REGhw9aWhxe+sGFovLu+aw WfRs2MpqsWzTHyaL/quX2BxYPXbcXcLosXPWXXaPTas62Tw+b5ILYIlys8lITUxJLVJIzUvO T8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bh642MBbME K1rfxTYwvubtYuTkkBAwkXjSsJAZwhaTuHBvPVsXIxeHkMASRomrc5YxQjgvGCVaVzawglQJ CyRLLN54kR0kISIwiVFi5da/TCAJZgFbiY5DnSwQHY8ZJTbuXAqWYBMwlth7sIMRxOYVsJNo PbUWbBKLgKrE9vMvwGxRgQiJXdcPsELUCEr8mHyPBcTmFPCVuNd6DWqBmcSXl4dZIWxxiebW mywQtrzE5jVvmScwCs5C0j4LScssJC2zkLQsYGRZxSiSWlqcm55bbKRXnJhbXJqXrpecn7uJ ERhx24793LKDsetd8CFGAQ5GJR5ehrXBkUKsiWXFlbmHGCU4mJVEeJlfhEQK8aYkVlalFuXH F5XmpBYfYjQFem4is5Rocj4wGeSVxBuaGJpbGhoZW1iYGxkpifNO/XAlXEggPbEkNTs1tSC1 CKaPiYNTqoFxuswptenv1v3o91yZJLHmqkK0bz+/JVdxvfpt5dk7rk1bYxumttXzxpbvYtPf TtKVMb1yMWER64aMaRdWWXzy/L/vvJClaN/y+8uNlqevT990p/ypLeO7NX8auy7ckG2MV3p4 5qbYrLAP51j74usvWbKxBF9a1ca757XuD9b7S9k+Fn5pWq+Xo8RSnJFoqMVcVJwIAHKz/jLO AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170629120418eucas1p2a174fb21915460eeca186203cd50f374 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBQaWV0cmFzaWV3aWN6G1NSUE9MLUtlcm5lbCAo?= =?UTF-8?B?VFApG+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBUb21hc3ogUGlldHJhc2lld2ljehtTUlBPTC1L?= =?UTF-8?B?ZXJuZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2Fy?= =?UTF-8?B?ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170627161115epcas5p230b784dfa1536f5e746f1a6738f43e9a X-RootMTR: 20170627161115epcas5p230b784dfa1536f5e746f1a6738f43e9a References: <1498579734-1594-1-git-send-email-thierry.escande@collabora.com> <1498579734-1594-5-git-send-email-thierry.escande@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 27.06.2017 o 18:08, Thierry Escande pisze: > If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed > s5p_jpeg_q_data structure is not modify so there is no need to use a > temporary structure and the field-by-field copy can be avoided. > > Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c > index df3e5ee..1769744 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c > @@ -2500,9 +2500,9 @@ static void s5p_jpeg_buf_queue(struct vb2_buffer *vb) > > if (ctx->mode == S5P_JPEG_DECODE && > vb->vb2_queue->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) { > - struct s5p_jpeg_q_data tmp, *q_data; > + struct s5p_jpeg_q_data *q_data; > > - ctx->hdr_parsed = s5p_jpeg_parse_hdr(&tmp, > + ctx->hdr_parsed = s5p_jpeg_parse_hdr(&ctx->out_q, > (unsigned long)vb2_plane_vaddr(vb, 0), > min((unsigned long)ctx->out_q.size, > vb2_get_plane_payload(vb, 0)), ctx); > @@ -2511,24 +2511,9 @@ static void s5p_jpeg_buf_queue(struct vb2_buffer *vb) > return; > } > > - q_data = &ctx->out_q; > - q_data->w = tmp.w; > - q_data->h = tmp.h; > - q_data->sos = tmp.sos; > - memcpy(q_data->dht.marker, tmp.dht.marker, > - sizeof(tmp.dht.marker)); > - memcpy(q_data->dht.len, tmp.dht.len, sizeof(tmp.dht.len)); > - q_data->dht.n = tmp.dht.n; > - memcpy(q_data->dqt.marker, tmp.dqt.marker, > - sizeof(tmp.dqt.marker)); > - memcpy(q_data->dqt.len, tmp.dqt.len, sizeof(tmp.dqt.len)); > - q_data->dqt.n = tmp.dqt.n; > - q_data->sof = tmp.sof; > - q_data->sof_len = tmp.sof_len; > - > q_data = &ctx->cap_q; > - q_data->w = tmp.w; > - q_data->h = tmp.h; > + q_data->w = ctx->out_q.w; > + q_data->h = ctx->out_q.h; > > /* > * This call to jpeg_bound_align_image() takes care of width and >