From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754920AbdKAQmK (ORCPT ); Wed, 1 Nov 2017 12:42:10 -0400 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:31971 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbdKAQmH (ORCPT ); Wed, 1 Nov 2017 12:42:07 -0400 From: X-LoopCount0: from 10.166.132.190 X-IronPort-AV: E=Sophos;i="5.44,329,1505797200"; d="scan'208";a="570552796" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , , , , , , Subject: RE: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Thread-Topic: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Thread-Index: AQHTUXTTauMHyQBw1EGBPpKIXVEeQKL8YmGggAKPXACAAJNsgIAAMxrA Date: Wed, 1 Nov 2017 16:42:05 +0000 Message-ID: References: <20171030114652.kopuffflshq2ates@pali> <27e2d166f2ce461fb025ebf06a284d01@ausx13mpc124.AMER.DELL.COM> <20171031233146.GA5787@fury> <20171101081925.66gca5sqtqcnpksu@pali> In-Reply-To: <20171101081925.66gca5sqtqcnpksu@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA1GgF3D011799 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Wednesday, November 1, 2017 3:19 AM > To: Darren Hart > Cc: Limonciello, Mario ; > andy.shevchenko@gmail.com; linux-kernel@vger.kernel.org; platform-driver- > x86@vger.kernel.org; luto@kernel.org; quasisec@google.com; rjw@rjwysocki.net; > mjg59@google.com; hch@lst.de; greg@kroah.com; gnomes@lxorguk.ukuu.org.uk > Subject: Re: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI > descriptor into it's own driver > > On Tuesday 31 October 2017 16:31:46 Darren Hart wrote: > > On Mon, Oct 30, 2017 at 01:32:57PM +0000, Mario.Limonciello@dell.com wrote: > > > > > > > > > > -----Original Message----- > > > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > > > Sent: Monday, October 30, 2017 6:47 AM > > > > To: Limonciello, Mario > > > > Cc: dvhart@infradead.org; Andy Shevchenko ; > > > > LKML ; platform-driver-x86@vger.kernel.org; > Andy > > > > Lutomirski ; quasisec@google.com; rjw@rjwysocki.net; > > > > mjg59@google.com; hch@lst.de; Greg KH ; Alan Cox > > > > > > > > Subject: Re: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI > > > > descriptor into it's own driver > > > > > > > > On Friday 20 October 2017 12:40:20 Mario Limonciello wrote: > > > > > diff --git a/drivers/platform/x86/dell-wmi-descriptor.c > > > > b/drivers/platform/x86/dell-wmi-descriptor.c > > > > > new file mode 100644 > > > > > index 000000000000..3204c408e261 > > > > > --- /dev/null > > > > > +++ b/drivers/platform/x86/dell-wmi-descriptor.c > > > > > > > > This dell-wmi-descriptor.c looks good now! > > > > > > > > > diff --git a/drivers/platform/x86/dell-wmi-descriptor.h > > > > b/drivers/platform/x86/dell-wmi-descriptor.h > > > > > new file mode 100644 > > > > > index 000000000000..5f7b69c2c83a > > > > > --- /dev/null > > > > > +++ b/drivers/platform/x86/dell-wmi-descriptor.h > > > > > @@ -721,7 +652,9 @@ static int dell_wmi_events_set_enabled(bool > enable) > > > > > static int dell_wmi_probe(struct wmi_device *wdev) > > > > > { > > > > > struct dell_wmi_priv *priv; > > > > > - int err; > > > > > + > > > > > + if (!wmi_has_guid(DELL_WMI_DESCRIPTOR_GUID)) > > > > > + return -ENODEV; > > > > > > > > > > priv = devm_kzalloc( > > > > > &wdev->dev, sizeof(struct dell_wmi_priv), GFP_KERNEL); > > > > > @@ -729,9 +662,8 @@ static int dell_wmi_probe(struct wmi_device > *wdev) > > > > > return -ENOMEM; > > > > > dev_set_drvdata(&wdev->dev, priv); > > > > > > > > > > - err = dell_wmi_check_descriptor_buffer(wdev); > > > > > - if (err) > > > > > - return err; > > > > > + if (!dell_wmi_get_interface_version(&priv->interface_version)) > > > > > + return -EPROBE_DEFER; > > > > > > > > But here is still a problem. You added check that > > > > DELL_WMI_DESCRIPTOR_GUID exists in APCI table, but it does not mean that > > > > probe method of dell-wmi-descriptor cannot fail. > > > > > > > > With PROBE_DEFER, dell_wmi_probe function would be called later again > > > > and again, even when probing dell-wmi-descriptor failed and so dell-wmi > > > > in this case cannot work. > > > > > > > > > > Yes it's possible that probe method can fail, but it depends on the reason for > > > failure if it will fail again later. For example if not enough memory, it may work > > > later. Or maybe user manually unbound from GUID, should continue to try until > > > it's bound again. > > > > > > So in short, I believe this is the correct behavior to adopt. > > > > In this case, I believe the synchronous request_module("dell-wmi-descriptor") > > would provide the desired result. The exit status doesn't even need to be > > checked. If that is successful, and the interface_version still returns false, > > then it can be considered an error and we can exit. If it fails, the > > interface_version will return false, and it is also an error. > > > > This can be easily added as a single patch on top of this series: > > > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > > index dcfa5de..964ca54 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -665,8 +665,9 @@ static int dell_wmi_probe(struct wmi_device *wdev) > > return -ENOMEM; > > dev_set_drvdata(&wdev->dev, priv); > > > > + request_module("dell-wmi-descriptor"); > > if (!dell_wmi_get_interface_version(&priv->interface_version)) > > - return -EPROBE_DEFER; > > + return -ENODEV; > > > > return dell_wmi_input_setup(wdev); > > } > > > > Pali, I believe this addresses your concern? This proposed approach would actually introduce a problem of when a device is unbound on the dell-wmi-descriptor then you bind dell-wmi now it's possible to get into a state of probe routine failed on dell-wmi and can't be fixed without unbind dell-wmi, bind dell-wmi-descriptor and then rebind dell-wmi. With deferred probing solution I had in place that above problem can't happen because probing would just re-run. > > I'm not sure what happen if both drivers are statically linked into > vmlinuz and dell-wmi probe method would be called before > dell-wmi-descriptor method. That's why this is better to do using deferred probing I think still. > > What is doing request_module when requested module is statically linked > into vmlinuz? > As I can tell request_module actually calls out to userspace to run modprobe on the requested module. Something that may help with Pali's concern is to in the probe routine for dell-wmi-descritptor set something in a global variable for an error code and have a function to look that up. In the error scenario for a non memory allocation error set that value. Something like this: /* valid = 0 means probe hasn't run, valid = 1 means successful probe, * valid < 0 means failed probe due to bad device */ static int dell_wmi_descriptor_valid(void) { int ret; mutex_lock(&list_mutex); if (valid == 0) ret = -EPROBE_DEFER; else if ret = valid; mutex_unlock(&list_mutex) return ret; } Then dell-wmi and dell-smbios-wmi can call that before dell_wmi_get_interface_version. Does that satisfy Pali's concern? I may follow up with this particular item in a later patch so as to not derail current efforts unless Darren or Andy would like this sorted ASAP or I get through testing it quickly. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Date: Wed, 1 Nov 2017 16:42:05 +0000 Message-ID: References: <20171030114652.kopuffflshq2ates@pali> <27e2d166f2ce461fb025ebf06a284d01@ausx13mpc124.AMER.DELL.COM> <20171031233146.GA5787@fury> <20171101081925.66gca5sqtqcnpksu@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:31971 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbdKAQmH (ORCPT ); Wed, 1 Nov 2017 12:42:07 -0400 In-Reply-To: <20171101081925.66gca5sqtqcnpksu@pali> Content-Language: en-US Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: pali.rohar@gmail.com, dvhart@infradead.org Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBQYWxpIFJvaMOhciBbbWFpbHRv OnBhbGkucm9oYXJAZ21haWwuY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDEsIDIw MTcgMzoxOSBBTQ0KPiBUbzogRGFycmVuIEhhcnQgPGR2aGFydEBpbmZyYWRlYWQub3JnPg0KPiBD YzogTGltb25jaWVsbG8sIE1hcmlvIDxNYXJpb19MaW1vbmNpZWxsb0BEZWxsLmNvbT47DQo+IGFu ZHkuc2hldmNoZW5rb0BnbWFpbC5jb207IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IHBs YXRmb3JtLWRyaXZlci0NCj4geDg2QHZnZXIua2VybmVsLm9yZzsgbHV0b0BrZXJuZWwub3JnOyBx dWFzaXNlY0Bnb29nbGUuY29tOyByandAcmp3eXNvY2tpLm5ldDsNCj4gbWpnNTlAZ29vZ2xlLmNv bTsgaGNoQGxzdC5kZTsgZ3JlZ0Brcm9haC5jb207IGdub21lc0BseG9yZ3VrLnVrdXUub3JnLnVr DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjExIDA1LzE1XSBwbGF0Zm9ybS94ODY6IGRlbGwtd21p LWRlc2NyaXB0b3I6IHNwbGl0IFdNSQ0KPiBkZXNjcmlwdG9yIGludG8gaXQncyBvd24gZHJpdmVy DQo+IA0KPiBPbiBUdWVzZGF5IDMxIE9jdG9iZXIgMjAxNyAxNjozMTo0NiBEYXJyZW4gSGFydCB3 cm90ZToNCj4gPiBPbiBNb24sIE9jdCAzMCwgMjAxNyBhdCAwMTozMjo1N1BNICswMDAwLCBNYXJp by5MaW1vbmNpZWxsb0BkZWxsLmNvbSB3cm90ZToNCj4gPiA+DQo+ID4gPg0KPiA+ID4gPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiBGcm9tOiBQYWxpIFJvaMOhciBbbWFpbHRv OnBhbGkucm9oYXJAZ21haWwuY29tXQ0KPiA+ID4gPiBTZW50OiBNb25kYXksIE9jdG9iZXIgMzAs IDIwMTcgNjo0NyBBTQ0KPiA+ID4gPiBUbzogTGltb25jaWVsbG8sIE1hcmlvIDxNYXJpb19MaW1v bmNpZWxsb0BEZWxsLmNvbT4NCj4gPiA+ID4gQ2M6IGR2aGFydEBpbmZyYWRlYWQub3JnOyBBbmR5 IFNoZXZjaGVua28gPGFuZHkuc2hldmNoZW5rb0BnbWFpbC5jb20+Ow0KPiA+ID4gPiBMS01MIDxs aW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnPjsgcGxhdGZvcm0tZHJpdmVyLXg4NkB2Z2VyLmtl cm5lbC5vcmc7DQo+IEFuZHkNCj4gPiA+ID4gTHV0b21pcnNraSA8bHV0b0BrZXJuZWwub3JnPjsg cXVhc2lzZWNAZ29vZ2xlLmNvbTsgcmp3QHJqd3lzb2NraS5uZXQ7DQo+ID4gPiA+IG1qZzU5QGdv b2dsZS5jb207IGhjaEBsc3QuZGU7IEdyZWcgS0ggPGdyZWdAa3JvYWguY29tPjsgQWxhbiBDb3gN Cj4gPiA+ID4gPGdub21lc0BseG9yZ3VrLnVrdXUub3JnLnVrPg0KPiA+ID4gPiBTdWJqZWN0OiBS ZTogW1BBVENIIHYxMSAwNS8xNV0gcGxhdGZvcm0veDg2OiBkZWxsLXdtaS1kZXNjcmlwdG9yOiBz cGxpdCBXTUkNCj4gPiA+ID4gZGVzY3JpcHRvciBpbnRvIGl0J3Mgb3duIGRyaXZlcg0KPiA+ID4g Pg0KPiA+ID4gPiBPbiBGcmlkYXkgMjAgT2N0b2JlciAyMDE3IDEyOjQwOjIwIE1hcmlvIExpbW9u Y2llbGxvIHdyb3RlOg0KPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BsYXRmb3JtL3g4 Ni9kZWxsLXdtaS1kZXNjcmlwdG9yLmMNCj4gPiA+ID4gYi9kcml2ZXJzL3BsYXRmb3JtL3g4Ni9k ZWxsLXdtaS1kZXNjcmlwdG9yLmMNCj4gPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+ ID4gPiA+IGluZGV4IDAwMDAwMDAwMDAwMC4uMzIwNGM0MDhlMjYxDQo+ID4gPiA+ID4gLS0tIC9k ZXYvbnVsbA0KPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvcGxhdGZvcm0veDg2L2RlbGwtd21pLWRl c2NyaXB0b3IuYw0KPiA+ID4gPg0KPiA+ID4gPiBUaGlzIGRlbGwtd21pLWRlc2NyaXB0b3IuYyBs b29rcyBnb29kIG5vdyENCj4gPiA+ID4NCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9w bGF0Zm9ybS94ODYvZGVsbC13bWktZGVzY3JpcHRvci5oDQo+ID4gPiA+IGIvZHJpdmVycy9wbGF0 Zm9ybS94ODYvZGVsbC13bWktZGVzY3JpcHRvci5oDQo+ID4gPiA+ID4gbmV3IGZpbGUgbW9kZSAx MDA2NDQNCj4gPiA+ID4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjVmN2I2OWMyYzgzYQ0KPiA+ID4g PiA+IC0tLSAvZGV2L251bGwNCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL3BsYXRmb3JtL3g4Ni9k ZWxsLXdtaS1kZXNjcmlwdG9yLmgNCj4gPiA+ID4gPiBAQCAtNzIxLDcgKzY1Miw5IEBAIHN0YXRp YyBpbnQgZGVsbF93bWlfZXZlbnRzX3NldF9lbmFibGVkKGJvb2wNCj4gZW5hYmxlKQ0KPiA+ID4g PiA+ICBzdGF0aWMgaW50IGRlbGxfd21pX3Byb2JlKHN0cnVjdCB3bWlfZGV2aWNlICp3ZGV2KQ0K PiA+ID4gPiA+ICB7DQo+ID4gPiA+ID4gIAlzdHJ1Y3QgZGVsbF93bWlfcHJpdiAqcHJpdjsNCj4g PiA+ID4gPiAtCWludCBlcnI7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsJaWYgKCF3bWlfaGFz X2d1aWQoREVMTF9XTUlfREVTQ1JJUFRPUl9HVUlEKSkNCj4gPiA+ID4gPiArCQlyZXR1cm4gLUVO T0RFVjsNCj4gPiA+ID4gPg0KPiA+ID4gPiA+ICAJcHJpdiA9IGRldm1fa3phbGxvYygNCj4gPiA+ ID4gPiAgCQkmd2Rldi0+ZGV2LCBzaXplb2Yoc3RydWN0IGRlbGxfd21pX3ByaXYpLCBHRlBfS0VS TkVMKTsNCj4gPiA+ID4gPiBAQCAtNzI5LDkgKzY2Miw4IEBAIHN0YXRpYyBpbnQgZGVsbF93bWlf cHJvYmUoc3RydWN0IHdtaV9kZXZpY2UNCj4gKndkZXYpDQo+ID4gPiA+ID4gIAkJcmV0dXJuIC1F Tk9NRU07DQo+ID4gPiA+ID4gIAlkZXZfc2V0X2RydmRhdGEoJndkZXYtPmRldiwgcHJpdik7DQo+ ID4gPiA+ID4NCj4gPiA+ID4gPiAtCWVyciA9IGRlbGxfd21pX2NoZWNrX2Rlc2NyaXB0b3JfYnVm ZmVyKHdkZXYpOw0KPiA+ID4gPiA+IC0JaWYgKGVycikNCj4gPiA+ID4gPiAtCQlyZXR1cm4gZXJy Ow0KPiA+ID4gPiA+ICsJaWYgKCFkZWxsX3dtaV9nZXRfaW50ZXJmYWNlX3ZlcnNpb24oJnByaXYt PmludGVyZmFjZV92ZXJzaW9uKSkNCj4gPiA+ID4gPiArCQlyZXR1cm4gLUVQUk9CRV9ERUZFUjsN Cj4gPiA+ID4NCj4gPiA+ID4gQnV0IGhlcmUgaXMgc3RpbGwgYSBwcm9ibGVtLiBZb3UgYWRkZWQg Y2hlY2sgdGhhdA0KPiA+ID4gPiBERUxMX1dNSV9ERVNDUklQVE9SX0dVSUQgZXhpc3RzIGluIEFQ Q0kgdGFibGUsIGJ1dCBpdCBkb2VzIG5vdCBtZWFuIHRoYXQNCj4gPiA+ID4gcHJvYmUgbWV0aG9k IG9mIGRlbGwtd21pLWRlc2NyaXB0b3IgY2Fubm90IGZhaWwuDQo+ID4gPiA+DQo+ID4gPiA+IFdp dGggUFJPQkVfREVGRVIsIGRlbGxfd21pX3Byb2JlIGZ1bmN0aW9uIHdvdWxkIGJlIGNhbGxlZCBs YXRlciBhZ2Fpbg0KPiA+ID4gPiBhbmQgYWdhaW4sIGV2ZW4gd2hlbiBwcm9iaW5nIGRlbGwtd21p LWRlc2NyaXB0b3IgZmFpbGVkIGFuZCBzbyBkZWxsLXdtaQ0KPiA+ID4gPiBpbiB0aGlzIGNhc2Ug Y2Fubm90IHdvcmsuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gWWVzIGl0J3MgcG9zc2libGUgdGhh dCBwcm9iZSBtZXRob2QgY2FuIGZhaWwsIGJ1dCBpdCBkZXBlbmRzIG9uIHRoZSByZWFzb24gZm9y DQo+ID4gPiBmYWlsdXJlIGlmIGl0IHdpbGwgZmFpbCBhZ2FpbiBsYXRlci4gIEZvciBleGFtcGxl IGlmIG5vdCBlbm91Z2ggbWVtb3J5LCBpdCBtYXkgd29yaw0KPiA+ID4gbGF0ZXIuICBPciBtYXli ZSB1c2VyIG1hbnVhbGx5IHVuYm91bmQgZnJvbSBHVUlELCBzaG91bGQgY29udGludWUgdG8gdHJ5 IHVudGlsDQo+ID4gPiBpdCdzIGJvdW5kIGFnYWluLg0KPiA+ID4NCj4gPiA+IFNvIGluIHNob3J0 LCBJIGJlbGlldmUgdGhpcyBpcyB0aGUgY29ycmVjdCBiZWhhdmlvciB0byBhZG9wdC4NCj4gPg0K PiA+IEluIHRoaXMgY2FzZSwgSSBiZWxpZXZlIHRoZSBzeW5jaHJvbm91cyByZXF1ZXN0X21vZHVs ZSgiZGVsbC13bWktZGVzY3JpcHRvciIpDQo+ID4gd291bGQgcHJvdmlkZSB0aGUgZGVzaXJlZCBy ZXN1bHQuIFRoZSBleGl0IHN0YXR1cyBkb2Vzbid0IGV2ZW4gbmVlZCB0byBiZQ0KPiA+IGNoZWNr ZWQuIElmIHRoYXQgaXMgc3VjY2Vzc2Z1bCwgYW5kIHRoZSBpbnRlcmZhY2VfdmVyc2lvbiBzdGls bCByZXR1cm5zIGZhbHNlLA0KPiA+IHRoZW4gaXQgY2FuIGJlIGNvbnNpZGVyZWQgYW4gZXJyb3Ig YW5kIHdlIGNhbiBleGl0LiBJZiBpdCBmYWlscywgdGhlDQo+ID4gaW50ZXJmYWNlX3ZlcnNpb24g d2lsbCByZXR1cm4gZmFsc2UsIGFuZCBpdCBpcyBhbHNvIGFuIGVycm9yLg0KPiA+DQo+ID4gVGhp cyBjYW4gYmUgZWFzaWx5IGFkZGVkIGFzIGEgc2luZ2xlIHBhdGNoIG9uIHRvcCBvZiB0aGlzIHNl cmllczoNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BsYXRmb3JtL3g4Ni9kZWxsLXdt aS5jIGIvZHJpdmVycy9wbGF0Zm9ybS94ODYvZGVsbC13bWkuYw0KPiA+IGluZGV4IGRjZmE1ZGUu Ljk2NGNhNTQgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9wbGF0Zm9ybS94ODYvZGVsbC13bWku Yw0KPiA+ICsrKyBiL2RyaXZlcnMvcGxhdGZvcm0veDg2L2RlbGwtd21pLmMNCj4gPiBAQCAtNjY1 LDggKzY2NSw5IEBAIHN0YXRpYyBpbnQgZGVsbF93bWlfcHJvYmUoc3RydWN0IHdtaV9kZXZpY2Ug KndkZXYpDQo+ID4gIAkJcmV0dXJuIC1FTk9NRU07DQo+ID4gIAlkZXZfc2V0X2RydmRhdGEoJndk ZXYtPmRldiwgcHJpdik7DQo+ID4NCj4gPiArCXJlcXVlc3RfbW9kdWxlKCJkZWxsLXdtaS1kZXNj cmlwdG9yIik7DQo+ID4gIAlpZiAoIWRlbGxfd21pX2dldF9pbnRlcmZhY2VfdmVyc2lvbigmcHJp di0+aW50ZXJmYWNlX3ZlcnNpb24pKQ0KPiA+IC0JCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiA+ ICsJCXJldHVybiAtRU5PREVWOw0KPiA+DQo+ID4gIAlyZXR1cm4gZGVsbF93bWlfaW5wdXRfc2V0 dXAod2Rldik7DQo+ID4gIH0NCj4gPg0KPiA+IFBhbGksIEkgYmVsaWV2ZSB0aGlzIGFkZHJlc3Nl cyB5b3VyIGNvbmNlcm4/DQoNClRoaXMgcHJvcG9zZWQgYXBwcm9hY2ggd291bGQgYWN0dWFsbHkg aW50cm9kdWNlIGEgcHJvYmxlbSBvZiB3aGVuIGEgZGV2aWNlDQppcyB1bmJvdW5kIG9uIHRoZSBk ZWxsLXdtaS1kZXNjcmlwdG9yIHRoZW4geW91IGJpbmQgZGVsbC13bWkgbm93IGl0J3MNCnBvc3Np YmxlIHRvIGdldCBpbnRvIGEgc3RhdGUgb2YgcHJvYmUgcm91dGluZSBmYWlsZWQgb24gZGVsbC13 bWkgYW5kIGNhbid0IGJlDQpmaXhlZCB3aXRob3V0IHVuYmluZCBkZWxsLXdtaSwgYmluZCBkZWxs LXdtaS1kZXNjcmlwdG9yIGFuZCB0aGVuIHJlYmluZA0KZGVsbC13bWkuDQoNCldpdGggZGVmZXJy ZWQgcHJvYmluZyBzb2x1dGlvbiBJIGhhZCBpbiBwbGFjZSB0aGF0IGFib3ZlIHByb2JsZW0gY2Fu J3QgaGFwcGVuDQpiZWNhdXNlIHByb2Jpbmcgd291bGQganVzdCByZS1ydW4uDQoNCj4gDQo+IEkn bSBub3Qgc3VyZSB3aGF0IGhhcHBlbiBpZiBib3RoIGRyaXZlcnMgYXJlIHN0YXRpY2FsbHkgbGlu a2VkIGludG8NCj4gdm1saW51eiBhbmQgZGVsbC13bWkgcHJvYmUgbWV0aG9kIHdvdWxkIGJlIGNh bGxlZCBiZWZvcmUNCj4gZGVsbC13bWktZGVzY3JpcHRvciBtZXRob2QuDQoNClRoYXQncyB3aHkg dGhpcyBpcyBiZXR0ZXIgIHRvIGRvIHVzaW5nIGRlZmVycmVkIHByb2JpbmcgSSB0aGluayBzdGls bC4NCg0KPiANCj4gV2hhdCBpcyBkb2luZyByZXF1ZXN0X21vZHVsZSB3aGVuIHJlcXVlc3RlZCBt b2R1bGUgaXMgc3RhdGljYWxseSBsaW5rZWQNCj4gaW50byB2bWxpbnV6Pw0KPiANCg0KQXMgSSBj YW4gdGVsbCByZXF1ZXN0X21vZHVsZSBhY3R1YWxseSBjYWxscyBvdXQgdG8gdXNlcnNwYWNlIHRv IHJ1biBtb2Rwcm9iZQ0Kb24gdGhlIHJlcXVlc3RlZCBtb2R1bGUuDQoNCg0KU29tZXRoaW5nIHRo YXQgbWF5IGhlbHAgd2l0aCBQYWxpJ3MgY29uY2VybiBpcyB0byBpbiB0aGUgcHJvYmUgcm91dGlu ZSBmb3INCmRlbGwtd21pLWRlc2NyaXRwdG9yIHNldCBzb21ldGhpbmcgaW4gYSBnbG9iYWwgdmFy aWFibGUgZm9yIGFuIGVycm9yIGNvZGUgYW5kDQpoYXZlIGEgZnVuY3Rpb24gdG8gbG9vayB0aGF0 IHVwLiAgSW4gdGhlIGVycm9yIHNjZW5hcmlvIGZvciBhIG5vbiBtZW1vcnkNCmFsbG9jYXRpb24g ZXJyb3Igc2V0IHRoYXQgdmFsdWUuICBTb21ldGhpbmcgbGlrZSB0aGlzOg0KDQovKiB2YWxpZCA9 IDAgbWVhbnMgcHJvYmUgaGFzbid0IHJ1biwgdmFsaWQgPSAxIG1lYW5zIHN1Y2Nlc3NmdWwgcHJv YmUsIA0KICAqIHZhbGlkIDwgMCBtZWFucyBmYWlsZWQgcHJvYmUgZHVlIHRvIGJhZCBkZXZpY2UN CiAgKi8NCnN0YXRpYyBpbnQgZGVsbF93bWlfZGVzY3JpcHRvcl92YWxpZCh2b2lkKQ0Kew0KCWlu dCByZXQ7DQoNCgltdXRleF9sb2NrKCZsaXN0X211dGV4KTsNCglpZiAodmFsaWQgPT0gMCkNCgkJ cmV0ID0gLUVQUk9CRV9ERUZFUjsNCgllbHNlIGlmDQoJCXJldCA9IHZhbGlkOw0KCW11dGV4X3Vu bG9jaygmbGlzdF9tdXRleCkNCglyZXR1cm4gcmV0Ow0KfQ0KDQpUaGVuIGRlbGwtd21pIGFuZCBk ZWxsLXNtYmlvcy13bWkgY2FuIGNhbGwgdGhhdCBiZWZvcmUgZGVsbF93bWlfZ2V0X2ludGVyZmFj ZV92ZXJzaW9uLg0KDQpEb2VzIHRoYXQgc2F0aXNmeSBQYWxpJ3MgY29uY2Vybj8gIEkgbWF5IGZv bGxvdyB1cCB3aXRoIHRoaXMgcGFydGljdWxhciBpdGVtIGluIGEgbGF0ZXIgcGF0Y2gNCnNvIGFz IHRvIG5vdCBkZXJhaWwgY3VycmVudCBlZmZvcnRzIHVubGVzcyBEYXJyZW4gb3IgQW5keSB3b3Vs ZCBsaWtlIHRoaXMgc29ydGVkIEFTQVAgb3IgSQ0KZ2V0IHRocm91Z2ggdGVzdGluZyBpdCBxdWlj a2x5Lg0KDQo=