From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node() Date: Fri, 4 Oct 2019 10:15:20 +0100 Message-ID: References: <20191003210100.22250-1-chris@chris-wilson.co.uk> <20191003210100.22250-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191003210100.22250-5-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Ck9uIDAzLzEwLzIwMTkgMjI6MDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBIGZldyBjYWxsZXJz IG5lZWQgdG8gc2VyaWFsaXNlIHRoZSBkZXN0cnVjdGlvbiBvZiB0aGVpciBkcm1fbW1fbm9kZSBh bmQKPiBlbnN1cmUgaXQgaXMgcmVtb3ZlZCBmcm9tIHRoZSBkcm1fbW0gYmVmb3JlIGZyZWVpbmcu IEhvd2V2ZXIsIHRvIGJlCj4gY29tcGxldGVseSBzdXJlIHRoYXQgYW55IGFjY2VzcyBmcm9tIGFu b3RoZXIgdGhyZWFkIGlzIGNvbXBsZXRlIGJlZm9yZQo+IHdlIGZyZWUgdGhlIHN0cnVjdCwgd2Ug cmVxdWlyZSB0aGUgUkVMRUFTRSBzZW1hbnRpY3Mgb2YKPiBjbGVhcl9iaXRfdW5sb2NrKCkuCj4g Cj4gVGhpcyBhbGxvd3MgdGhlIGNvbmRpdGlvbmFsIGxvY2tpbmcgc3VjaCBhcwo+IAo+IFRocmVh ZCBBCQkJCVRocmVhZCBCCj4gICAgICBtdXRleF9sb2NrKG1tX2xvY2spOyAgICAgICAgICAgICAg ICBpZiAoZHJtX21tX25vZGVfYWxsb2NhdGVkKG5vZGUpKSB7Cj4gICAgICBkcm1fbW1fbm9kZV9y ZW1vdmUobm9kZSk7ICAgICAgICAgICAgICAgbXV0ZXhfbG9jayhtbV9sb2NrKTsKPiAgICAgIG11 dGV4X3VubG9jayhtbV9sb2NrKTsgICAgICAgICAgICAgICAgICBkcm1fbW1fbm9kZV9yZW1vdmUo bm9kZSk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXV0 ZXhfdW5sb2NrKG1tX2xvY2spOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIH0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZnJl ZShub2RlKTsKCk15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCByZWxlYXNlIHNlbWFudGljcyBvbiBu b2RlIGFsbG9jYXRlZCBtZWFuIDEgLT4gMCAKdHJhbnNpdGlvbiBpcyBndWFyYW50ZWVkIHRvIGJl IHNlZW4gb25seSB3aGVuIHRocmVhZCBBIApkcm1fbW1fbm9kZV9yZW1vdmUgaXMgZnVsbHkgZG9u ZSB3aXRoIHRoZSByZW1vdmFsLiBCdXQgaWYgaXQgaXMgaW4gdGhlIAptaWRkbGUgb2YgcmVtb3Zh bCwgbm9kZSBpcyBzdGlsbCBzZWVuIGFzIGFsbG9jYXRlZCBvdXRzaWRlIGFuZCB0aHJlYWQgQiAK Y2FuIGVudGVyIHRoZSBpZi1ib2R5LCB3YWl0IGZvciB0aGUgbG9jaywgYW5kIHRoZW4gZHJtX21t X25vZGVfcmVtb3ZlIAp3aWxsIGF0dGVtcHQgYSBkb3VibGUgcmVtb3ZhbC4gU28gSSB0aGluayBh bm90aGVyIGRybV9tbV9ub2RlX2FsbG9jYXRlZCAKdW5kZXIgdGhlIGxvY2sgaXMgbmVlZGVkLgoK QnV0IHRoZSBma3JlZSBwYXJ0IGxvb2tzIGNvcnJlY3QuIFRoZXJlIGNhbiBiZSBubyBmYWxzZSBu ZWdhdGl2ZXMgd2l0aCAKdGhlIHJlbGVhc2Ugc2VtYW50aWNzIG9uIHRoZSBhbGxvY2F0ZWQgYml0 LgoKUmVnYXJkcywKClR2cnRrbwoKPiB0byBzZXJpYWxpc2UgY29ycmVjdGx5IHdpdGhvdXQgYW55 IGxpbmdlcmluZyBhY2Nlc3NlcyBmcm9tIEEgdG8gdGhlCj4gZnJlZWQgbm9kZS4gQWxsb2NhdGlv biAvIGluc2VydGlvbiBvZiB0aGUgbm9kZSBpcyBhc3N1bWVkIG5ldmVyIHRvIHJhY2UKPiB3aXRo IHJlbW92YWwgb3IgZXZpY3Rpb24gc2Nhbm5pbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vZHJtX21tLmMgfCAxMSArKysrKystLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2RybV9tbS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9tbS5jCj4gaW5kZXggYTljYWI1ZTUzNzMx Li4yYTZlMzQ2NjMxNDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9tbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9tbS5jCj4gQEAgLTQyNCw5ICs0MjQsOSBAQCBpbnQg ZHJtX21tX3Jlc2VydmVfbm9kZShzdHJ1Y3QgZHJtX21tICptbSwgc3RydWN0IGRybV9tbV9ub2Rl ICpub2RlKQo+ICAgCj4gICAJbm9kZS0+bW0gPSBtbTsKPiAgIAo+ICsJX19zZXRfYml0KERSTV9N TV9OT0RFX0FMTE9DQVRFRF9CSVQsICZub2RlLT5mbGFncyk7Cj4gICAJbGlzdF9hZGQoJm5vZGUt Pm5vZGVfbGlzdCwgJmhvbGUtPm5vZGVfbGlzdCk7Cj4gICAJZHJtX21tX2ludGVydmFsX3RyZWVf YWRkX25vZGUoaG9sZSwgbm9kZSk7Cj4gLQlfX3NldF9iaXQoRFJNX01NX05PREVfQUxMT0NBVEVE X0JJVCwgJm5vZGUtPmZsYWdzKTsKPiAgIAlub2RlLT5ob2xlX3NpemUgPSAwOwo+ICAgCj4gICAJ cm1faG9sZShob2xlKTsKPiBAQCAtNTQzLDkgKzU0Myw5IEBAIGludCBkcm1fbW1faW5zZXJ0X25v ZGVfaW5fcmFuZ2Uoc3RydWN0IGRybV9tbSAqIGNvbnN0IG1tLAo+ICAgCQlub2RlLT5jb2xvciA9 IGNvbG9yOwo+ICAgCQlub2RlLT5ob2xlX3NpemUgPSAwOwo+ICAgCj4gKwkJX19zZXRfYml0KERS TV9NTV9OT0RFX0FMTE9DQVRFRF9CSVQsICZub2RlLT5mbGFncyk7Cj4gICAJCWxpc3RfYWRkKCZu b2RlLT5ub2RlX2xpc3QsICZob2xlLT5ub2RlX2xpc3QpOwo+ICAgCQlkcm1fbW1faW50ZXJ2YWxf dHJlZV9hZGRfbm9kZShob2xlLCBub2RlKTsKPiAtCQlfX3NldF9iaXQoRFJNX01NX05PREVfQUxM T0NBVEVEX0JJVCwgJm5vZGUtPmZsYWdzKTsKPiAgIAo+ICAgCQlybV9ob2xlKGhvbGUpOwo+ICAg CQlpZiAoYWRqX3N0YXJ0ID4gaG9sZV9zdGFydCkKPiBAQCAtNTg5LDExICs1ODksMTIgQEAgdm9p ZCBkcm1fbW1fcmVtb3ZlX25vZGUoc3RydWN0IGRybV9tbV9ub2RlICpub2RlKQo+ICAgCj4gICAJ ZHJtX21tX2ludGVydmFsX3RyZWVfcmVtb3ZlKG5vZGUsICZtbS0+aW50ZXJ2YWxfdHJlZSk7Cj4g ICAJbGlzdF9kZWwoJm5vZGUtPm5vZGVfbGlzdCk7Cj4gLQlfX2NsZWFyX2JpdChEUk1fTU1fTk9E RV9BTExPQ0FURURfQklULCAmbm9kZS0+ZmxhZ3MpOwo+ICAgCj4gICAJaWYgKGRybV9tbV9ob2xl X2ZvbGxvd3MocHJldl9ub2RlKSkKPiAgIAkJcm1faG9sZShwcmV2X25vZGUpOwo+ICAgCWFkZF9o b2xlKHByZXZfbm9kZSk7Cj4gKwo+ICsJY2xlYXJfYml0X3VubG9jayhEUk1fTU1fTk9ERV9BTExP Q0FURURfQklULCAmbm9kZS0+ZmxhZ3MpOwo+ICAgfQo+ICAgRVhQT1JUX1NZTUJPTChkcm1fbW1f cmVtb3ZlX25vZGUpOwo+ICAgCj4gQEAgLTYxNCw2ICs2MTUsNyBAQCB2b2lkIGRybV9tbV9yZXBs YWNlX25vZGUoc3RydWN0IGRybV9tbV9ub2RlICpvbGQsIHN0cnVjdCBkcm1fbW1fbm9kZSAqbmV3 KQo+ICAgCj4gICAJKm5ldyA9ICpvbGQ7Cj4gICAKPiArCV9fc2V0X2JpdChEUk1fTU1fTk9ERV9B TExPQ0FURURfQklULCAmbmV3LT5mbGFncyk7Cj4gICAJbGlzdF9yZXBsYWNlKCZvbGQtPm5vZGVf bGlzdCwgJm5ldy0+bm9kZV9saXN0KTsKPiAgIAlyYl9yZXBsYWNlX25vZGVfY2FjaGVkKCZvbGQt PnJiLCAmbmV3LT5yYiwgJm1tLT5pbnRlcnZhbF90cmVlKTsKPiAgIAo+IEBAIC02MjcsOCArNjI5 LDcgQEAgdm9pZCBkcm1fbW1fcmVwbGFjZV9ub2RlKHN0cnVjdCBkcm1fbW1fbm9kZSAqb2xkLCBz dHJ1Y3QgZHJtX21tX25vZGUgKm5ldykKPiAgIAkJCQkmbW0tPmhvbGVzX2FkZHIpOwo+ICAgCX0K PiAgIAo+IC0JX19jbGVhcl9iaXQoRFJNX01NX05PREVfQUxMT0NBVEVEX0JJVCwgJm9sZC0+Zmxh Z3MpOwo+IC0JX19zZXRfYml0KERSTV9NTV9OT0RFX0FMTE9DQVRFRF9CSVQsICZuZXctPmZsYWdz KTsKPiArCWNsZWFyX2JpdF91bmxvY2soRFJNX01NX05PREVfQUxMT0NBVEVEX0JJVCwgJm9sZC0+ ZmxhZ3MpOwo+ICAgfQo+ICAgRVhQT1JUX1NZTUJPTChkcm1fbW1fcmVwbGFjZV9ub2RlKTsKPiAg IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=