From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C346CC433FE for ; Wed, 12 Oct 2022 13:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbiJLNAh (ORCPT ); Wed, 12 Oct 2022 09:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiJLNAd (ORCPT ); Wed, 12 Oct 2022 09:00:33 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59DB67CB48 for ; Wed, 12 Oct 2022 06:00:31 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id j21so8144407qkk.9 for ; Wed, 12 Oct 2022 06:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S7I3Cz5+U5x6cIXGPA8p9f0gJdwGq7AR9Xznrk5pZ2M=; b=RUfyxSq7fmq5cjgnShru5p1DpyftvUBe1/f4hzQ1PmJ0Q+GHCzHTY5hwtO2C/v6jmA RdI0LdVobKGxBm018dRryOu+/vONbFYUGHH8VK+S6syziEp9u13ceqVcILGEWqE+gB8x pzGZhXVOU9KAEMQ0PqAWNxSgMj9x4I2IG1yHTDSYLgJINCC576qp8CQJMXENZBksoCbC mrSeZySI5K76K1GGVat8g9kSTpEcbayeMVJBZWij4QjvOV/JVIdDZdOkUx8wxGPyzCbO rq079Sc6EayGR5GZE87XrvXw+jkLbvXG2G/Rqr4s09/Mj/r9iWeNZuGTMsR0D2QNDdtT Ulzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7I3Cz5+U5x6cIXGPA8p9f0gJdwGq7AR9Xznrk5pZ2M=; b=HM2dJs9yiY5JjYRpS7k2HeuzvkSq91NFjlmukAsmErjijCd0T8mMRG/5R1lQt/RzF9 wsAw2w2CPmZzmsFvqMUoRcASUIup1E2Fsq7+khIRvI+55wB1zEl8SHJweBeY09thrAzU rhyHzdPi3qpMY5i5oalPYIRP7cM317sRQzYCixMhuGbHZtb/0dLQna5t6kNK32AWJ/eu K/4at4jfYPzkPtRqgtF8aJxC2gQkZL3BxFlTNUXXU0Fj7o7z4siU/xaW6WIX/BkQ1PVh nec5obdBHozIWwSgEdMOUWYkBlWKM2RiZZogEMAARuNfk2KcQq2/Sqq32e7N2oU64NXN iGGA== X-Gm-Message-State: ACrzQf3UfM73uIkt826yxuF2c4P2jCcHy8Bp5R7RHq6ab6zsPIYdTdSA i9YYgXBU4Ui7ts3umzQaYkMSzA== X-Google-Smtp-Source: AMsMyM4h65oRCdBS2LVLH3asi+Dz8Bht/2Ex4MGomFkxTgfupyoOTY1kejOISNYZo3eiUk2ujujm/g== X-Received: by 2002:a05:620a:280d:b0:6cf:ab57:a130 with SMTP id f13-20020a05620a280d00b006cfab57a130mr20372720qkp.749.1665579625333; Wed, 12 Oct 2022 06:00:25 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id s4-20020a05620a254400b006bbc09af9f5sm15488418qko.101.2022.10.12.06.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 06:00:24 -0700 (PDT) Message-ID: Date: Wed, 12 Oct 2022 09:00:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2022 04:39, jerome Neanne wrote: >> You explained what you did, which is easily visible. You did not explain >> why you are doing it. >> >> Best regards, >> Krzysztof >> > Thanks for pointing me to the detailed guidelines > I'm new to upstream and not well aware of all good practices. > > Would below commit message be more suitable: > > Add support for the TPS65219 PMIC by enabling MFD, regulator and > power-button drivers. All drivers enabled as modules. This still says only what you did. I still does not explain why. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62E66C4332F for ; Wed, 12 Oct 2022 13:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JHDsJh/TQayGrQF5T892JpF2R7MQqabuBhb2sFZuo+M=; b=07lotZfAcaXePW gcr/DyC7FTEHf5PHqCWFqfjL7XQfiLzexL0kFPuptepo0mQl0c8qqB3P5KUzpm0iduuJeT3yigfDy lIHmrQi8yjm35bqXmmi3Jz+7saJwWBSII3gDXaDao1JTRl1sNqPQoFPH/RprNASq040/8RKcnmNLC ysoykF4amOw9QuSyQMNOx86TQvC86zNJ26wL9hHwgleCxlUy+A0hbCVpzVRWqvcEMmBWyWwByd0is Xev8ojEjIoGvBrXYnnHHET8a5pyi+4H7Pc7FcmIYJjiIRTHNptVq1ttsZsu9LeAU/c7g+coqj/5ME 7SpCdlu0eit4FQfVtnSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oibLe-0083tp-RP; Wed, 12 Oct 2022 13:00:35 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oibLb-0083s0-Gc for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 13:00:33 +0000 Received: by mail-qk1-x72c.google.com with SMTP id o2so3151679qkk.10 for ; Wed, 12 Oct 2022 06:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S7I3Cz5+U5x6cIXGPA8p9f0gJdwGq7AR9Xznrk5pZ2M=; b=RUfyxSq7fmq5cjgnShru5p1DpyftvUBe1/f4hzQ1PmJ0Q+GHCzHTY5hwtO2C/v6jmA RdI0LdVobKGxBm018dRryOu+/vONbFYUGHH8VK+S6syziEp9u13ceqVcILGEWqE+gB8x pzGZhXVOU9KAEMQ0PqAWNxSgMj9x4I2IG1yHTDSYLgJINCC576qp8CQJMXENZBksoCbC mrSeZySI5K76K1GGVat8g9kSTpEcbayeMVJBZWij4QjvOV/JVIdDZdOkUx8wxGPyzCbO rq079Sc6EayGR5GZE87XrvXw+jkLbvXG2G/Rqr4s09/Mj/r9iWeNZuGTMsR0D2QNDdtT Ulzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7I3Cz5+U5x6cIXGPA8p9f0gJdwGq7AR9Xznrk5pZ2M=; b=w3vsZmEn9Z4RXqbs4tF6SKnvJlfUsDotNXQqdhy5hIWbf38hRPsMDwZhJeen5mlujx WU1kC9Jk788p8tvU9shvYVGsWzl3aL8ZKhf5B0atmKe3tfw3IJx7DJil7+XVaeuMK525 JdvM+m2sMmcRuPPV16LVDBdUHXvSSdDtFR7UGIvltGQ9PbBfQFfeIOlV6Ys7RsmKswl2 2Xi3D4HDTHlPNEsElgzs282vJf0TBoOU9ghxV0OA221dyoa1wS9sqZ8Uz3p/IwJLIuwv xfilDx9em+KHYEJj49VcPwiFbW56YkvvCZo6FCT13Se9IIzeL9hMzxgUQ07f3HDhCjzL OlNg== X-Gm-Message-State: ACrzQf1XqqqBgaiwf8uQ4pQt/thpwJ25Cygrk+5xbLyP9bFVELz3DIDE BO8lnJl0NnNORFaTsFElFNdxDA== X-Google-Smtp-Source: AMsMyM4h65oRCdBS2LVLH3asi+Dz8Bht/2Ex4MGomFkxTgfupyoOTY1kejOISNYZo3eiUk2ujujm/g== X-Received: by 2002:a05:620a:280d:b0:6cf:ab57:a130 with SMTP id f13-20020a05620a280d00b006cfab57a130mr20372720qkp.749.1665579625333; Wed, 12 Oct 2022 06:00:25 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id s4-20020a05620a254400b006bbc09af9f5sm15488418qko.101.2022.10.12.06.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 06:00:24 -0700 (PDT) Message-ID: Date: Wed, 12 Oct 2022 09:00:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_060031_580936_C8475904 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/10/2022 04:39, jerome Neanne wrote: >> You explained what you did, which is easily visible. You did not explain >> why you are doing it. >> >> Best regards, >> Krzysztof >> > Thanks for pointing me to the detailed guidelines > I'm new to upstream and not well aware of all good practices. > > Would below commit message be more suitable: > > Add support for the TPS65219 PMIC by enabling MFD, regulator and > power-button drivers. All drivers enabled as modules. This still says only what you did. I still does not explain why. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel