From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA36FC7EE2F for ; Fri, 3 Mar 2023 08:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjCCIUl (ORCPT ); Fri, 3 Mar 2023 03:20:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbjCCIUj (ORCPT ); Fri, 3 Mar 2023 03:20:39 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A18831517B for ; Fri, 3 Mar 2023 00:20:13 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id da10so7202170edb.3 for ; Fri, 03 Mar 2023 00:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677831612; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IaQd5sInzBzFtTjrz9shXsqEyVwEzcyl/SxF1kXcy/U=; b=jp+cz8zbDShbL93MYv7FkPN3LI1luwnZQpMMD2QLd82GwMERpC0Rk1kQM1bVGuEqZO RWWupiCof7O8v2j/FUhDWJM/kzOR2J2/64Lv2eJmzn6NHVfMa/6jQTl0xlygFujhCIzm 31TRuXUrh7hVI54bX2T+y2CLu+OQYVNyGvDLyyBs/8HpYOkzCVvRqEkcLlzcVnZjUkab qMPzCeBD0HpiKAefyCNnVO2PzUNYWnEaqR9jIIaAqC2JZb9tGxNx/CC7in5TTIth66OR /nv5nyzLL3bgR08T19Y6v7VDDEm4sVrzH140NXM8N6cmcwFbDVj0mM52HHrK/OFaxXZk nE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677831612; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IaQd5sInzBzFtTjrz9shXsqEyVwEzcyl/SxF1kXcy/U=; b=SKFnitIxL6n2tmn3D4qH0guECMfALs2rUCY6YB5G03TqohhagFEMiXpMNBxjjUB46y ydG8Y8RK+3kNamfzQJOmNKEAYNiryBOrFaXkWXf7JG/lw5P8Sge5s+lD4SPRoMGjTvR9 iqlow6NvGEAvR2nOrY2f4b06+R5ffqCZHC1v5RTXnyq3WTAoRsW0t8PPnu35qZuMsPvj HzW33iu4n6wWHHZmDH20loazwcGgzu5zNfj18cxd+OTrQCLadBeTO56y4RPxjtqvwlpa ZYYLBa+hdIm+L27afQnadPaWV/YMvNXCDgp6exVUHL87E1LO0KydDoGMm1tvJVNgrLLM wA1g== X-Gm-Message-State: AO0yUKWpdmfMpZ/Et4nhMQA81EbkUmAN2haz1smLgL5pRhqXRvzfTbTD EzMN7hGIozojvBBzYJAKZrmBBmYbb/XXBb11 X-Google-Smtp-Source: AK7set/JbtmNuxtTAhEQHihlNhtpUsx5t+fmEJHmeNUg47DKWeHZnMmKDVf4W9mHzL2WeurnjL5C4g== X-Received: by 2002:aa7:d404:0:b0:4aa:ca81:a528 with SMTP id z4-20020aa7d404000000b004aaca81a528mr1039879edq.40.1677831612104; Fri, 03 Mar 2023 00:20:12 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id q9-20020a170906678900b008d68d018153sm687016ejp.23.2023.03.03.00.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 00:20:11 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 09:20:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Content-Language: en-US To: Ryan Chen , Wolfram Sang References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> <53090449-58c9-bc03-56df-aa8ae93c0c26@linaro.org> From: Krzysztof Kozlowski Cc: Joel Stanley , Brendan Higgins , Krzysztof Kozlowski , Andrew Jeffery , "devicetree@vger.kernel.org" , Philipp Zabel , Rob Herring , Benjamin Herrenschmidt , "linux-aspeed@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-i2c@vger.kernel.org" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/2023 06:57, Ryan Chen wrote: > Hello Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, February 27, 2023 4:25 PM >> To: Ryan Chen ; Andrew Jeffery >> ; Brendan Higgins ; Benjamin >> Herrenschmidt ; Joel Stanley ; >> Rob Herring ; Krzysztof Kozlowski >> ; Philipp Zabel ; >> linux-i2c@vger.kernel.org; openbmc@lists.ozlabs.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 >> >> On 26/02/2023 04:13, Ryan Chen wrote: >>> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout >>> aspeed,xfer-mode description for ast2600-i2cv2. >>> >>> Signed-off-by: Ryan Chen >>> --- >>> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> index f597f73ccd87..75de3ce41cf5 100644 >>> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> @@ -49,6 +49,25 @@ properties: >>> description: >>> states that there is another master active on this bus >>> >>> + aspeed,timeout: >>> + type: boolean >>> + description: I2C bus timeout enable for master/slave mode >> >> Nothing improved here in regards to my last comment. > > Yes, as I know your require is about " DT binding to represent hardware setup" > So I add more description about aspeed,timeout as blow. > > ASPEED SOC chip is server product, i2c bus may have fingerprint connect to another board. And also support hotplug. > The following is board-specific design example. > Board A Board B > ------------------------- ------------------------ > |i2c bus#1(master/slave) <===fingerprint ===> i2c bus#x (master/slave)| > |i2c bus#2(master)-> tmp i2c device | | | > |i2c bus#3(master)-> adc i2c device | | | > ------------------------- ------------------------ > > aspeed,timout properites: > For example I2C controller as slave mode, and suddenly disconnected. > Slave state machine will keep waiting for master clock in for rx/tx transmit. > So it need timeout setting to enable timeout unlock controller state. > And in another side. In Master side also need avoid suddenly slave miss(un-plug), Master will timeout and release the SDA/SCL. > > Do you mean add those description into ore aspeed,timout properites description? You are describing here one particular feature you want to enable in the driver which looks non-scalable and more difficult to configure/use. What I was looking for is to describe the actual configuration you have (e.g. multi-master) which leads to enable or disable such feature in your hardware. Especially that bool value does not scale later to actual timeout values in time (ms)... I don't know I2C that much, but I wonder - why this should be specific to Aspeed I2C and no other I2C controllers implement it? IOW, this looks quite generic and every I2C controller should have it. Adding it specific to Aspeed suggests that either we miss a generic property or this should not be in DT at all (because no one else has it...). Also I wonder, why you wouldn't enable timeout always... +Cc Wolfram, Maybe you know whether bool "timeout" property for one controller makes sense? Why we do not have it for all controllers? > >> >>> + >>> + aspeed,xfer-mode: >>> + description: | >>> + I2C bus transfer mode selection. >>> + - "byte": I2C bus byte transfer mode. >>> + - "buffered": I2C bus buffer register transfer mode. >>> + - "dma": I2C bus dma transfer mode (default) >>> + items: >>> + enum: [byte, buffered, dma] >>> + maxItems: 1 >> >> Drop, not an array. >> >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >> >> Wrong ref. This is not an array, but one string. > > Sorry, I can't catch your "one string" point. How many strings you are going to have in this property? If one (maxItems: 1), then this is not an array. > Could you point me what ref I can refer to? > That I can check into Linux example. Thanks a lot. >> >>> + >>> + aspeed,global-regs: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: The phandle of i2c global register node. >>> + >>> required: >>> - reg >>> - compatible >>> @@ -57,6 +76,19 @@ required: >>> >>> unevaluatedProperties: false >>> >>> +if: >> >> This should be under allOf (in this location) >> >>> + properties: >>> + compatible: >>> + contains: >>> + const: aspeed,ast2600-i2cv2 >>> + >>> +then: >>> + properties: >>> + reg: >>> + minItems: 2 >>> + required: >>> + - aspeed,global-regs >> >> else: >> aspeed,global-regs: false >> and the same for other v2 properties >> > > Does modify by following? > > allOf: > -if: > properties: > compatible: > contains: > const: aspeed,ast2600-i2cv2 > > then: > properties: > reg: > minItems: 2 > required: > - aspeed,global-regs > else: > - aspeed,global-regs: false > -aspeed,timeout: false > - aspeed,xfer-mode: false yes Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2F21C64EC4 for ; Fri, 3 Mar 2023 08:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Cc:From:References:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IPcknUdciVQPRR5UyyN/y2+QOHse07akotfoAzUckEM=; b=Qj8xz5VKEX2gaW O5DfKDuNC4/i526mYcH3rZhLRGjj9Udal1a29X9ASMSj4rf7N+LIgcwXDioFTrnqHbdMLqujUxsCl N9pSUJSqkasoe72NUqjL0bdI0mRMKC1+kCilsbkbSdzcow2aQeSk1LXQa0gO7Hx/TiZfHmjffU8qL rw5A+njnOwuY6cDyS0OtKQJPRMNGmiecSIOOKTiSsJ9l60KsD9iFDmkoo48pXaqLDm50mge5AOjNM eHz/MbI9p/HQaubQ+1u+bsVWTeF4TQ+ptFhgBCyIxdXsO4FbWUpRanm4CvBdo05IrpzIQuFHj+kLu vN6Jw9TlScQBoqObKm8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY0eL-005MVv-K1; Fri, 03 Mar 2023 08:20:21 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY0eF-005MUK-FA for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 08:20:19 +0000 Received: by mail-ed1-x533.google.com with SMTP id s11so7086760edy.8 for ; Fri, 03 Mar 2023 00:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677831612; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IaQd5sInzBzFtTjrz9shXsqEyVwEzcyl/SxF1kXcy/U=; b=jp+cz8zbDShbL93MYv7FkPN3LI1luwnZQpMMD2QLd82GwMERpC0Rk1kQM1bVGuEqZO RWWupiCof7O8v2j/FUhDWJM/kzOR2J2/64Lv2eJmzn6NHVfMa/6jQTl0xlygFujhCIzm 31TRuXUrh7hVI54bX2T+y2CLu+OQYVNyGvDLyyBs/8HpYOkzCVvRqEkcLlzcVnZjUkab qMPzCeBD0HpiKAefyCNnVO2PzUNYWnEaqR9jIIaAqC2JZb9tGxNx/CC7in5TTIth66OR /nv5nyzLL3bgR08T19Y6v7VDDEm4sVrzH140NXM8N6cmcwFbDVj0mM52HHrK/OFaxXZk nE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677831612; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IaQd5sInzBzFtTjrz9shXsqEyVwEzcyl/SxF1kXcy/U=; b=YsaPqwA/QqKr1H36e8vnbkFnbLuXnFxjMSR8G6cQGUmWhacm8rE8yOe8l6khufQxt1 OCvLzHTnIYHIpi+oIkM/YpT8QFjFbVbYWu4JEnA3p17/Vx0nzr4xaK5yyzBzNSOvdnNA /sc6gcZwFkNLTj4JAuZpGOw9iNMTRrqI5DbZNS/9vabH7Qv2zb8j57BYwB+DFN4aOppT cv4OWqlR2zSMl/q/VVwy8TcsKjQmy0bnBcVwXpevQ7PHP14/Ysrj/pS27xNRzGqf0IhI Rp553QCNx2RJz5hPZEzUmaxvHUz8KzhfV5hd6nmsrbJp90mJ2PehFpn8sx17txTsT4Pm G1wQ== X-Gm-Message-State: AO0yUKWiACvRaz0faUqzQfd0iWUlb0A89xF0qhHL8fqksOZATDJHIW+i 9BZrsgQCEtd7PntzgBjBU3NZ4A== X-Google-Smtp-Source: AK7set/JbtmNuxtTAhEQHihlNhtpUsx5t+fmEJHmeNUg47DKWeHZnMmKDVf4W9mHzL2WeurnjL5C4g== X-Received: by 2002:aa7:d404:0:b0:4aa:ca81:a528 with SMTP id z4-20020aa7d404000000b004aaca81a528mr1039879edq.40.1677831612104; Fri, 03 Mar 2023 00:20:12 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id q9-20020a170906678900b008d68d018153sm687016ejp.23.2023.03.03.00.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 00:20:11 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 09:20:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Content-Language: en-US To: Ryan Chen , Wolfram Sang References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> <53090449-58c9-bc03-56df-aa8ae93c0c26@linaro.org> From: Krzysztof Kozlowski Cc: Joel Stanley , Brendan Higgins , Krzysztof Kozlowski , Andrew Jeffery , "devicetree@vger.kernel.org" , Philipp Zabel , Rob Herring , Benjamin Herrenschmidt , "linux-aspeed@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-i2c@vger.kernel.org" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_002015_571705_8B30F223 X-CRM114-Status: GOOD ( 28.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2023 06:57, Ryan Chen wrote: > Hello Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, February 27, 2023 4:25 PM >> To: Ryan Chen ; Andrew Jeffery >> ; Brendan Higgins ; Benjamin >> Herrenschmidt ; Joel Stanley ; >> Rob Herring ; Krzysztof Kozlowski >> ; Philipp Zabel ; >> linux-i2c@vger.kernel.org; openbmc@lists.ozlabs.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 >> >> On 26/02/2023 04:13, Ryan Chen wrote: >>> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout >>> aspeed,xfer-mode description for ast2600-i2cv2. >>> >>> Signed-off-by: Ryan Chen >>> --- >>> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> index f597f73ccd87..75de3ce41cf5 100644 >>> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml >>> @@ -49,6 +49,25 @@ properties: >>> description: >>> states that there is another master active on this bus >>> >>> + aspeed,timeout: >>> + type: boolean >>> + description: I2C bus timeout enable for master/slave mode >> >> Nothing improved here in regards to my last comment. > > Yes, as I know your require is about " DT binding to represent hardware setup" > So I add more description about aspeed,timeout as blow. > > ASPEED SOC chip is server product, i2c bus may have fingerprint connect to another board. And also support hotplug. > The following is board-specific design example. > Board A Board B > ------------------------- ------------------------ > |i2c bus#1(master/slave) <===fingerprint ===> i2c bus#x (master/slave)| > |i2c bus#2(master)-> tmp i2c device | | | > |i2c bus#3(master)-> adc i2c device | | | > ------------------------- ------------------------ > > aspeed,timout properites: > For example I2C controller as slave mode, and suddenly disconnected. > Slave state machine will keep waiting for master clock in for rx/tx transmit. > So it need timeout setting to enable timeout unlock controller state. > And in another side. In Master side also need avoid suddenly slave miss(un-plug), Master will timeout and release the SDA/SCL. > > Do you mean add those description into ore aspeed,timout properites description? You are describing here one particular feature you want to enable in the driver which looks non-scalable and more difficult to configure/use. What I was looking for is to describe the actual configuration you have (e.g. multi-master) which leads to enable or disable such feature in your hardware. Especially that bool value does not scale later to actual timeout values in time (ms)... I don't know I2C that much, but I wonder - why this should be specific to Aspeed I2C and no other I2C controllers implement it? IOW, this looks quite generic and every I2C controller should have it. Adding it specific to Aspeed suggests that either we miss a generic property or this should not be in DT at all (because no one else has it...). Also I wonder, why you wouldn't enable timeout always... +Cc Wolfram, Maybe you know whether bool "timeout" property for one controller makes sense? Why we do not have it for all controllers? > >> >>> + >>> + aspeed,xfer-mode: >>> + description: | >>> + I2C bus transfer mode selection. >>> + - "byte": I2C bus byte transfer mode. >>> + - "buffered": I2C bus buffer register transfer mode. >>> + - "dma": I2C bus dma transfer mode (default) >>> + items: >>> + enum: [byte, buffered, dma] >>> + maxItems: 1 >> >> Drop, not an array. >> >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >> >> Wrong ref. This is not an array, but one string. > > Sorry, I can't catch your "one string" point. How many strings you are going to have in this property? If one (maxItems: 1), then this is not an array. > Could you point me what ref I can refer to? > That I can check into Linux example. Thanks a lot. >> >>> + >>> + aspeed,global-regs: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: The phandle of i2c global register node. >>> + >>> required: >>> - reg >>> - compatible >>> @@ -57,6 +76,19 @@ required: >>> >>> unevaluatedProperties: false >>> >>> +if: >> >> This should be under allOf (in this location) >> >>> + properties: >>> + compatible: >>> + contains: >>> + const: aspeed,ast2600-i2cv2 >>> + >>> +then: >>> + properties: >>> + reg: >>> + minItems: 2 >>> + required: >>> + - aspeed,global-regs >> >> else: >> aspeed,global-regs: false >> and the same for other v2 properties >> > > Does modify by following? > > allOf: > -if: > properties: > compatible: > contains: > const: aspeed,ast2600-i2cv2 > > then: > properties: > reg: > minItems: 2 > required: > - aspeed,global-regs > else: > - aspeed,global-regs: false > -aspeed,timeout: false > - aspeed,xfer-mode: false yes Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel