Hi Andrew,

On 6/18/21 11:16 AM, Andrew Zaborowski wrote:
> On Fri, 18 Jun 2021 at 17:05, Denis Kenzior <denkenz@gmail.com> wrote:
>> On 6/18/21 2:33 AM, Andrew Zaborowski wrote:
>>> For consistency call periodic_scan_stop() right after netdev signals
>>> connected even if station stays in the CONNECTING state because it's
>>> waiting for netconfig to finish.
>>
>> Hmm, why is this needed?  We should be calling periodic_scan_stop as soon as we
>> transition to CONNECTING/CONNECTING_AUTO state.
> 
> That's another option but I think the logic until now was that if the
> connection failed we'd just return to periodic scanning without ever
> stopping and restarting it.  During the netdev CMD_CONNECT it would be

I don't think so.  See commit c3e160880f32f and commit da485179a6e92 prior to 
that.  It looks like we have stopped periodic scan when entering CONNECTING 
state for quite some time.

> inhibited by the kernel or by the radio work.  We only needed to
> explicitly stop the scanning when CMD_CONNECT succeeded, so that's
> what I was trying to restore in this patch, otherwise if we were
> unlucky we might have been scanning during the netconfig.

Fair enough, but it doesn't look like your patch does that since we stop the 
periodic scan when we reach CONNECTING state today.

Regards,
-Denis