From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 274DEC6FD1D for ; Tue, 21 Mar 2023 17:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjCURd1 (ORCPT ); Tue, 21 Mar 2023 13:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbjCURd1 (ORCPT ); Tue, 21 Mar 2023 13:33:27 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88647532AA for ; Tue, 21 Mar 2023 10:33:21 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id y4so62830582edo.2 for ; Tue, 21 Mar 2023 10:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679420000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ochp5U/z+JPJ/YorY5MT0cSwY1Sw+z1CDqsaJ+qW2jU=; b=xeo1rt1i/Xy2YmniokvFRCzHeMIAub0jrdV+Ou2OsopQ7Sx0W9xBotcgFRZ4VnBH/G 2JAJBkYP1rpDPBNIErbDLhNLdX56BwjhubSL+Zdjsr+Kgo7psncK5VmkbNEOjMxlcONp ewZ+1KlwinjdvLlWoMn+2Gpp63T0xvWjjGGMT6DiHIuKdUJOaPBj1Xc41DEeaM++/QmL Z3fir6JozYswMIGIAnts48g2SQHx9wJLSnF39oI5FUx+5WvabIjNHH4KXqgBfquLCS7x OFq2zt2zYVIrWqNF3F05qma6e7v/HIvd2Wf9SNVzUPCJY1XsXnMs0bmUQ0OBaGQLKpdL ItFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679420000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ochp5U/z+JPJ/YorY5MT0cSwY1Sw+z1CDqsaJ+qW2jU=; b=RP01jZOjvEjfbBue0ZApM1fEYYLyhuFv8IiQhyseIHr3dCRVDvJO6nlkxBJutg9w5s ufJ1HrWrQ175D2TZKOpGkNxUh6tAcA29AT9g/OJUMx9b0EkJfg4vC/b+nwxPu/QhvZsx XwKTPG+TOg/N3E/TYDkqCyw/xMcvzcC+P1VxpF1jnTmgSbN9N7jf027C2wIxqmqH2MaF MX90/M+IaXXCpU7vkCnoVbDEIVitM64+b4To6dZ8x1DRLPP88k9dh9kpd32flqNqaAxF 75CmO2Fae1Im4MIrIUv4AQSss5bBNXSLl2t8I3Mz1Fl39+u4AwvgudxHRXXWUIJJQAY9 zeBQ== X-Gm-Message-State: AO0yUKUZrdNCtjP/y8n2yNWrKP92DDY4VPJ7vqDGSLSBGE6nNXmtF0c+ zwlHdVpWuLxKzbXuQ3C6ZRvh1w== X-Google-Smtp-Source: AK7set/v/ZVk5N7EL089HA1rFs0IQ+7797TjgYvJfWP5FuppUeBwgImPuQRLLhQvRVpAJCuZMYTb1A== X-Received: by 2002:a17:906:4a0d:b0:88f:a236:69e6 with SMTP id w13-20020a1709064a0d00b0088fa23669e6mr3428975eju.7.1679420000035; Tue, 21 Mar 2023 10:33:20 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:2142:d8da:5ae4:d817? ([2a02:810d:15c0:828:2142:d8da:5ae4:d817]) by smtp.gmail.com with ESMTPSA id o7-20020a1709062e8700b00933356c681esm4552255eji.150.2023.03.21.10.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 10:33:19 -0700 (PDT) Message-ID: Date: Tue, 21 Mar 2023 18:33:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/03/2023 14:51, Souradeep Chowdhury wrote: > Add the device tree bindings for the module power manager sleep > counter. > > Signed-off-by: Souradeep Chowdhury > --- > .../bindings/soc/qcom/qcom,mpm-sleep-counter.yaml | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > new file mode 100644 > index 0000000..f9f46b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/qcom,mpm-sleep-counter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MPM Sleep Counter > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + MPM(Module Power Manager) has a sleep counter which is used to track Missing space: MPM (Module > + various stages of the boot process in Qualcomm. in Qualcomm SoC. Because you do not track it in the company... > + > +properties: > + compatible: > + items: Drop items. > + - const: qcom,mpm2-sleep-counter SoC specific compatible. > + > + reg: > + items: > + - description: MPM Sleep Counter Base just maxItems: 1 > + > + clock-frequency: > + description: Frequency for the sleep counter Since this does not have clocks, what frequency you are setting here? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + mpm2-sleep-counter@c221000{ Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "qcom,mpm2-sleep-counter"; > + reg = <0xc221000 0x1000>; > + clock-frequency = <32768>; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ADB9C761A6 for ; Tue, 21 Mar 2023 17:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JRRRF8fO5iEbzYjZjOORlvP79l3X/pZjelyN6emVaUw=; b=nSsSlddoqF2QD0 zzCocsdlHRLO7xaiJ3DY0ryanu+sDYuKJ05j6ePvDCcLl3vayxjxTaCbP4LY09c0Vyh68Zu+3c50K vc7wV56eojY+B8OdvuB/lEb5g1dyqBjML3HXW07ShyByB67vMRWIQHFdM+8uTetfV8fIshYHxivTs 18rGmL+f7X6R/1L2USrfSHpPfkJ3LX7sDuI3CF2i2TonT3NejgavgKqBcbGmS7eOgBp725jSY2MUl s+cT6svNRWeoecTQD3jWF2frUPdOEjWVq95gnAaghP2s4WAWSLD6JZz1jKHjBWxrQrzUvi+5rgJmy qqNMD0dqofDQbQkVRrNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pefrU-00DEis-2v; Tue, 21 Mar 2023 17:33:28 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pefrN-00DEhB-1f for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 17:33:27 +0000 Received: by mail-ed1-x52c.google.com with SMTP id ek18so62771316edb.6 for ; Tue, 21 Mar 2023 10:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679420000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ochp5U/z+JPJ/YorY5MT0cSwY1Sw+z1CDqsaJ+qW2jU=; b=xeo1rt1i/Xy2YmniokvFRCzHeMIAub0jrdV+Ou2OsopQ7Sx0W9xBotcgFRZ4VnBH/G 2JAJBkYP1rpDPBNIErbDLhNLdX56BwjhubSL+Zdjsr+Kgo7psncK5VmkbNEOjMxlcONp ewZ+1KlwinjdvLlWoMn+2Gpp63T0xvWjjGGMT6DiHIuKdUJOaPBj1Xc41DEeaM++/QmL Z3fir6JozYswMIGIAnts48g2SQHx9wJLSnF39oI5FUx+5WvabIjNHH4KXqgBfquLCS7x OFq2zt2zYVIrWqNF3F05qma6e7v/HIvd2Wf9SNVzUPCJY1XsXnMs0bmUQ0OBaGQLKpdL ItFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679420000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ochp5U/z+JPJ/YorY5MT0cSwY1Sw+z1CDqsaJ+qW2jU=; b=R7kj2a6RatRsiscWlRWBg1+Ko14xzXx5QAz/gaZRgDjsTVkPvK1k9d9DZYxgUs4ChV hbNndSpYonhxHaB7YatAufY9OesMoMPmzeFTdTRHo4RINgefLcNZjM12evwGx0neg1cy t78VvlXSirrqVsfKaa8wJpO3BmDGfGLBpkmLucU5ba2Y9OUt0N4s4R7pc7D8b0RAqcIP ibIY18oWtbLRezJXSt/pecUPdMGl1bkdVTKSy6yZPl+HH8u3+T+iXVLoNnRo6uL/R0qa uERIOAs/mzpoucAJA0A/PTRwy/2i3gDO7Jfw3VuG/Nfej9oEceBt/tlWq1w7UKQxA3Ao PemA== X-Gm-Message-State: AO0yUKUVkFcxk8XfdTNHDjJ/j4CoUgPZA2DHLBxtOZuJASBzuSrpJE1Z 0gf11y9MrkftcxgEyyyeFVB91w== X-Google-Smtp-Source: AK7set/v/ZVk5N7EL089HA1rFs0IQ+7797TjgYvJfWP5FuppUeBwgImPuQRLLhQvRVpAJCuZMYTb1A== X-Received: by 2002:a17:906:4a0d:b0:88f:a236:69e6 with SMTP id w13-20020a1709064a0d00b0088fa23669e6mr3428975eju.7.1679420000035; Tue, 21 Mar 2023 10:33:20 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:2142:d8da:5ae4:d817? ([2a02:810d:15c0:828:2142:d8da:5ae4:d817]) by smtp.gmail.com with ESMTPSA id o7-20020a1709062e8700b00933356c681esm4552255eji.150.2023.03.21.10.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 10:33:19 -0700 (PDT) Message-ID: Date: Tue, 21 Mar 2023 18:33:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_103322_475326_D807DEE8 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/03/2023 14:51, Souradeep Chowdhury wrote: > Add the device tree bindings for the module power manager sleep > counter. > > Signed-off-by: Souradeep Chowdhury > --- > .../bindings/soc/qcom/qcom,mpm-sleep-counter.yaml | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > new file mode 100644 > index 0000000..f9f46b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/qcom,mpm-sleep-counter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MPM Sleep Counter > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + MPM(Module Power Manager) has a sleep counter which is used to track Missing space: MPM (Module > + various stages of the boot process in Qualcomm. in Qualcomm SoC. Because you do not track it in the company... > + > +properties: > + compatible: > + items: Drop items. > + - const: qcom,mpm2-sleep-counter SoC specific compatible. > + > + reg: > + items: > + - description: MPM Sleep Counter Base just maxItems: 1 > + > + clock-frequency: > + description: Frequency for the sleep counter Since this does not have clocks, what frequency you are setting here? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + mpm2-sleep-counter@c221000{ Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "qcom,mpm2-sleep-counter"; > + reg = <0xc221000 0x1000>; > + clock-frequency = <32768>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel