From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx mailing list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 14/15] drm/amd/display: Enable warnings as errors
Date: Wed, 1 Mar 2017 10:04:01 -0500 [thread overview]
Message-ID: <fc47ed03-3eab-8983-33ee-fb0a33fed98a@amd.com> (raw)
In-Reply-To: <CACvgo52iOcL5S3=93NEafvoD9yCsvVtryGwKTmVoxwFYZfe1eQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2017-02-28 08:20 PM, Emil Velikov wrote:
> Hi Harry,
>
> On 1 March 2017 at 00:26, Harry Wentland <harry.wentland@amd.com> wrote:
>> Change-Id: I48d38e4d0224c9f0e52055b3c4ddef8e872b3dac
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> Acked-by: Harry Wentland <Harry.Wentland@amd.com>
>> Reviewed-by: Jordan Lazare <Jordan.Lazare@amd.com>
>> Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
>> ---
>> drivers/gpu/drm/amd/display/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
>> index 8ba37dd9cf7f..c22475b55586 100644
>> --- a/drivers/gpu/drm/amd/display/Makefile
>> +++ b/drivers/gpu/drm/amd/display/Makefile
>> @@ -5,6 +5,8 @@
>>
>> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>>
>> +subdir-ccflags-y += -Werror
>> +
> Many kernel modules have tried this in the past and had to quickly
> revert it. There's far too many compiler/toolchain combinations for
> this to always be true.
>
> By adding this you'll be adding serious annoyance to users and extra
> burden on Alex.
>
> -Emil
>
Point taken. I probably shouldn't have sent this one. This is something
we're doing in our internal trees to make sure we catch warnings at
pre-submission stage. Please ignore warnings too frequently and I'm
getting tired of fixing all of them.
Would be nice if there was some consistency to gcc's warnings, but
that's not something I see happening ever.
Harry
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-03-01 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 0:26 [PATCH 00/15] DC Patches Feb 28, 2017 Harry Wentland
[not found] ` <20170301002620.24595-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-03-01 0:26 ` [PATCH 01/15] drm/amd/display: rename bandwidth_calcs.c to dce_calcs.c Harry Wentland
2017-03-01 0:26 ` [PATCH 02/15] drm/amd/display: HDMI deep color mode audio issue Harry Wentland
2017-03-01 0:26 ` [PATCH 03/15] drm/amd/display: 420 clock divided by 2 twice Harry Wentland
2017-03-01 0:26 ` [PATCH 04/15] drm/amd/display: DMCU PSR Refactor Harry Wentland
2017-03-01 0:26 ` [PATCH 05/15] drm/amd/display: Fix gamma colour corruption for 10 bit surfaces Harry Wentland
[not found] ` <20170301002620.24595-6-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-03-01 1:17 ` Michel Dänzer
[not found] ` <440e5b55-ec15-a939-1626-f546208e37df-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-03-01 15:01 ` Harry Wentland
[not found] ` <5b7a6fe3-9ef1-145d-dc09-e238b68be3fc-5C7GfCeVMHo@public.gmane.org>
2017-03-01 15:53 ` Harry Wentland
2017-03-01 0:26 ` [PATCH 06/15] drm/amd/display: add scaler coefficients for 64 phase 5-8 taps Harry Wentland
2017-03-01 0:26 ` [PATCH 07/15] drm/amd/display: Surface Validation Fixes + Audio Mask Harry Wentland
2017-03-01 0:26 ` [PATCH 08/15] drm/amd/display: Fix warnings in amdgpu_dm Harry Wentland
2017-03-01 0:26 ` [PATCH 09/15] drm/amd/display: Fix warnings in DC Harry Wentland
2017-03-01 0:26 ` [PATCH 10/15] drm/amd/display: remove apply_clk_constraints, used validate_bandwidth universally Harry Wentland
2017-03-01 0:26 ` [PATCH 11/15] drm/amd/display: bandwidth update fix Harry Wentland
2017-03-01 0:26 ` [PATCH 12/15] drm/amd/display: move visual confirm recout adjustment to scaler Harry Wentland
2017-03-01 0:26 ` [PATCH 13/15] drm/amd/display: Some more warning fixes Harry Wentland
2017-03-01 0:26 ` [PATCH 14/15] drm/amd/display: Enable warnings as errors Harry Wentland
[not found] ` <20170301002620.24595-15-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-03-01 1:19 ` Michel Dänzer
2017-03-01 1:20 ` Emil Velikov
[not found] ` <CACvgo52iOcL5S3=93NEafvoD9yCsvVtryGwKTmVoxwFYZfe1eQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-01 15:04 ` Harry Wentland [this message]
2017-03-01 0:26 ` [PATCH 15/15] drm/amd/display: fix dce100_validate_bandwidth return value Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc47ed03-3eab-8983-33ee-fb0a33fed98a@amd.com \
--to=harry.wentland-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.