From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42791)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard.henderson@linaro.org>) id 1fEJeq-0008AS-J8
	for qemu-devel@nongnu.org; Thu, 03 May 2018 15:12:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <richard.henderson@linaro.org>) id 1fEJem-0005Q7-KL
	for qemu-devel@nongnu.org; Thu, 03 May 2018 15:12:48 -0400
Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:40519)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)
	id 1fEJem-0005Pf-DQ
	for qemu-devel@nongnu.org; Thu, 03 May 2018 15:12:44 -0400
Received: by mail-pf0-x233.google.com with SMTP id f189so15471677pfa.7
	for <qemu-devel@nongnu.org>; Thu, 03 May 2018 12:12:44 -0700 (PDT)
References: <20180503091922.28733-1-edgar.iglesias@gmail.com>
	<20180503091922.28733-23-edgar.iglesias@gmail.com>
From: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <fc4ccd4e-d0b5-61d9-68ef-fb1feb6c3841@linaro.org>
Date: Thu, 3 May 2018 12:12:40 -0700
MIME-Version: 1.0
In-Reply-To: <20180503091922.28733-23-edgar.iglesias@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 22/29] target-microblaze: Add Extended
 Addressing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, alistair@alistair23.me, frasse.iglesias@gmail.com, edgar.iglesias@xilinx.com

On 05/03/2018 02:19 AM, Edgar E. Iglesias wrote:
> +    trap_userspace(dc, ea);

Missing if (...) return?


r~