From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH 1/4] ACPI/IORT: Check ATS capability in root complex nodes Date: Thu, 21 Mar 2019 12:00:14 -0400 Message-ID: References: <20190320173634.21895-1-jean-philippe.brucker@arm.com> <20190320173634.21895-2-jean-philippe.brucker@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190320173634.21895-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jean-Philippe Brucker , will.deacon-5wv7dgnIgG8@public.gmane.org Cc: zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-acpi@vger.kernel.org On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: > err = pci_for_each_dma_alias(to_pci_dev(dev), > iort_pci_iommu_init, &info); > + > + if (!err && !iort_pci_rc_supports_ats(node)) > + dev->iommu_fwspec->flags |= IOMMU_FWSPEC_PCI_NO_ATS; Is it possible to remove !err check here. ATS supported is just a flag in IORT table. Does this decision have to rely on having a correct dma alias? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DBBC43381 for ; Thu, 21 Mar 2019 16:00:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2292A21874 for ; Thu, 21 Mar 2019 16:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yqbbzr5Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EYlI3UBg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2292A21874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U6zRf0qeVpr3+54WB6NGFFokiPR7j6ZGuSlqhHYfOcU=; b=Yqbbzr5YkWLfPY2gxtdWQAZcS YKvijZYtKWqgY8kEGItuJfJvjMAyEayRv5Fhj7+7L9Ej5ERoEjyPSDysjnNYkf73Z5Uh4igbxLolB U6w0/tb0rGBoIb4vl3uTFrDz8w7IbetU3smaIqAZcN50cHRTzK/U4DanJwziMF73Jj+GeS26gsoMu kxsVOwBoJx5T8l/hGIYHZccQ8pBd2eg6jXSE38fi+/uvKVSHjEfn/BBoIeNN5u6aXBefQePXPkzWJ Xwn28i57oYY11PCjPBqe0JxA+71pcQ1NDSkl97FFaGHcUOwpNyUJg4yx2I2uvZvf/dw6weNk21RTB DOqxuOzig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h707B-0000RN-1p; Thu, 21 Mar 2019 16:00:21 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7078-0000Qk-BI for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 16:00:19 +0000 Received: by mail-qt1-x843.google.com with SMTP id x12so7167768qts.7 for ; Thu, 21 Mar 2019 09:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Nru6Xww5SKGZ74zlZ5RrKGvvoI0YUsqBdQeFQqF6dkM=; b=EYlI3UBg8IXWDMI05qRSyxQaNQlNArPnvKS0jhhotoRMRB4Iz00GBYwCMzQzYGxfj3 6pmIZd1PUHtcSXNHXMuFLypK+kPx10gpODMtk1ysiG+IX/hLecgvI09c+kblT9wIu39G 1CKGvrhUp6X4iEEa/T+BdHtbcgmeH5OBck4TxNXovUtQRbclYi3MEAs/wZaCKKJI7JUp IRcL/R44ZMXQEveHOGSKc2sfaAOI7v/qvz90yKdndyrzzpG5BypXFgYq68c1IBpwr3Qk IUC+7InYf4rIlljnb851OQZsssoU7prHtVMbLhD8yAdWuo9wfy++pMnAMfaMTlKNPfCi 5UAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nru6Xww5SKGZ74zlZ5RrKGvvoI0YUsqBdQeFQqF6dkM=; b=g6bevtqf8xjXAJkhh0BA566wlrRiuszfxG7wGMdCOcyig+hhH+aCtMVctakqp3Ulbe GxxzYhYyRqt3aviuo8yM8V4P13dXoSAydsfJCe5KW3s7w7MbWGF9rTRYYCmJm6/9aTgw 1xRm+ImQwg+D7BvnL3QtXUaoQWbkVC+3ury1hM9XxmIjwf5Up3nXOZ0NTtdt8RQFjQj6 PXVroIpW264fjvQOLT38z8SWuyqdn2JSiWP6aQ5641H0m/9mqzAl3sH4yTgKlFbCzGKE J7yvqdO5WKTfG1Wyo9DAdafn5C/dgrsKfkrMlMVwh12YEjwwmnFBnL64xqbUaK/cwH+3 Luyw== X-Gm-Message-State: APjAAAUbBp0okcXWkekCeY9D09McMbbY/v+KvEqUQCAVDPL0qhugZy3v VWFW9mDXkrsczMhhauIZ5gI= X-Google-Smtp-Source: APXvYqwvP5Jat5f5MPyeDLIq2dApvSqW2wQEObiJTm/jWnWjev7cu9fnyUsN7WJbyNI4zxUYaAJTJQ== X-Received: by 2002:aed:3c09:: with SMTP id t9mr3629349qte.353.1553184015998; Thu, 21 Mar 2019 09:00:15 -0700 (PDT) Received: from [10.84.150.6] ([167.220.149.6]) by smtp.gmail.com with ESMTPSA id k12sm3741739qti.38.2019.03.21.09.00.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 09:00:15 -0700 (PDT) From: Sinan Kaya X-Google-Original-From: Sinan Kaya Subject: Re: [PATCH 1/4] ACPI/IORT: Check ATS capability in root complex nodes To: Jean-Philippe Brucker , will.deacon@arm.com References: <20190320173634.21895-1-jean-philippe.brucker@arm.com> <20190320173634.21895-2-jean-philippe.brucker@arm.com> Message-ID: Date: Thu, 21 Mar 2019 12:00:14 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190320173634.21895-2-jean-philippe.brucker@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_090018_444570_E7B0BA17 X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lorenzo.pieralisi@arm.com, zhongmiao@hisilicon.com, joro@8bytes.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, hanjun.guo@linaro.org, sudeep.holla@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, lenb@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: > err = pci_for_each_dma_alias(to_pci_dev(dev), > iort_pci_iommu_init, &info); > + > + if (!err && !iort_pci_rc_supports_ats(node)) > + dev->iommu_fwspec->flags |= IOMMU_FWSPEC_PCI_NO_ATS; Is it possible to remove !err check here. ATS supported is just a flag in IORT table. Does this decision have to rely on having a correct dma alias? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel