From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C32EC433DF for ; Mon, 25 May 2020 07:03:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00CEB206DD for ; Mon, 25 May 2020 07:03:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00CEB206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jd782-0002p9-FL; Mon, 25 May 2020 07:02:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jd781-0002p4-8O for xen-devel@lists.xenproject.org; Mon, 25 May 2020 07:02:29 +0000 X-Inumbo-ID: b0b4c3d8-9e55-11ea-ae97-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0b4c3d8-9e55-11ea-ae97-12813bfff9fa; Mon, 25 May 2020 07:02:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C7A5DABCF; Mon, 25 May 2020 07:02:27 +0000 (UTC) Subject: Re: [PATCH v10 00/12] Add hypervisor sysfs-like support To: paul@xen.org, 'Jan Beulich' , 'Kevin Tian' , 'Julien Grall' , 'Jun Nakajima' , 'Wei Liu' , 'Ian Jackson' , 'Daniel De Graaf' References: <20200519072106.26894-1-jgross@suse.com> <24935c43-2f2d-83cf-9039-ec0f97498103@suse.com> <305d829f-24a9-1a6d-2131-fed92c22c305@suse.com> <000f01d62db4$57181e90$05485bb0$@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Mon, 25 May 2020 09:02:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <000f01d62db4$57181e90$05485bb0$@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Stefano Stabellini' , 'Andrew Cooper' , 'George Dunlap' , 'Anthony PERARD' , xen-devel@lists.xenproject.org, 'Volodymyr Babchuk' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 19.05.20 10:06, Paul Durrant wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 19 May 2020 08:45 >> To: Jürgen Groß ; Kevin Tian ; Julien Grall ; >> Jun Nakajima ; Wei Liu ; Ian Jackson ; >> Daniel De Graaf ; Paul Durrant >> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini ; Andrew Cooper >> ; George Dunlap ; Anthony PERARD >> ; Volodymyr Babchuk ; Roger Pau Monné >> >> Subject: Re: [PATCH v10 00/12] Add hypervisor sysfs-like support >> >> On 19.05.2020 09:30, Jürgen Groß wrote: >>> On 19.05.20 09:20, Juergen Gross wrote: >>>> >>>> Juergen Gross (12): >>>> xen/vmx: let opt_ept_ad always reflect the current setting >>>> xen: add a generic way to include binary files as variables >>>> docs: add feature document for Xen hypervisor sysfs-like support >>>> xen: add basic hypervisor filesystem support >>>> libs: add libxenhypfs >>>> tools: add xenfs tool >>>> xen: provide version information in hypfs >>>> xen: add /buildinfo/config entry to hypervisor filesystem >>>> xen: add runtime parameter access support to hypfs >>>> tools/libxl: use libxenhypfs for setting xen runtime parameters >>>> tools/libxc: remove xc_set_parameters() >>>> xen: remove XEN_SYSCTL_set_parameter support >>>> >>>> .gitignore | 6 + >>>> docs/features/hypervisorfs.pandoc | 92 +++++ >>>> docs/man/xenhypfs.1.pod | 61 ++++ >>>> docs/misc/hypfs-paths.pandoc | 165 +++++++++ >>>> tools/Rules.mk | 8 +- >>>> tools/flask/policy/modules/dom0.te | 4 +- >>>> tools/libs/Makefile | 1 + >>>> tools/libs/hypfs/Makefile | 16 + >>>> tools/libs/hypfs/core.c | 536 ++++++++++++++++++++++++++++ >>>> tools/libs/hypfs/include/xenhypfs.h | 90 +++++ >>>> tools/libs/hypfs/libxenhypfs.map | 10 + >>>> tools/libs/hypfs/xenhypfs.pc.in | 10 + >>>> tools/libxc/include/xenctrl.h | 1 - >>>> tools/libxc/xc_misc.c | 21 -- >>>> tools/libxl/Makefile | 3 +- >>>> tools/libxl/libxl.c | 53 ++- >>>> tools/libxl/libxl_internal.h | 1 + >>>> tools/libxl/xenlight.pc.in | 2 +- >>>> tools/misc/Makefile | 6 + >>>> tools/misc/xenhypfs.c | 192 ++++++++++ >>>> tools/xl/xl_misc.c | 1 - >>>> xen/arch/arm/traps.c | 3 + >>>> xen/arch/arm/xen.lds.S | 13 +- >>>> xen/arch/x86/hvm/hypercall.c | 3 + >>>> xen/arch/x86/hvm/vmx/vmcs.c | 47 ++- >>>> xen/arch/x86/hvm/vmx/vmx.c | 4 +- >>>> xen/arch/x86/hypercall.c | 3 + >>>> xen/arch/x86/pv/domain.c | 21 +- >>>> xen/arch/x86/pv/hypercall.c | 3 + >>>> xen/arch/x86/xen.lds.S | 12 +- >>>> xen/common/Kconfig | 23 ++ >>>> xen/common/Makefile | 13 + >>>> xen/common/grant_table.c | 62 +++- >>>> xen/common/hypfs.c | 452 +++++++++++++++++++++++ >>>> xen/common/kernel.c | 84 ++++- >>>> xen/common/sysctl.c | 36 -- >>>> xen/drivers/char/console.c | 72 +++- >>>> xen/include/Makefile | 1 + >>>> xen/include/asm-x86/hvm/vmx/vmcs.h | 3 +- >>>> xen/include/public/hypfs.h | 129 +++++++ >>>> xen/include/public/sysctl.h | 19 +- >>>> xen/include/public/xen.h | 1 + >>>> xen/include/xen/hypercall.h | 10 + >>>> xen/include/xen/hypfs.h | 123 +++++++ >>>> xen/include/xen/kernel.h | 3 + >>>> xen/include/xen/lib.h | 1 - >>>> xen/include/xen/param.h | 126 +++++-- >>>> xen/include/xlat.lst | 2 + >>>> xen/include/xsm/dummy.h | 6 + >>>> xen/include/xsm/xsm.h | 6 + >>>> xen/tools/binfile | 43 +++ >>>> xen/xsm/dummy.c | 1 + >>>> xen/xsm/flask/Makefile | 5 +- >>>> xen/xsm/flask/flask-policy.S | 16 - >>>> xen/xsm/flask/hooks.c | 9 +- >>>> xen/xsm/flask/policy/access_vectors | 4 +- >>>> 56 files changed, 2445 insertions(+), 193 deletions(-) >>>> create mode 100644 docs/features/hypervisorfs.pandoc >>>> create mode 100644 docs/man/xenhypfs.1.pod >>>> create mode 100644 docs/misc/hypfs-paths.pandoc >>>> create mode 100644 tools/libs/hypfs/Makefile >>>> create mode 100644 tools/libs/hypfs/core.c >>>> create mode 100644 tools/libs/hypfs/include/xenhypfs.h >>>> create mode 100644 tools/libs/hypfs/libxenhypfs.map >>>> create mode 100644 tools/libs/hypfs/xenhypfs.pc.in >>>> create mode 100644 tools/misc/xenhypfs.c >>>> create mode 100644 xen/common/hypfs.c >>>> create mode 100644 xen/include/public/hypfs.h >>>> create mode 100644 xen/include/xen/hypfs.h >>>> create mode 100755 xen/tools/binfile >>>> delete mode 100644 xen/xsm/flask/flask-policy.S >>>> >>> >>> There are some Acks missing on this series, so please have a look at the >>> patches! >>> >>> There are missing especially: >>> >>> - Patch 1: VMX maintainers >>> - Patch 2 + 4: XSM maintainer >>> - Patch 4 + 9: Arm maintainer >>> - Patch 10 + 11: tools maintainers >>> >>> I'd really like the series to go into 4.14 (deadline this Friday). >> > > I would also like to see this in 4.14. > >> FTR I'm intending to waive the need for the first three of the named >> sets if they don't arrive by Friday (and there I don't mean last >> minute on Friday) - they're not overly intrusive (maybe with the >> exception of the XSM parts in #4) and the series has been pending >> for long enough. I don't feel comfortable to do so for patch 10, >> though; patch 11 looks to be simple enough again. >> >> Paul, as the release manager, please let me know if you disagree. >> > > Looking at patch #4, I'm not confident that the XSM parts are complete (e.g. does xen.if need updating?). Also I'd put the new access vector in xen2, since that's where set_parameter currently is (and will be removed from in a later patch), but the xen class does appear to have space so that's really just my taste. I don't think xen.if needs updating, as it contains only macros for groups of operations. As the new hypercall isn't only replacing set_parameter, but has much wider semantics, I don't think it should go to xen2. There will be probably more interfaces being replaced and/or added after all. Juergen