From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:46165 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbeBVT1h (ORCPT ); Thu, 22 Feb 2018 14:27:37 -0500 Received: by mail-pl0-f66.google.com with SMTP id x19so3434608plr.13 for ; Thu, 22 Feb 2018 11:27:37 -0800 (PST) Subject: Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge To: David Miller Cc: jiri@resnulli.us, netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com References: <20180220074512.4307-1-jiri@resnulli.us> <20180222.135839.2197107822845062302.davem@davemloft.net> From: David Ahern Message-ID: Date: Thu, 22 Feb 2018 12:27:35 -0700 MIME-Version: 1.0 In-Reply-To: <20180222.135839.2197107822845062302.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/22/18 11:58 AM, David Miller wrote: > From: David Ahern > Date: Wed, 21 Feb 2018 11:16:35 -0700 > >> On 2/20/18 12:45 AM, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >>> bridge, but some users need the ability to enslave physical ports as >>> well. >>> >>> This is achieved by mapping the port and VID 1 to the bridge's vFID, >>> instead of the port and the VID used by the VLAN device. >>> >>> The above is valid because as long as the port is not enslaved to a >>> bridge, VID 1 is guaranteed to be configured as PVID and egress >>> untagged. >>> >>> Signed-off-by: Ido Schimmel >>> Signed-off-by: Jiri Pirko >>> --- >>> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 +++++------- >>> 1 file changed, 5 insertions(+), 7 deletions(-) >>> >> >> Maybe I am missing something in the setup, but I am not getting >> host-to-host connectivity. I booted a switch with this patch, configured >> a bridge: > > I'm waiting for this discussion to be fully resolved before applying this > patch. Just FYI... > Ido: IPv4 works at boot; IPv6 requires the mcast snooping disable. For this vlan-unaware bridges can that be set automatically? And then, what are the options for lldp?