From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D230C43334 for ; Wed, 29 Jun 2022 10:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232334AbiF2KHV (ORCPT ); Wed, 29 Jun 2022 06:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbiF2KHU (ORCPT ); Wed, 29 Jun 2022 06:07:20 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492803DA6F for ; Wed, 29 Jun 2022 03:07:19 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id fw3so3880490ejc.10 for ; Wed, 29 Jun 2022 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UI9cYbOS287xUrQaY8UIv5U4S9Lu0ZwNP7V9PXH0PV4=; b=NCZHWN/cJfm3yny65P8YlLhwiDOO26ZGNIOI86H8qkah4/8sC2HH4UF0vcAQBvnhR/ JuzFrPrnGn7/VJSNEfJGL45unlg7C7ye2LcicTxY0l/+dyalv/069wFcagPKFYOMcQeK V4zFV6PwhuwiL7Ra/0J9qJQ9BW26dVMAgqP8dqpYZgVm4srrH/kUApqswi6gyA64RmDs MSGD66lRTRCTNHu0f2FfNzS7Acg9ZA1hk568F7ku7Jt1AkKOYJTLkXLYKx1qqKfx/hov HPA146AMhxsHv1o9tnYM3yyQiPcUSYNYlvNaUjBw6ZkDxFMyQ4ktdIoL/Q+HXWFZg9XQ lTDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UI9cYbOS287xUrQaY8UIv5U4S9Lu0ZwNP7V9PXH0PV4=; b=Lr9t1tphRfNGlUahh6HZ/3XraVZEtbdiea9/pozohVMGLO+Ro1cRhDaEUAfoVWl07G U+IqnYi7VwAM5qiwTU/Wr7EVqnlOo3PZuLNwmTU+TG99Go4MoKl+nl+CGn8ymr/V2wVT XUa3nEwIotO+0VQOltq6QvyoxZsBJV5aMhStAiWj3P9YhSrqIhLTndNcKmD+jJkASxIi L3lai+CETU9/jMXsimfGTiuaTp8LD3MU1bGbqf2Tf/qm8WEUbV0knfx2h0izGQ8eDay8 Nf11Br4jYflDeqhC5h24abg57AgTZkKrCaaQY0YyXzx+tHLX6YWvCaZHrHS/NHKsJzW0 nALA== X-Gm-Message-State: AJIora+ldFUh4wBnX19GuVzb+Tu1zGeuW0Mm8TagvrvSsaWabA1vXYT4 U9PtspU6YJrTT6mhtGxdhbE7ug== X-Google-Smtp-Source: AGRyM1t88ZULBHs8ccIHaDmNBddyVX1Qha12QXv8ndf/tZldlCtfEPBLrfk8gfi9BQDElKx1RSrzJw== X-Received: by 2002:a17:907:c1d:b0:726:3239:fe83 with SMTP id ga29-20020a1709070c1d00b007263239fe83mr2513343ejc.51.1656497237837; Wed, 29 Jun 2022 03:07:17 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id k25-20020a170906971900b00724e6a55d1asm7469511ejx.197.2022.06.29.03.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 03:07:17 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 12:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager Content-Language: en-US To: Appana Durga Kedareswara rao , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org Cc: git@amd.com, git@xilinx.com References: <20220628054338.1631516-1-appana.durga.rao@xilinx.com> <20220628054338.1631516-2-appana.durga.rao@xilinx.com> From: Krzysztof Kozlowski In-Reply-To: <20220628054338.1631516-2-appana.durga.rao@xilinx.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/06/2022 07:43, Appana Durga Kedareswara rao wrote: > This commit adds documentation for Triple Modular Redundancy(TMR) Manager > IP. The Triple Modular Redundancy(TMR) Manager is responsible for handling > the TMR subsystem state, including fault detection and error recovery > provides soft error detection, correction and recovery features. > > Signed-off-by: Appana Durga Kedareswara rao > --- > .../bindings/misc/xlnx,tmr-manager.yaml | 48 +++++++++++++++++++ This is not a misc device. Find appropriate subsystem for it. It's not EDAC, right? > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > > diff --git a/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml b/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > new file mode 100644 > index 000000000000..f6cb4d235981 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/xlnx,tmr-manager.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx TMR Microblaze Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Appana Durga Kedareswara rao > + > +description: | > + The Triple Modular Redundancy(TMR) Manager is responsible for handling the > + TMR subsystem state, including fault detection and error recovery. The core > + is triplicated in each of the sub-blocks in the TMR subsystem, and provides > + majority voting of its internal state. > + > +properties: > + compatible: > + enum: > + - xlnx,tmr-manager-1.0 > + > + reg: > + maxItems: 1 > + > + xlnx,magic1: > + minimum: 0 > + maximum: 255 > + description: > + Magic number 1, When writing to the control register the first write data > + byte (bits 7:0) must match this value in order to have any effect on the > + nominal recovery function. Register values are usually not in the scope of bindings. We describe here hardware, not programming model, although in case of soft cores maybe it's a bit different. Anyway you need to describe the actual feature, not OS behavior. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +required: > + - compatible > + - reg > + - xlnx,magic1 > + > +additionalProperties: false > + > +examples: > + - | > + tmr-manager@44a10000 { Depending on what is this, you should use appropriate generic node name. > + compatible = "xlnx,tmr-manager-1.0"; > + reg = <0x44a10000 0x10000>; > + xlnx,magic1 = <0x46>; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCFD2C433EF for ; Wed, 29 Jun 2022 10:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D4FvyyHAq/CjzTCvrkhmC0Ek+5cMatqW+0dTFEMywz4=; b=5GU+8V4Grm4S2E IbO1c8ydPiwpHpTf53tnWXpdc+zQOVJp/g+rluHyi1vCae15BcfQnfulUkDryGQUnQlZbaEor4jRK 2c7KbFmHXbU+QFem7x8BMkCR4ocY6qKfuzVusT+EV0JjhopRBYIs0wIky8w0rhuUeobfStkw5cM6F s6VfEmf5PMEbckltyY8HqAf5/Q14KccDPVe4KLRbn4RZsWAQV8Lpbr33oc6yhyaAyB/wz5K/SdZP2 FuMU9PFqMZZyqwLjXyxo1m6hqu9XsX+82k6ELXftSYfKVBhbU3BTjrWkTLg/D1VVYSQlYH3z4ywPc Wv6POI/OHtCajcnFkpiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Ubc-00AuxK-9u; Wed, 29 Jun 2022 10:07:33 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6UbT-00Aut8-37 for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 10:07:24 +0000 Received: by mail-ej1-x635.google.com with SMTP id g26so31519308ejb.5 for ; Wed, 29 Jun 2022 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UI9cYbOS287xUrQaY8UIv5U4S9Lu0ZwNP7V9PXH0PV4=; b=NCZHWN/cJfm3yny65P8YlLhwiDOO26ZGNIOI86H8qkah4/8sC2HH4UF0vcAQBvnhR/ JuzFrPrnGn7/VJSNEfJGL45unlg7C7ye2LcicTxY0l/+dyalv/069wFcagPKFYOMcQeK V4zFV6PwhuwiL7Ra/0J9qJQ9BW26dVMAgqP8dqpYZgVm4srrH/kUApqswi6gyA64RmDs MSGD66lRTRCTNHu0f2FfNzS7Acg9ZA1hk568F7ku7Jt1AkKOYJTLkXLYKx1qqKfx/hov HPA146AMhxsHv1o9tnYM3yyQiPcUSYNYlvNaUjBw6ZkDxFMyQ4ktdIoL/Q+HXWFZg9XQ lTDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UI9cYbOS287xUrQaY8UIv5U4S9Lu0ZwNP7V9PXH0PV4=; b=HoUycviZ05gioigVY+cQBiU+IIvh5qmqSXPEg+4CVTS9cKq8wxJ8LGALI19JBiCmUT qr+iMQvffHD5cPfBeBWh065SLtY1EJy48eEXdIB7tTaSQ4udfdNvfu2Y2ZufNFJr1eme IcEimrc/OBLOjvrMIdXoAmta6IYjXjlLcGknkNDh/3Mu6hFqk3zTtbJy1B0vPGmsFYOw vl+gU2fRXifQFrikzwy4nF+bo6IQec3tqI5SSirk5IoCOZyhUIj/gFfa0b+U6OiQueuD E/Xfjqx8m2zOhBCs9DxVTbfkKVF6VBsjAKmlt9wKnyZDihuUkiOlDItCLBqMLtBPPPYA LRJg== X-Gm-Message-State: AJIora8PEr9zUQXJjaectFLEeK6U6/zQ3Opz6mHQ/aEWztQ3N4vaF1qK WftgYjcrcuFCQcHpiD65e+ozgg== X-Google-Smtp-Source: AGRyM1t88ZULBHs8ccIHaDmNBddyVX1Qha12QXv8ndf/tZldlCtfEPBLrfk8gfi9BQDElKx1RSrzJw== X-Received: by 2002:a17:907:c1d:b0:726:3239:fe83 with SMTP id ga29-20020a1709070c1d00b007263239fe83mr2513343ejc.51.1656497237837; Wed, 29 Jun 2022 03:07:17 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id k25-20020a170906971900b00724e6a55d1asm7469511ejx.197.2022.06.29.03.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 03:07:17 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 12:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager Content-Language: en-US To: Appana Durga Kedareswara rao , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org Cc: git@amd.com, git@xilinx.com References: <20220628054338.1631516-1-appana.durga.rao@xilinx.com> <20220628054338.1631516-2-appana.durga.rao@xilinx.com> From: Krzysztof Kozlowski In-Reply-To: <20220628054338.1631516-2-appana.durga.rao@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_030723_194482_3431EDE8 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/06/2022 07:43, Appana Durga Kedareswara rao wrote: > This commit adds documentation for Triple Modular Redundancy(TMR) Manager > IP. The Triple Modular Redundancy(TMR) Manager is responsible for handling > the TMR subsystem state, including fault detection and error recovery > provides soft error detection, correction and recovery features. > > Signed-off-by: Appana Durga Kedareswara rao > --- > .../bindings/misc/xlnx,tmr-manager.yaml | 48 +++++++++++++++++++ This is not a misc device. Find appropriate subsystem for it. It's not EDAC, right? > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > > diff --git a/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml b/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > new file mode 100644 > index 000000000000..f6cb4d235981 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/xlnx,tmr-manager.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx TMR Microblaze Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Appana Durga Kedareswara rao > + > +description: | > + The Triple Modular Redundancy(TMR) Manager is responsible for handling the > + TMR subsystem state, including fault detection and error recovery. The core > + is triplicated in each of the sub-blocks in the TMR subsystem, and provides > + majority voting of its internal state. > + > +properties: > + compatible: > + enum: > + - xlnx,tmr-manager-1.0 > + > + reg: > + maxItems: 1 > + > + xlnx,magic1: > + minimum: 0 > + maximum: 255 > + description: > + Magic number 1, When writing to the control register the first write data > + byte (bits 7:0) must match this value in order to have any effect on the > + nominal recovery function. Register values are usually not in the scope of bindings. We describe here hardware, not programming model, although in case of soft cores maybe it's a bit different. Anyway you need to describe the actual feature, not OS behavior. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +required: > + - compatible > + - reg > + - xlnx,magic1 > + > +additionalProperties: false > + > +examples: > + - | > + tmr-manager@44a10000 { Depending on what is this, you should use appropriate generic node name. > + compatible = "xlnx,tmr-manager-1.0"; > + reg = <0x44a10000 0x10000>; > + xlnx,magic1 = <0x46>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel