All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com,
	eric.dumazet@gmail.com, simon.horman@netronome.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v9 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch
Date: Wed, 26 Apr 2017 09:19:54 -0400	[thread overview]
Message-ID: <fc75c67b-2413-a9a9-2411-7789eef43203@mojatatu.com> (raw)
In-Reply-To: <5723f2e0-7738-09f5-23c0-bfe7432d7528@mojatatu.com>

On 17-04-26 09:17 AM, Jamal Hadi Salim wrote:
> On 17-04-26 09:08 AM, Jiri Pirko wrote:
>> Wed, Apr 26, 2017 at 02:42:17PM CEST, jhs@mojatatu.com wrote:
>
>>> +#define VALID_TCA_ROOT_FLAGS TCA_FLAG_LARGE_DUMP_ON
>>> +static inline bool tca_flags_valid(u32 act_flags)
>>> +{
>>> +    u32 invalid_flags_mask  = ~VALID_TCA_ROOT_FLAGS;
>>> +
>>> +    if (act_flags & invalid_flags_mask)
>>> +        return false;
>>> +
>>> +    return true;
>>
>> This dance should either not be here (flag-per-attr) or should be in
>> netlink generic place. This is not TC specific at all.
>>
>
> So where do you think it should be?

It would also be helpful for you to make comments when these things
show up. This change was in version 6. I have had to do this back and
forth a few times.

cheers,
jamal

  reply	other threads:[~2017-04-26 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 12:42 [PATCH net-next v9 0/3] net sched actions: improve dump performance Jamal Hadi Salim
2017-04-26 12:42 ` [PATCH net-next v9 1/3] net sched actions: Use proper root attribute table for actions Jamal Hadi Salim
2017-04-26 12:42 ` [PATCH net-next v9 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Jamal Hadi Salim
2017-04-26 13:08   ` Jiri Pirko
2017-04-26 13:17     ` Jamal Hadi Salim
2017-04-26 13:19       ` Jamal Hadi Salim [this message]
2017-04-26 13:48         ` Jiri Pirko
2017-04-26 13:47       ` Jiri Pirko
2017-04-26 12:42 ` [PATCH net-next v9 3/3] net sched actions: add time filter for action dumping Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc75c67b-2413-a9a9-2411-7789eef43203@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=simon.horman@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.