From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41A91C6FD1F for ; Wed, 22 Mar 2023 17:01:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pf1q8-0007C6-D9; Wed, 22 Mar 2023 13:01:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf1q6-0007Bd-N7 for qemu-devel@nongnu.org; Wed, 22 Mar 2023 13:01:30 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pf1q5-0005cs-7I for qemu-devel@nongnu.org; Wed, 22 Mar 2023 13:01:30 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MGrqmG025089; Wed, 22 Mar 2023 17:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=acv9jXCqmkjlbeAXDuy19DH/DCxiTyiEp1HsPB+s8BI=; b=rf8bnENKomlb449hP1HI4QOV+ZBkweYb6F/VYK1bBHlTWd15ljEDx4blWELbMGdCI0wS lnoQOfXbxMCsJAd7ynakswEEgW2ZpYyJIn1Krf6XSklYtmCNg/rr9eDdYPaCQ8gasglk OK/VAenIG9Vc6V240di4fgpaXpwdEHdGFCwfgnNpz4RJSqfNO+UO9WnfFWz4cc26o6eN XfqzCEYmSbiTUcgY/aUr4kfKTAOwpChhrc2IB9EKhME5knDJkUj/3fYE8uX2B6MA/ALm tlVWCNRb081SEArjeVsFm+uCtn9EQLythQogdX8sl7qNM7+hEylI2kx9qsq+Fg2C74/P AA== Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pg5kq85nx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 17:01:14 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32MEPeHe031919; Wed, 22 Mar 2023 17:01:13 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3pd4x71c3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 17:01:13 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32MH1BWO51905014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Mar 2023 17:01:12 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8CED58060; Wed, 22 Mar 2023 17:01:11 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 803EE5805F; Wed, 22 Mar 2023 17:01:11 +0000 (GMT) Received: from [9.211.118.39] (unknown [9.211.118.39]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Mar 2023 17:01:11 +0000 (GMT) Message-ID: Date: Wed, 22 Mar 2023 12:01:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] Add support for TPM devices over I2C bus Content-Language: en-US To: Stefan Berger , Ninad Palsule , qemu-devel@nongnu.org Cc: joel@jms.id.au, andrew@aj.id.au, clg@kaod.org References: <20230321053001.3886666-1-ninad@linux.ibm.com> <20230321053001.3886666-4-ninad@linux.ibm.com> <2d32bfa7-0804-c046-bb8c-ca30d400ed4a@linux.ibm.com> <9d656af9-913b-c586-79cf-eae842f45281@linux.vnet.ibm.com> From: Ninad Palsule In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dw72eMIZv-WbsXLjTiH-pR75UwBLI7QY X-Proofpoint-ORIG-GUID: dw72eMIZv-WbsXLjTiH-pR75UwBLI7QY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_13,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220117 Received-SPF: none client-ip=148.163.158.5; envelope-from=ninad@linux.vnet.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/22/23 6:50 AM, Stefan Berger wrote: > > > On 3/22/23 07:28, Ninad Palsule wrote: >> >> On 3/21/23 8:30 PM, Stefan Berger wrote: >>> >>> >>> On 3/21/23 01:30, Ninad Palsule wrote: >>>> Qemu already supports devices attached to ISA and sysbus. This drop >>>> adds >>>> support for the I2C bus attached TPM devices. I2C model only supports >>>> TPM2 protocol. >>>> >>> >>>> + >>>> +/* Send data to TPM */ >>>> +static inline void tpm_tis_i2c_tpm_send(TPMStateI2C *i2cst) >>>> +{ >>>> +    if ((i2cst->operation == OP_SEND) && (i2cst->offset > 1)) { >>>> +        uint16_t tis_reg; >>>> +        uint32_t data; >>>> +        int      i; >>>> + >>>> +        tis_reg = tpm_tis_i2c_to_tis_reg(i2cst->data[0], >>>> &i2cst->size); >>>> + >>>> +        /* Index 0 is always a register */ >>>> +        for (i = 1; i < i2cst->offset; i++) { >>>> +            data = (i2cst->data[i] & 0xff); >>>> +            tpm_tis_write_data(&i2cst->state, tis_reg, data, 1); >>>> +        } >>> >>> >>> I think there should be tpm_tis_set_data_buffer function that you >>> can call rather than transferring the data byte-by-byte. >>> >>> Thanks for the series! >>> >>>   Stefan >> >> I thought about it but the FIFO case performs multiple operations >> hence I did not want to change it. Currently there is no function to >> set data buffer in the common code. > > It may not be correct to transfer it in one go, either. I just printed > the I2C specs and I am going to look at them now. > When one writes TPM command data to the TIS the STS register has its > TPM_TIS_STS_VALID bit set and TPM_TIS_STS_EXPECT bit reset once the > command is complete. This would imply that you should not have a > holding area for the command bytes but pass them on to the TIS > immediately to get the effect of the STS register... > >    Stefan > Yes, I had issue related to STS status while reading but did not see any issue while writing but now I have changed it to _send too so there is no holding area for FIFO data in the I2C. > >> >> Thanks for the review! >> >> Ninad Palsule >>