From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schmitz Subject: Re: [parted-devel] Atari label false positives Date: Sun, 13 May 2018 07:22:17 +1200 Message-ID: References: <2d6f5455-963d-b044-a64d-67634df46071@ubuntu.com> <35ad9889-bc13-56bd-7831-f7bb3eea2d1e@physik.fu-berlin.de> <874bf955-d5bc-5d9c-0f87-445da67f3bdd@ubuntu.com> <80a28dd6-ce19-e6ed-fc7a-c5561fecf989@gmail.com> <82528a79-31d5-e8c9-08db-253462619197@physik.fu-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Resent-Message-ID: List-URL: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Archive: https://lists.debian.org/msgid-search/fc99627f-ebb7-d556-2f69-72b4f5a557ef@gmail.com To: John Paul Adrian Glaubitz , Phillip Susi Cc: Debian m68k , Linux/m68k , Parted development List-Id: linux-m68k@vger.kernel.org Hi Adrian, Am 12.05.2018 um 23:24 schrieb John Paul Adrian Glaubitz: > On 05/12/2018 10:41 AM, Michael Schmitz wrote: >>>> Do you have a dump of the root sector (plus additional eventual >>>> extended >>>> partition root sector) from these bugs? >>> >>> This is a very good point. We should have a look at the probing code in >>> the kernel because apparently the problem doesn't exist there. >> >> It may not exist because the MSDOS partition detection is specific >> enough to reject Atari partition tables. But still, compare the kernel >> partition parsers to see what may be missing. > > Which would mean that the kernel probes for DOS partition tables before > Atari partition tables, wouldn't it? Yes, it does (as I had stated earlier - block/partitions/checks.c has only a few rather more specific formats listed before MSDOS. Sorry if that wasn't clear.). > > Adrian >