From: <Codrin.Ciubotariu@microchip.com> To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org> Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>, <mirq-linux@rere.qmqm.pl>, <alexandre.belloni@free-electrons.com> Subject: Re: [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA Date: Thu, 8 Jul 2021 08:19:07 +0000 [thread overview] Message-ID: <fca8f952-2be0-5c57-d60d-5c4f025abc4d@microchip.com> (raw) In-Reply-To: <20210707214752.3831-1-rdunlap@infradead.org> On 08.07.2021 00:47, Randy Dunlap wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On a config (such as arch/sh/) which does not set HAS_DMA when MMU > is not set, several ATMEL ASoC drivers select symbols that cause > kconfig warnings. There is one "depends on HAS_DMA" which is no longer > needed. Dropping it eliminates the kconfig warnings and still builds > with no problems reported. > > Fix the following kconfig warnings: > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] > - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m] > - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > > Fixes: 3951e4aae2ce ("ASoC: atmel-pcm: dma support based on pcm dmaengine") > Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig") > Fixes: 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") I am not sure about these fixes tags. As Alexandre mentioned, it looks like the reason for HAS_DMA in the first place was the COMPILE_TEST with m32r arch. I dig a bit, and, if any, I think we should use: Fixes: eb17726b00b3 ("m32r: add simple dma") since this commit adds dummy DMA support for m32r and seems to fix the HAS_DMA dependency. > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Cc: alsa-devel@alsa-project.org > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl> Other than that: Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Thanks! Codrin
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com> To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org> Cc: alsa-devel@alsa-project.org, broonie@kernel.org, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, mirq-linux@rere.qmqm.pl Subject: Re: [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA Date: Thu, 8 Jul 2021 08:19:07 +0000 [thread overview] Message-ID: <fca8f952-2be0-5c57-d60d-5c4f025abc4d@microchip.com> (raw) In-Reply-To: <20210707214752.3831-1-rdunlap@infradead.org> On 08.07.2021 00:47, Randy Dunlap wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On a config (such as arch/sh/) which does not set HAS_DMA when MMU > is not set, several ATMEL ASoC drivers select symbols that cause > kconfig warnings. There is one "depends on HAS_DMA" which is no longer > needed. Dropping it eliminates the kconfig warnings and still builds > with no problems reported. > > Fix the following kconfig warnings: > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] > - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > Selected by [m]: > - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m] > - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > > Fixes: 3951e4aae2ce ("ASoC: atmel-pcm: dma support based on pcm dmaengine") > Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig") > Fixes: 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") I am not sure about these fixes tags. As Alexandre mentioned, it looks like the reason for HAS_DMA in the first place was the COMPILE_TEST with m32r arch. I dig a bit, and, if any, I think we should use: Fixes: eb17726b00b3 ("m32r: add simple dma") since this commit adds dummy DMA support for m32r and seems to fix the HAS_DMA dependency. > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Cc: alsa-devel@alsa-project.org > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl> Other than that: Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Thanks! Codrin
next prev parent reply other threads:[~2021-07-08 8:19 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-07 21:47 [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA Randy Dunlap 2021-07-07 21:47 ` Randy Dunlap 2021-07-07 21:59 ` Alexandre Belloni 2021-07-07 21:59 ` Alexandre Belloni 2021-07-08 8:19 ` Codrin.Ciubotariu [this message] 2021-07-08 8:19 ` Codrin.Ciubotariu 2021-07-08 16:50 ` Randy Dunlap 2021-07-08 16:50 ` Randy Dunlap 2021-09-02 16:44 ` Geert Uytterhoeven 2021-09-02 16:44 ` Geert Uytterhoeven 2021-09-03 19:53 ` Randy Dunlap 2021-09-03 19:53 ` Randy Dunlap 2021-09-06 7:14 ` Geert Uytterhoeven 2021-09-06 7:14 ` Geert Uytterhoeven 2021-09-08 20:14 ` Randy Dunlap 2021-09-08 20:14 ` Randy Dunlap 2021-09-09 7:22 ` Geert Uytterhoeven 2021-09-09 7:22 ` Geert Uytterhoeven 2021-09-10 1:53 ` Randy Dunlap 2021-09-10 1:53 ` Randy Dunlap 2021-07-12 10:46 ` Mark Brown 2021-07-12 10:46 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fca8f952-2be0-5c57-d60d-5c4f025abc4d@microchip.com \ --to=codrin.ciubotariu@microchip.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mirq-linux@rere.qmqm.pl \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.