From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 1/2] x86: consider effective protection attributes in W+X check Date: Thu, 14 Dec 2017 15:04:09 +0100 Message-ID: References: <5A2FBC570200007800196B3E@prv-mh.provo.novell.com> <5A2FBE0A0200007800196B4F@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePU7X-0003c0-L0 for xen-devel@lists.xenproject.org; Thu, 14 Dec 2017 14:04:19 +0000 In-Reply-To: <5A2FBE0A0200007800196B4F@suse.com> Content-Language: de-DE List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , mingo@elte.hu, Thomas Gleixner , hpa@zytor.com Cc: xen-devel , Boris Ostrovsky , sds@tycho.nsa.gov, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMTIvMTIvMTcgMTE6MzEsIEphbiBCZXVsaWNoIHdyb3RlOgo+IFVzaW5nIGp1c3QgdGhlIGxl YWYgcGFnZSB0YWJsZSBlbnRyeSBmbGFncyB3b3VsZCBjYXVzZSBhIGZhbHNlIHdhcm5pbmcKPiBp biBjYXNlIF9QQUdFX1JXIGlzIGNsZWFyIG9yIF9QQUdFX05YIGlzIHNldCBpbiBhIGhpZ2hlciBs ZXZlbCBlbnRyeS4KPiBIYW5kIHRocm91Z2ggYm90aCB0aGUgY3VycmVudCBlbnRyeSdzIGZsYWdz IGFzIHdlbGwgYXMgdGhlIGFjY3VtdWxhdGVkCj4gZWZmZWN0aXZlIHZhbHVlICh0aGUgbGF0dGVy IGFzIHBncHJvdHZhbF90IGluc3RlYWQgb2YgcGdwcm90X3QsIGFzIGl0J3MKPiBub3QgYW4gYWN0 dWFsIGVudHJ5J3MgdmFsdWUpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KPiAtLS0KPiAgYXJjaC94ODYvbW0vZHVtcF9wYWdldGFibGVzLmMgfCAg IDkyICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgMzUgZGVsZXRpb25zKC0pCj4gCj4gLS0tIDQuMTUt cmMzL2FyY2gveDg2L21tL2R1bXBfcGFnZXRhYmxlcy5jCj4gKysrIDQuMTUtcmMzLXg4Ni1kdW1w cGd0LWVmZmVjdGl2ZS1wcm90L2FyY2gveDg2L21tL2R1bXBfcGFnZXRhYmxlcy5jCj4gQEAgLTI5 LDYgKzI5LDcgQEAKPiAgc3RydWN0IHBnX3N0YXRlIHsKPiAgCWludCBsZXZlbDsKPiAgCXBncHJv dF90IGN1cnJlbnRfcHJvdDsKPiArCXBncHJvdHZhbF90IGVmZmVjdGl2ZV9wcm90Owo+ICAJdW5z aWduZWQgbG9uZyBzdGFydF9hZGRyZXNzOwo+ICAJdW5zaWduZWQgbG9uZyBjdXJyZW50X2FkZHJl c3M7Cj4gIAljb25zdCBzdHJ1Y3QgYWRkcl9tYXJrZXIgKm1hcmtlcjsKPiBAQCAtMjAyLDkgKzIw Myw5IEBAIHN0YXRpYyB1bnNpZ25lZCBsb25nIG5vcm1hbGl6ZV9hZGRyKHVuc2kKPiAgICogcHJp bnQgd2hhdCB3ZSBjb2xsZWN0ZWQgc28gZmFyLgo+ICAgKi8KPiAgc3RhdGljIHZvaWQgbm90ZV9w YWdlKHN0cnVjdCBzZXFfZmlsZSAqbSwgc3RydWN0IHBnX3N0YXRlICpzdCwKPiAtCQkgICAgICBw Z3Byb3RfdCBuZXdfcHJvdCwgaW50IGxldmVsKQo+ICsJCSAgICAgIHBncHJvdF90IG5ld19wcm90 LCBwZ3Byb3R2YWxfdCBuZXdfZWZmLCBpbnQgbGV2ZWwpCj4gIHsKPiAtCXBncHJvdHZhbF90IHBy b3QsIGN1cjsKPiArCXBncHJvdHZhbF90IHByb3QsIGN1ciwgZWZmOwo+ICAJc3RhdGljIGNvbnN0 IGNoYXIgdW5pdHNbXSA9ICJCS01HVFBFIjsKPiAgCj4gIAkvKgo+IEBAIC0yMTQsMjMgKzIxNSwy NCBAQCBzdGF0aWMgdm9pZCBub3RlX3BhZ2Uoc3RydWN0IHNlcV9maWxlICptCj4gIAkgKi8KPiAg CXByb3QgPSBwZ3Byb3RfdmFsKG5ld19wcm90KTsKPiAgCWN1ciA9IHBncHJvdF92YWwoc3QtPmN1 cnJlbnRfcHJvdCk7Cj4gKwllZmYgPSBzdC0+ZWZmZWN0aXZlX3Byb3Q7Cj4gIAo+ICAJaWYgKCFz dC0+bGV2ZWwpIHsKPiAgCQkvKiBGaXJzdCBlbnRyeSAqLwo+ICAJCXN0LT5jdXJyZW50X3Byb3Qg PSBuZXdfcHJvdDsKPiArCQlzdC0+ZWZmZWN0aXZlX3Byb3QgPSBuZXdfZWZmOwo+ICAJCXN0LT5s ZXZlbCA9IGxldmVsOwo+ICAJCXN0LT5tYXJrZXIgPSBhZGRyZXNzX21hcmtlcnM7Cj4gIAkJc3Qt PmxpbmVzID0gMDsKPiAgCQlwdF9kdW1wX3NlcV9wcmludGYobSwgc3QtPnRvX2RtZXNnLCAiLS0t WyAlcyBdLS0tXG4iLAo+ICAJCQkJICAgc3QtPm1hcmtlci0+bmFtZSk7Cj4gLQl9IGVsc2UgaWYg KHByb3QgIT0gY3VyIHx8IGxldmVsICE9IHN0LT5sZXZlbCB8fAo+ICsJfSBlbHNlIGlmIChwcm90 ICE9IGN1ciB8fCBuZXdfZWZmICE9IGVmZiB8fCBsZXZlbCAhPSBzdC0+bGV2ZWwgfHwKPiAgCQkg ICBzdC0+Y3VycmVudF9hZGRyZXNzID49IHN0LT5tYXJrZXJbMV0uc3RhcnRfYWRkcmVzcykgewo+ ICAJCWNvbnN0IGNoYXIgKnVuaXQgPSB1bml0czsKPiAgCQl1bnNpZ25lZCBsb25nIGRlbHRhOwo+ ICAJCWludCB3aWR0aCA9IHNpemVvZih1bnNpZ25lZCBsb25nKSAqIDI7Cj4gLQkJcGdwcm90dmFs X3QgcHIgPSBwZ3Byb3RfdmFsKHN0LT5jdXJyZW50X3Byb3QpOwo+ICAKPiAtCQlpZiAoc3QtPmNo ZWNrX3d4ICYmIChwciAmIF9QQUdFX1JXKSAmJiAhKHByICYgX1BBR0VfTlgpKSB7Cj4gKwkJaWYg KHN0LT5jaGVja193eCAmJiAoZWZmICYgX1BBR0VfUlcpICYmICEoZWZmICYgX1BBR0VfTlgpKSB7 Cj4gIAkJCVdBUk5fT05DRSgxLAo+ICAJCQkJICAieDg2L21tOiBGb3VuZCBpbnNlY3VyZSBXK1gg bWFwcGluZyBhdCBhZGRyZXNzICVwLyVwU1xuIiwKPiAgCQkJCSAgKHZvaWQgKilzdC0+c3RhcnRf YWRkcmVzcywKPiBAQCAtMjg0LDIxICsyODYsMzAgQEAgc3RhdGljIHZvaWQgbm90ZV9wYWdlKHN0 cnVjdCBzZXFfZmlsZSAqbQo+ICAKPiAgCQlzdC0+c3RhcnRfYWRkcmVzcyA9IHN0LT5jdXJyZW50 X2FkZHJlc3M7Cj4gIAkJc3QtPmN1cnJlbnRfcHJvdCA9IG5ld19wcm90Owo+ICsJCXN0LT5lZmZl Y3RpdmVfcHJvdCA9IG5ld19lZmY7Cj4gIAkJc3QtPmxldmVsID0gbGV2ZWw7Cj4gIAl9Cj4gIH0K PiAgCj4gLXN0YXRpYyB2b2lkIHdhbGtfcHRlX2xldmVsKHN0cnVjdCBzZXFfZmlsZSAqbSwgc3Ry dWN0IHBnX3N0YXRlICpzdCwgcG1kX3QgYWRkciwgdW5zaWduZWQgbG9uZyBQKQo+ICtzdGF0aWMg aW5saW5lIHBncHJvdHZhbF90IGVmZmVjdGl2ZV9wcm90KHBncHJvdHZhbF90IHByb3QxLCBwZ3By b3R2YWxfdCBwcm90MikKPiArewo+ICsJcmV0dXJuIChwcm90MSAmIHByb3QyICYgKF9QQUdFX1VT RVIgfCBfUEFHRV9SVykpIHwKPiArCSAgICAgICAoKHByb3QxIHwgcHJvdDIpICYgX1BBR0VfTlgp Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCB3YWxrX3B0ZV9sZXZlbChzdHJ1Y3Qgc2VxX2ZpbGUg Km0sIHN0cnVjdCBwZ19zdGF0ZSAqc3QsIHBtZF90IGFkZHIsCj4gKwkJCSAgIHBncHJvdHZhbF90 IGVmZl9pbiwgdW5zaWduZWQgbG9uZyBQKQo+ICB7Cj4gIAlpbnQgaTsKPiAgCXB0ZV90ICpzdGFy dDsKPiAtCXBncHJvdHZhbF90IHByb3Q7Cj4gKwlwZ3Byb3R2YWxfdCBwcm90LCBlZmY7Cj4gIAo+ ICAJc3RhcnQgPSAocHRlX3QgKilwbWRfcGFnZV92YWRkcihhZGRyKTsKPiAgCWZvciAoaSA9IDA7 IGkgPCBQVFJTX1BFUl9QVEU7IGkrKykgewo+ICAJCXByb3QgPSBwdGVfZmxhZ3MoKnN0YXJ0KTsK PiArCQllZmYgPSBlZmZlY3RpdmVfcHJvdChlZmZfaW4sIHByb3QpOwo+ICAJCXN0LT5jdXJyZW50 X2FkZHJlc3MgPSBub3JtYWxpemVfYWRkcihQICsgaSAqIFBURV9MRVZFTF9NVUxUKTsKPiAtCQlu b3RlX3BhZ2UobSwgc3QsIF9fcGdwcm90KHByb3QpLCA1KTsKPiArCQlub3RlX3BhZ2UobSwgc3Qs IF9fcGdwcm90KHByb3QpLCBlZmYsIDUpOwo+ICAJCXN0YXJ0Kys7Cj4gIAl9Cj4gIH0KPiBAQCAt MzM1LDQyICszNDYsNDUgQEAgc3RhdGljIGlubGluZSBib29sIGthc2FuX3BhZ2VfdGFibGUoc3Ry dQo+ICAKPiAgI2lmIFBUUlNfUEVSX1BNRCA+IDEKPiAgCj4gLXN0YXRpYyB2b2lkIHdhbGtfcG1k X2xldmVsKHN0cnVjdCBzZXFfZmlsZSAqbSwgc3RydWN0IHBnX3N0YXRlICpzdCwgcHVkX3QgYWRk ciwgdW5zaWduZWQgbG9uZyBQKQo+ICtzdGF0aWMgdm9pZCB3YWxrX3BtZF9sZXZlbChzdHJ1Y3Qg c2VxX2ZpbGUgKm0sIHN0cnVjdCBwZ19zdGF0ZSAqc3QsIHB1ZF90IGFkZHIsCj4gKwkJCSAgIHBn cHJvdHZhbF90IGVmZl9pbiwgdW5zaWduZWQgbG9uZyBQKQo+ICB7Cj4gIAlpbnQgaTsKPiAgCXBt ZF90ICpzdGFydCwgKnBtZF9zdGFydDsKPiAtCXBncHJvdHZhbF90IHByb3Q7Cj4gKwlwZ3Byb3R2 YWxfdCBwcm90LCBlZmY7Cj4gIAo+ICAJcG1kX3N0YXJ0ID0gc3RhcnQgPSAocG1kX3QgKilwdWRf cGFnZV92YWRkcihhZGRyKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBQVFJTX1BFUl9QTUQ7IGkrKykg ewo+ICAJCXN0LT5jdXJyZW50X2FkZHJlc3MgPSBub3JtYWxpemVfYWRkcihQICsgaSAqIFBNRF9M RVZFTF9NVUxUKTsKPiAgCQlpZiAoIXBtZF9ub25lKCpzdGFydCkpIHsKPiArCQkJcHJvdCA9IHBt ZF9mbGFncygqc3RhcnQpOwo+ICsJCQllZmYgPSBlZmZlY3RpdmVfcHJvdChlZmZfaW4sIHByb3Qp Owo+ICAJCQlpZiAocG1kX2xhcmdlKCpzdGFydCkgfHwgIXBtZF9wcmVzZW50KCpzdGFydCkpIHsK PiAtCQkJCXByb3QgPSBwbWRfZmxhZ3MoKnN0YXJ0KTsKPiAtCQkJCW5vdGVfcGFnZShtLCBzdCwg X19wZ3Byb3QocHJvdCksIDQpOwo+ICsJCQkJbm90ZV9wYWdlKG0sIHN0LCBfX3BncHJvdChwcm90 KSwgZWZmLCA0KTsKPiAgCQkJfSBlbHNlIGlmICgha2FzYW5fcGFnZV90YWJsZShtLCBzdCwgcG1k X3N0YXJ0KSkgewo+IC0JCQkJd2Fsa19wdGVfbGV2ZWwobSwgc3QsICpzdGFydCwKPiArCQkJCXdh bGtfcHRlX2xldmVsKG0sIHN0LCAqc3RhcnQsIGVmZiwKPiAgCQkJCQkgICAgICAgUCArIGkgKiBQ TURfTEVWRUxfTVVMVCk7Cj4gIAkJCX0KCllvdSBjYW4gZHJvcCB0aGUgYnJhY2VzIGZvciBib3Ro IGNhc2VzLiBBcHBsaWVzIHRvIHNpbWlsYXIKY29uc3RydWN0cyBiZWxvdywgdG9vLgoKV2l0aCB0 aGF0IGZpeGVkIHlvdSBjYW4gYWRkIG15OgoKUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KCgpKdWVyZ2VuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs