All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>,
	 bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] S3 fetcher: add progress handler for S3 cp command
Date: Tue, 27 Apr 2021 15:20:22 +0100	[thread overview]
Message-ID: <fcbceb5b62675b9a4ca21b080acdd7ac07b010b4.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAExyXVSe-0nJL3XTTXzG2DQ65KVBzOOyMvpFzB357P7ykU7HdA@mail.gmail.com>

On Tue, 2021-04-27 at 09:02 +0200, Przemyslaw Gorszkowski wrote:
> Hi,
> 
> This is my first patch here so forgive me if I am doing it wrong.
> 
> Regarding to my patch:
> In case of fetching source from the AWS there is no progress available. This change provides a progress by
> extracting the needed values from logs of the aws-cli cp command.

Thanks for the patches. Ideally the patches should be in the main message
rather than as attachments and the subject lines (short log) needs tweaking
to match our patch formatting guidelines.

Also, the full log messages for the changes is missing and the patches
do not have Signed-off-by: entries.

I have tweaked the patches a little to fix the above (I can't add a 
Signed-off-by line for you though) and added to master-next for testing.
The content of patches themselves look ok, it is just a question of the
commit message logs/formatting/signed off by.

Cheers,

Richard





  parent reply	other threads:[~2021-04-27 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  7:02 [PATCH] S3 fetcher: add progress handler for S3 cp command pgorszkowski
2021-04-27  7:11 ` Przemyslaw Gorszkowski
2021-04-27 14:20 ` Richard Purdie [this message]
2021-04-28  7:09   ` Przemyslaw Gorszkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcbceb5b62675b9a4ca21b080acdd7ac07b010b4.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=pgorszkowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.