All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Colin King <colin.king@canonical.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Scott Wood <oss@buserror.net>, Kevin Hao <haokexin@gmail.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
Date: Mon, 12 Sep 2016 17:21:10 +0200	[thread overview]
Message-ID: <fcc50e93-5009-496d-3251-b2d7ef820224@c-s.fr> (raw)
In-Reply-To: <20160912101224.24877-1-colin.king@canonical.com>



Le 12/09/2016 à 12:12, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/powerpc/mm/init_32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
> index 448685f..b532dd9 100644
> --- a/arch/powerpc/mm/init_32.c
> +++ b/arch/powerpc/mm/init_32.c
> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>  	if (memblock.memory.cnt > 1) {
>  #ifndef CONFIG_WII
>  		memblock_enforce_memory_limit(memblock.memory.regions[0].size);
> -		printk(KERN_WARNING "Only using first contiguous memory region");
> +		printk(KERN_WARNING "Only using first contiguous memory region\n");

This line was already 81 characters long. It is now 83.
I would suggest to use pr_warn() instead in order to shorten the line.

Christophe

>  #else
>  		wii_memory_fixups();
>  #endif
>

  reply	other threads:[~2016-09-12 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 10:12 [PATCH] powerpc/32: add missing \n at end of printk warning message Colin King
2016-09-12 15:21 ` Christophe Leroy [this message]
2016-09-13  1:25   ` Michael Ellerman
2016-09-13  1:25     ` Michael Ellerman
2016-09-12 16:34 ` Joe Perches
2016-09-12 16:49   ` Colin Ian King
2016-09-13 12:16 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcc50e93-5009-496d-3251-b2d7ef820224@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=benh@kernel.crashing.org \
    --cc=colin.king@canonical.com \
    --cc=haokexin@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oss@buserror.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.