From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C997C2BCA1 for ; Fri, 7 Jun 2019 13:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21DCA20B7C for ; Fri, 7 Jun 2019 13:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728839AbfFGNaA (ORCPT ); Fri, 7 Jun 2019 09:30:00 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:18097 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728019AbfFGNaA (ORCPT ); Fri, 7 Jun 2019 09:30:00 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C4E4424121957BF78DDF; Fri, 7 Jun 2019 21:29:57 +0800 (CST) Received: from [127.0.0.1] (10.202.227.238) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Fri, 7 Jun 2019 21:29:51 +0800 Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() To: "Martin K. Petersen" References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> CC: , , , , , , , , From: John Garry Message-ID: Date: Fri, 7 Jun 2019 14:29:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2019 14:26, Martin K. Petersen wrote: > > John, > >>> Many times in libsas, and in LLDDs which use libsas, the check for an >>> expander device is re-implemented or open coded. >> >> Applied to 5.3/scsi-queue, thanks. > > Dropped again. Breaks isci. Please fix. > Hi Martin, I assume that you mean that it breaks the isci build. I thought that I did build it. Anyway, I'll check. Thanks, john From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Garry Subject: Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander() Date: Fri, 7 Jun 2019 14:29:45 +0100 Message-ID: References: <1559751143-168560-1-git-send-email-john.garry@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Martin K. Petersen" Cc: jejb@linux.ibm.com, intel-linux-scu@intel.com, artur.paszkiewicz@intel.com, jinpu.wang@profitbricks.com, lindar_liu@usish.com, yanaijie@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.de List-Id: linux-scsi@vger.kernel.org On 07/06/2019 14:26, Martin K. Petersen wrote: > > John, > >>> Many times in libsas, and in LLDDs which use libsas, the check for an >>> expander device is re-implemented or open coded. >> >> Applied to 5.3/scsi-queue, thanks. > > Dropped again. Breaks isci. Please fix. > Hi Martin, I assume that you mean that it breaks the isci build. I thought that I did build it. Anyway, I'll check. Thanks, john