From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A5C0173 for ; Wed, 12 Jan 2022 08:56:53 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id o15so5578751lfo.11 for ; Wed, 12 Jan 2022 00:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IDxp9FEehAgEBeTvpHIK9wQEhQiO4fcWr7Sjuf0LJAY=; b=vuGmTB2J1fH0iBujlaSOiI3IPsdBAdSsSCZzotNymWfhsBtnWHFw05PrQYfIZ/YqJT gFQmQ7axOsaovrtuP7GT7uT2isBOQgR41KzhYHX3FfFyhRHZvxAAw0MTgoXMzfwZk60x Jlchm2EEQtZusZFteVLmQGKhMxGX3F7BsdIP1r2w6qWCFPEGS4BOloPATcLTPMc5rQXj gyEErB2ODq/pnrIUiOEsEoOlDRwuhVrZtRZp5CCMQZvrUt+D/RLZNFlGemI+yuYdl9I3 UFetZEoz8J7F4FATydKaD6A5q5nkM62cT+1nh5e4IRCbMSS/7tQ21CIZ5UmCI4hAMJLX 1Z3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IDxp9FEehAgEBeTvpHIK9wQEhQiO4fcWr7Sjuf0LJAY=; b=Qa/+d9K3e1Fx5zuSSCpu1ORhDpQo3mHPCjMwNuFLTZj5Ag+QI00YKcpEqfoQ61hwTY Smd83jvh2zsKuHG3xQfvp9Cl5l4gbb/GubsHsxVhXoqECw4o+mYxRRXjA2zBqLaenm1p h3JUiUDN2zl3mr8jNhUYpll1dX+W/0sQK3gPzKRaEUuEyD84Lag94HOX9cUX2lXBS9Y+ HlVeK3Q0g9YwOZlufAKa0s57rlV2SHIVkau1EcfcyUzx5k4ncREaz+32TdDzZeOKA5xU bv5o0NEDGurS4inNigCfqC6wrq+inZW5ky3Axvj9IDWRV4Ahg2+ThsEfWw46uCadnT83 Mnrg== X-Gm-Message-State: AOAM530YzgT/OJiwy6nI7SUmmtoUNftO1E6UsdHYyP+9jn0fqaTEakzZ x12ZnXZEAzOdCYmq0KfXfNJlsw== X-Google-Smtp-Source: ABdhPJwlZ3tdMoNqbxzIWmOER1wBJcpslBtRJoH2RKcV8qK3clqLQmuNhQ9NYHuCOS4FCZRSiALWMA== X-Received: by 2002:a19:750b:: with SMTP id y11mr6135004lfe.265.1641977811417; Wed, 12 Jan 2022 00:56:51 -0800 (PST) Received: from [192.168.112.17] (nikaet.starlink.ru. [94.141.168.29]) by smtp.gmail.com with ESMTPSA id q14sm1581984lfu.74.2022.01.12.00.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 00:56:51 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 11:56:50 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 3/3 v2] arm64: dts: renesas: add MOST device Content-Language: en-US To: Geert Uytterhoeven Cc: Magnus Damm , Rob Herring , Greg Kroah-Hartman , Christian Gromm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-staging@lists.linux.dev, Linux Kernel Mailing List References: <20211226082530.2245198-4-nikita.yoush@cogentembedded.com> <20211226153349.2296024-1-nikita.yoush@cogentembedded.com> From: Nikita Yushchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> + reg = <0 0xec520000 0 0x800>; >> + interrupts = , >> + , >> + , >> + , >> + ; > > What is the purpose of the various interrupts? > Perhaps you need interrupt-names? > The driver seems to use only the first two, which is strange, as > the second and third interrupt handle different channels. Maybe Christian Gromm (the original driver author) can comment here? As far as I understand: - interrupts are: mlb, ahb0, ahb1, ch0rx, ch1rx - of those, the first 3 are from dim2 itself, and the last two are from renesas-specific logic around dim2 - in the interrupt assignment tables for gen3 SoCs, renesas documents all 5 interrupts, however in the mlb section, renesas mentions only mlb, ahb0 and ch0rx interrupts - moreover, renesas explicitly denies access dim2 registers responsible for channels 32..63 - which renders ahb1 interrupt useless; and renesas does not document any registers related to "async rx response" on channels 32..63 - which renders chrx1 interrupt useless - anyway, dim2 driver registers only 32 channels (for all use cases, not only for renesas), and thus uses only ahb0 interrupt - dim2 driver does not implement renesas-specific processing logic and thus does not use ch0rx interrupt I'm not sure how to proceed here. Is it better to define only two interrupts (mlb, ahb0) in device trees? Regarding 'interrupt-names' - dim2 driver currently uses platform_get_irq() and thus depends on numeric positions (mlb interrupt at index 0 and ahb0 interrupt at index 1). I'm not sure about current use cases of the driver other than with rcar-gen3, and if it is ok to use of_get_irq_byname() instead. And without using of_get_irq_byname(), interrupt-names looks somewhat useless. > But without any DT binding documentation > for this hardware block, this is hard to validate, and not yet ready for > upstream integration. Christian, are you going to provide DT binding documentation for dim2? Nikita