From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 056AC2F21 for ; Thu, 10 Feb 2022 11:56:07 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JvZT42pQKzcckG; Thu, 10 Feb 2022 19:36:24 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 19:37:24 +0800 Subject: Re: [PATCH 01/27] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig CC: Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , , , , , , , Jason Gunthorpe , Chaitanya Kulkarni , Muchun Song , Andrew Morton , Dan Williams References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-2-hch@lst.de> From: Miaohe Lin Message-ID: Date: Thu, 10 Feb 2022 19:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20220210072828.2930359-2-hch@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected On 2022/2/10 15:28, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Muchun Song > Reviewed-by: Dan Williams > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 6aa5f0c2d11fda..5f04a0709e436e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > } > break; > case MEMORY_DEVICE_FS_DAX: > - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || > - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > LGTM. Thanks. Reviewed-by: Miaohe Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35F30C433F5 for ; Fri, 11 Feb 2022 07:48:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3579010E9F6; Fri, 11 Feb 2022 07:48:00 +0000 (UTC) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id E25D410E811; Thu, 10 Feb 2022 11:37:29 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JvZT42pQKzcckG; Thu, 10 Feb 2022 19:36:24 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 19:37:24 +0800 Subject: Re: [PATCH 01/27] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages To: Christoph Hellwig References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-2-hch@lst.de> From: Miaohe Lin Message-ID: Date: Thu, 10 Feb 2022 19:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220210072828.2930359-2-hch@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 11 Feb 2022 07:47:51 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Chaitanya Kulkarni , Alistair Popple , amd-gfx@lists.freedesktop.org, Jason Gunthorpe , Ben Skeggs , Jason Gunthorpe , Ralph Campbell , Muchun Song , Dan Williams , Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2022/2/10 15:28, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Muchun Song > Reviewed-by: Dan Williams > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 6aa5f0c2d11fda..5f04a0709e436e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > } > break; > case MEMORY_DEVICE_FS_DAX: > - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || > - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > LGTM. Thanks. Reviewed-by: Miaohe Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8CB5C433EF for ; Fri, 11 Feb 2022 03:28:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E3E210E9F5; Fri, 11 Feb 2022 03:28:15 +0000 (UTC) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id E25D410E811; Thu, 10 Feb 2022 11:37:29 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JvZT42pQKzcckG; Thu, 10 Feb 2022 19:36:24 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Feb 2022 19:37:24 +0800 To: Christoph Hellwig References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-2-hch@lst.de> From: Miaohe Lin Message-ID: Date: Thu, 10 Feb 2022 19:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220210072828.2930359-2-hch@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 11 Feb 2022 03:28:13 +0000 Subject: Re: [Nouveau] [PATCH 01/27] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Chaitanya Kulkarni , Alistair Popple , amd-gfx@lists.freedesktop.org, Jason Gunthorpe , Ben Skeggs , Jason Gunthorpe , Ralph Campbell , Muchun Song , Dan Williams , Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 2022/2/10 15:28, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Muchun Song > Reviewed-by: Dan Williams > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 6aa5f0c2d11fda..5f04a0709e436e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > } > break; > case MEMORY_DEVICE_FS_DAX: > - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || > - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > LGTM. Thanks. Reviewed-by: Miaohe Lin