From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:9906 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726899AbhAMMQT (ORCPT ); Wed, 13 Jan 2021 07:16:19 -0500 Subject: Re: [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files References: <20210112132054.49756-1-frankja@linux.ibm.com> <20210112132054.49756-5-frankja@linux.ibm.com> From: Janosch Frank Message-ID: Date: Wed, 13 Jan 2021 13:15:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Thomas Huth , kvm@vger.kernel.org Cc: david@redhat.com, borntraeger@de.ibm.com, imbrenda@linux.ibm.com, cohuck@redhat.com, linux-s390@vger.kernel.org On 1/13/21 1:04 PM, Thomas Huth wrote: > On 12/01/2021 14.20, Janosch Frank wrote: >> I've added too much to cstart64.S which is not start related >> already. Now that I want to add even more code it's time to split >> cstart64.S. lib.S has functions that are used in tests. macros.S >> contains macros which are used in cstart64.S and lib.S >> >> Signed-off-by: Janosch Frank >> Acked-by: Claudio Imbrenda >> --- >> s390x/Makefile | 6 +-- >> s390x/cstart64.S | 119 ++--------------------------------------------- >> s390x/lib.S | 65 ++++++++++++++++++++++++++ > > lib.S is a very generic name ... maybe rather use cpuasm.S or something similar? instr.S ? Or maybe entry.S to make it similar to the kernel? > > Anway, > Acked-by: Thomas Huth > Thanks