From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D54C433ED for ; Wed, 21 Apr 2021 08:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E224E61437 for ; Wed, 21 Apr 2021 08:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237345AbhDUIoQ (ORCPT ); Wed, 21 Apr 2021 04:44:16 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:9452 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235469AbhDUIoP (ORCPT ); Wed, 21 Apr 2021 04:44:15 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FQDbw5cNtz9v00K; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id i3lotJLr58Wp; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FQDbw4kkxz9v00C; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AD2DF8B815; Wed, 21 Apr 2021 10:43:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id C4C5ukKWYpUh; Wed, 21 Apr 2021 10:43:41 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D85998B770; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Subject: Re: mmu.c:undefined reference to `patch__hash_page_A0' To: Randy Dunlap , kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Michael Ellerman , PowerPC References: <202102271820.WlZCxtzY-lkp@intel.com> <06227600-c5c5-3da7-a495-ae0b0849b62d@infradead.org> <0a301d17-136c-df65-17cc-3c9ddbe06de8@infradead.org> From: Christophe Leroy Message-ID: Date: Wed, 21 Apr 2021 10:43:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <0a301d17-136c-df65-17cc-3c9ddbe06de8@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/04/2021 à 19:15, Randy Dunlap a écrit : > On 4/18/21 3:43 AM, Christophe Leroy wrote: >> >> >> Le 18/04/2021 à 02:02, Randy Dunlap a écrit : >>> HI-- >>> >>> I no longer see this build error. >> >> Fixed by https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f98a38b630691574e16 >> >>> However: >>> >>> On 2/27/21 2:24 AM, kernel test robot wrote: >>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>>> head:   3fb6d0e00efc958d01c2f109c8453033a2d96796 >>>> commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected >>>> date:   4 weeks ago >>>> config: powerpc64-randconfig-r013-20210227 (attached as .config) >>> >>> ktr/lkp, this is a PPC32 .config file that is attached, not PPC64. >>> >>> Also: >>> >>>> compiler: powerpc-linux-gcc (GCC) 9.3.0 >> >> ... >> >>> >>> I do see this build error: >>> >>> powerpc-linux-ld: arch/powerpc/boot/wrapper.a(decompress.o): in function `partial_decompress': >>> decompress.c:(.text+0x1f0): undefined reference to `__decompress' >>> >>> when either >>> CONFIG_KERNEL_LZO=y >>> or >>> CONFIG_KERNEL_LZMA=y >>> >>> but the build succeeds when either >>> CONFIG_KERNEL_GZIP=y >>> or >>> CONFIG_KERNEL_XZ=y >>> >>> I guess that is due to arch/powerpc/boot/decompress.c doing this: >>> >>> #ifdef CONFIG_KERNEL_GZIP >>> #    include "decompress_inflate.c" >>> #endif >>> >>> #ifdef CONFIG_KERNEL_XZ >>> #    include "xz_config.h" >>> #    include "../../../lib/decompress_unxz.c" >>> #endif >>> >>> >>> It would be nice to require one of KERNEL_GZIP or KERNEL_XZ >>> to be set/enabled (maybe unless a uImage is being built?). >> >> >> Can you test by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a74fce4dfc9fa32da6ce3470bbedcecf795de1ec.1591189069.git.christophe.leroy@csgroup.eu/ ? > > Hi Christophe, > > I get build errors for both LZO and LZMA: > Can you check with the following changes on top of my patch: diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c index a8dbde4b32d4..f06f925385c0 100644 --- a/lib/decompress_unlzo.c +++ b/lib/decompress_unlzo.c @@ -23,13 +23,15 @@ #include #endif -#include #ifdef __KERNEL__ #include +#endif +#include +#ifdef __KERNEL__ #include +#include #endif -#include #include static const unsigned char lzop_magic[] = { Thanks Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED78C433B4 for ; Wed, 21 Apr 2021 08:44:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD33F613D7 for ; Wed, 21 Apr 2021 08:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD33F613D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FQDcS1pPzz3bp3 for ; Wed, 21 Apr 2021 18:44:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FQDc24Hwmz2xg6 for ; Wed, 21 Apr 2021 18:43:44 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FQDbw5cNtz9v00K; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id i3lotJLr58Wp; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FQDbw4kkxz9v00C; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AD2DF8B815; Wed, 21 Apr 2021 10:43:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id C4C5ukKWYpUh; Wed, 21 Apr 2021 10:43:41 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D85998B770; Wed, 21 Apr 2021 10:43:40 +0200 (CEST) Subject: Re: mmu.c:undefined reference to `patch__hash_page_A0' To: Randy Dunlap , kernel test robot References: <202102271820.WlZCxtzY-lkp@intel.com> <06227600-c5c5-3da7-a495-ae0b0849b62d@infradead.org> <0a301d17-136c-df65-17cc-3c9ddbe06de8@infradead.org> From: Christophe Leroy Message-ID: Date: Wed, 21 Apr 2021 10:43:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <0a301d17-136c-df65-17cc-3c9ddbe06de8@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: PowerPC , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 18/04/2021 à 19:15, Randy Dunlap a écrit : > On 4/18/21 3:43 AM, Christophe Leroy wrote: >> >> >> Le 18/04/2021 à 02:02, Randy Dunlap a écrit : >>> HI-- >>> >>> I no longer see this build error. >> >> Fixed by https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f98a38b630691574e16 >> >>> However: >>> >>> On 2/27/21 2:24 AM, kernel test robot wrote: >>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>>> head:   3fb6d0e00efc958d01c2f109c8453033a2d96796 >>>> commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected >>>> date:   4 weeks ago >>>> config: powerpc64-randconfig-r013-20210227 (attached as .config) >>> >>> ktr/lkp, this is a PPC32 .config file that is attached, not PPC64. >>> >>> Also: >>> >>>> compiler: powerpc-linux-gcc (GCC) 9.3.0 >> >> ... >> >>> >>> I do see this build error: >>> >>> powerpc-linux-ld: arch/powerpc/boot/wrapper.a(decompress.o): in function `partial_decompress': >>> decompress.c:(.text+0x1f0): undefined reference to `__decompress' >>> >>> when either >>> CONFIG_KERNEL_LZO=y >>> or >>> CONFIG_KERNEL_LZMA=y >>> >>> but the build succeeds when either >>> CONFIG_KERNEL_GZIP=y >>> or >>> CONFIG_KERNEL_XZ=y >>> >>> I guess that is due to arch/powerpc/boot/decompress.c doing this: >>> >>> #ifdef CONFIG_KERNEL_GZIP >>> #    include "decompress_inflate.c" >>> #endif >>> >>> #ifdef CONFIG_KERNEL_XZ >>> #    include "xz_config.h" >>> #    include "../../../lib/decompress_unxz.c" >>> #endif >>> >>> >>> It would be nice to require one of KERNEL_GZIP or KERNEL_XZ >>> to be set/enabled (maybe unless a uImage is being built?). >> >> >> Can you test by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a74fce4dfc9fa32da6ce3470bbedcecf795de1ec.1591189069.git.christophe.leroy@csgroup.eu/ ? > > Hi Christophe, > > I get build errors for both LZO and LZMA: > Can you check with the following changes on top of my patch: diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c index a8dbde4b32d4..f06f925385c0 100644 --- a/lib/decompress_unlzo.c +++ b/lib/decompress_unlzo.c @@ -23,13 +23,15 @@ #include #endif -#include #ifdef __KERNEL__ #include +#endif +#include +#ifdef __KERNEL__ #include +#include #endif -#include #include static const unsigned char lzop_magic[] = { Thanks Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3596297107211944740==" MIME-Version: 1.0 From: Christophe Leroy To: kbuild-all@lists.01.org Subject: Re: mmu.c:undefined reference to `patch__hash_page_A0' Date: Wed, 21 Apr 2021 10:43:40 +0200 Message-ID: In-Reply-To: <0a301d17-136c-df65-17cc-3c9ddbe06de8@infradead.org> List-Id: --===============3596297107211944740== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Le 18/04/2021 =C3=A0 19:15, Randy Dunlap a =C3=A9crit=C2=A0: > On 4/18/21 3:43 AM, Christophe Leroy wrote: >> >> >> Le 18/04/2021 =C3=A0 02:02, Randy Dunlap a =C3=A9crit=C2=A0: >>> HI-- >>> >>> I no longer see this build error. >> >> Fixed by https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f= 98a38b630691574e16 >> >>> However: >>> >>> On 2/27/21 2:24 AM, kernel test robot wrote: >>>> tree:=C2=A0=C2=A0 https://git.kernel.org/pub/scm/linux/kernel/git/torv= alds/linux.git master >>>> head:=C2=A0=C2=A0 3fb6d0e00efc958d01c2f109c8453033a2d96796 >>>> commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only bui= ld hash code when CONFIG_PPC_BOOK3S_604 is selected >>>> date:=C2=A0=C2=A0 4 weeks ago >>>> config: powerpc64-randconfig-r013-20210227 (attached as .config) >>> >>> ktr/lkp, this is a PPC32 .config file that is attached, not PPC64. >>> >>> Also: >>> >>>> compiler: powerpc-linux-gcc (GCC) 9.3.0 >> >> ... >> >>> >>> I do see this build error: >>> >>> powerpc-linux-ld: arch/powerpc/boot/wrapper.a(decompress.o): in functio= n `partial_decompress': >>> decompress.c:(.text+0x1f0): undefined reference to `__decompress' >>> >>> when either >>> CONFIG_KERNEL_LZO=3Dy >>> or >>> CONFIG_KERNEL_LZMA=3Dy >>> >>> but the build succeeds when either >>> CONFIG_KERNEL_GZIP=3Dy >>> or >>> CONFIG_KERNEL_XZ=3Dy >>> >>> I guess that is due to arch/powerpc/boot/decompress.c doing this: >>> >>> #ifdef CONFIG_KERNEL_GZIP >>> #=C2=A0=C2=A0=C2=A0 include "decompress_inflate.c" >>> #endif >>> >>> #ifdef CONFIG_KERNEL_XZ >>> #=C2=A0=C2=A0=C2=A0 include "xz_config.h" >>> #=C2=A0=C2=A0=C2=A0 include "../../../lib/decompress_unxz.c" >>> #endif >>> >>> >>> It would be nice to require one of KERNEL_GZIP or KERNEL_XZ >>> to be set/enabled (maybe unless a uImage is being built?). >> >> >> Can you test by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/= a74fce4dfc9fa32da6ce3470bbedcecf795de1ec.1591189069.git.christophe.leroy(a)= csgroup.eu/ ? > = > Hi Christophe, > = > I get build errors for both LZO and LZMA: > = Can you check with the following changes on top of my patch: diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c index a8dbde4b32d4..f06f925385c0 100644 --- a/lib/decompress_unlzo.c +++ b/lib/decompress_unlzo.c @@ -23,13 +23,15 @@ #include #endif -#include #ifdef __KERNEL__ #include +#endif +#include +#ifdef __KERNEL__ #include +#include #endif -#include #include static const unsigned char lzop_magic[] =3D { Thanks Christophe --===============3596297107211944740==--