From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH v3 1/2] net/failsafe: fix removed sub-device cleanup Date: Tue, 22 May 2018 14:59:44 +0100 Message-ID: References: <1526932084-1120-1-git-send-email-matan@mellanox.com> <1526992727-10459-1-git-send-email-matan@mellanox.com> <20180522131459.3nvrgvkjbv6tlv52@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, Ophir Munk , stable@dpdk.org To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Matan Azrad Return-path: In-Reply-To: <20180522131459.3nvrgvkjbv6tlv52@bidouze.vm.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/22/2018 2:14 PM, Gaëtan Rivet wrote: > On Tue, May 22, 2018 at 12:38:46PM +0000, Matan Azrad wrote: >> The fail-safe PMD registers to RMV event for each removable sub-device >> port in order to cleanup the sub-device resources and switch the Tx >> sub-device directly when it is plugged-out. >> >> During removal time, the fail-safe PMD stops and closes the sub-device >> but it doesn't unregister the LSC and RMV callbacks of the sub-device >> port. >> >> It can lead the callbacks to be called for a port which is no more >> associated with the fail-safe sub-device, because there is not a >> guarantee that a sub-device gets the same port ID for each plug-in >> process. This port, for example, may belong to another sub-device of a >> different fail-safe device. >> >> Unregister the LSC and RMV callbacks for sub-devices which are not >> used. >> >> Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") >> Cc: stable@dpdk.org >> >> Signed-off-by: Matan Azrad > > Acked-by: Gaetan Rivet Series applied to dpdk-next-net/master, thanks.