From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8291CC433DF for ; Mon, 18 May 2020 09:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69F2920709 for ; Mon, 18 May 2020 09:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgERJsJ (ORCPT ); Mon, 18 May 2020 05:48:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:55876 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726040AbgERJsI (ORCPT ); Mon, 18 May 2020 05:48:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 655B2AA6F; Mon, 18 May 2020 09:48:10 +0000 (UTC) Subject: Re: [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700 To: =?UTF-8?Q?Andr=c3=a9_Przywara?= , Manivannan Sadhasivam , Amit Tomer Cc: Rob Herring , cristian.ciocaltea@gmail.com, linux-arm-kernel , linux-actions@lists.infradead.org, devicetree@vger.kernel.org References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> <1589472657-3930-9-git-send-email-amittomer25@gmail.com> <2cd3cdaf-826e-9d12-9fd4-9f7e2a517ecd@arm.com> <20200518061755.GA25113@mani> <29500523-0fe4-955d-57de-d4b9f11cedb8@arm.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Mon, 18 May 2020 11:48:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <29500523-0fe4-955d-57de-d4b9f11cedb8@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Am 18.05.20 um 10:29 schrieb André Przywara: > On 18/05/2020 07:17, Manivannan Sadhasivam wrote: >> I don't know if the DT fallback is discouraged or not. > > I don't know if there is an "official" statement on this, but last thing > I heard, adding SoC specific compatibles to generic fallback strings was > encouraged. Hence my proposal, to add one. I believe the official guidance would be to never be too generic in the first place. I.e., prefer s500 (oldest model tested) over generic owl. But now that we have it, prepending a more specific one (rather than replacing it) is the only way to go. In that case the binding needs to be changed to allow both the old and the recommended new variant, as André points out. Please add a comment to help bindings readers choose which of the two to adopt then. Amit, next time please quote errors you see right away, that could've spared a handful of messages discussing about the driver when it was in fact just a bindings issue (which you had been asked to fix by André). Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21205C433E0 for ; Mon, 18 May 2020 09:48:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA2C920657 for ; Mon, 18 May 2020 09:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Olm5SN8C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA2C920657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5tR2s3to0MaqtrW7gds1xYaW2YAbG9lPNAwSlyCz1wM=; b=Olm5SN8CVGFrGrVsa18eypGO9 +f+8L+nH0UoaiUtGzo0iY0/TrSZLhAFst6WeNEOgF6xYS8bPcUKp+GARF/h3dhP2AsAZsxvio7rw4 xVrDfHWMenQE/Tm3HGZnULlOlbLn8KabCcUpEn64ZIj526nwIvyh2aFOD2q/pDOc/BVfIh+s2pFzk 4uIA0EhOmPOU9iswYboamWUv41q4uHB9IN0FBuB3m0FPXqWI9BveYOBgiiG5w3PAMqzNVT1mAHT9o e+pqWHO8Prl8o9jwtBS/5VEIQfToaQVtj/h2fC/tJS8wV93ceqwxFLJNfc8sa/zO4lYO5Ex1yAY7Y 8UpzJJpQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jacNb-0005nG-El; Mon, 18 May 2020 09:48:15 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jacNX-0005mH-GB; Mon, 18 May 2020 09:48:13 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 655B2AA6F; Mon, 18 May 2020 09:48:10 +0000 (UTC) Subject: Re: [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700 To: =?UTF-8?Q?Andr=c3=a9_Przywara?= , Manivannan Sadhasivam , Amit Tomer References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> <1589472657-3930-9-git-send-email-amittomer25@gmail.com> <2cd3cdaf-826e-9d12-9fd4-9f7e2a517ecd@arm.com> <20200518061755.GA25113@mani> <29500523-0fe4-955d-57de-d4b9f11cedb8@arm.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Mon, 18 May 2020 11:48:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <29500523-0fe4-955d-57de-d4b9f11cedb8@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_024811_687753_E09E4913 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , linux-actions@lists.infradead.org, linux-arm-kernel , cristian.ciocaltea@gmail.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpBbSAxOC4wNS4yMCB1bSAxMDoyOSBzY2hyaWViIEFuZHLDqSBQcnp5d2FyYToKPiBPbiAx OC8wNS8yMDIwIDA3OjE3LCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4+IEkgZG9uJ3Qg a25vdyBpZiB0aGUgRFQgZmFsbGJhY2sgaXMgZGlzY291cmFnZWQgb3Igbm90Lgo+IAo+IEkgZG9u J3Qga25vdyBpZiB0aGVyZSBpcyBhbiAib2ZmaWNpYWwiIHN0YXRlbWVudCBvbiB0aGlzLCBidXQg bGFzdCB0aGluZwo+IEkgaGVhcmQsIGFkZGluZyBTb0Mgc3BlY2lmaWMgY29tcGF0aWJsZXMgdG8g Z2VuZXJpYyBmYWxsYmFjayBzdHJpbmdzIHdhcwo+IGVuY291cmFnZWQuIEhlbmNlIG15IHByb3Bv c2FsLCB0byBhZGQgb25lLgoKSSBiZWxpZXZlIHRoZSBvZmZpY2lhbCBndWlkYW5jZSB3b3VsZCBi ZSB0byBuZXZlciBiZSB0b28gZ2VuZXJpYyBpbiB0aGUgCmZpcnN0IHBsYWNlLiBJLmUuLCBwcmVm ZXIgczUwMCAob2xkZXN0IG1vZGVsIHRlc3RlZCkgb3ZlciBnZW5lcmljIG93bC4KCkJ1dCBub3cg dGhhdCB3ZSBoYXZlIGl0LCBwcmVwZW5kaW5nIGEgbW9yZSBzcGVjaWZpYyBvbmUgKHJhdGhlciB0 aGFuIApyZXBsYWNpbmcgaXQpIGlzIHRoZSBvbmx5IHdheSB0byBnby4gSW4gdGhhdCBjYXNlIHRo ZSBiaW5kaW5nIG5lZWRzIHRvIApiZSBjaGFuZ2VkIHRvIGFsbG93IGJvdGggdGhlIG9sZCBhbmQg dGhlIHJlY29tbWVuZGVkIG5ldyB2YXJpYW50LCBhcyAKQW5kcsOpIHBvaW50cyBvdXQuIFBsZWFz ZSBhZGQgYSBjb21tZW50IHRvIGhlbHAgYmluZGluZ3MgcmVhZGVycyBjaG9vc2UgCndoaWNoIG9m IHRoZSB0d28gdG8gYWRvcHQgdGhlbi4KCkFtaXQsIG5leHQgdGltZSBwbGVhc2UgcXVvdGUgZXJy b3JzIHlvdSBzZWUgcmlnaHQgYXdheSwgdGhhdCBjb3VsZCd2ZSAKc3BhcmVkIGEgaGFuZGZ1bCBv ZiBtZXNzYWdlcyBkaXNjdXNzaW5nIGFib3V0IHRoZSBkcml2ZXIgd2hlbiBpdCB3YXMgaW4gCmZh Y3QganVzdCBhIGJpbmRpbmdzIGlzc3VlICh3aGljaCB5b3UgaGFkIGJlZW4gYXNrZWQgdG8gZml4 IGJ5IEFuZHLDqSkuCgpSZWdhcmRzLApBbmRyZWFzCgotLSAKU1VTRSBTb2Z0d2FyZSBTb2x1dGlv bnMgR2VybWFueSBHbWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQpH RjogRmVsaXggSW1lbmTDtnJmZmVyCkhSQiAzNjgwOSAoQUcgTsO8cm5iZXJnKQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=