From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 946F0C388F9 for ; Wed, 11 Nov 2020 17:32:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E54C6205ED for ; Wed, 11 Nov 2020 17:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="faVKNxWR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E54C6205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.25133.52723 (Exim 4.92) (envelope-from ) id 1kctyG-0005NM-JW; Wed, 11 Nov 2020 17:31:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 25133.52723; Wed, 11 Nov 2020 17:31:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kctyG-0005NF-Fm; Wed, 11 Nov 2020 17:31:48 +0000 Received: by outflank-mailman (input) for mailman id 25133; Wed, 11 Nov 2020 17:31:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kctyE-0005NA-Vw for xen-devel@lists.xenproject.org; Wed, 11 Nov 2020 17:31:47 +0000 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 96299019-09b2-466d-9a3c-1ed40d640f09; Wed, 11 Nov 2020 17:31:45 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id 11so2998969ljf.2 for ; Wed, 11 Nov 2020 09:31:45 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id r12sm288509lfc.80.2020.11.11.09.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 09:31:43 -0800 (PST) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kctyE-0005NA-Vw for xen-devel@lists.xenproject.org; Wed, 11 Nov 2020 17:31:47 +0000 X-Inumbo-ID: 96299019-09b2-466d-9a3c-1ed40d640f09 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 96299019-09b2-466d-9a3c-1ed40d640f09; Wed, 11 Nov 2020 17:31:45 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id 11so2998969ljf.2 for ; Wed, 11 Nov 2020 09:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9lJcUz8QfXwF8vJaUpaGnd9A5ljqxkWw2E3euLf1b2E=; b=faVKNxWR3DZbJ6ORB0FoEGO2o7fyd6xSnWLASggYQdI90I3vCsPLm2MqySvFEfk/JE sY9AOJGdbaqlnTNNRaUOaR3NM0ZRbh/4CJndsSY/Q2NIyXys4ci4AjiTEyXrQDeZaT26 X1gZlJ9gLkyn7/BNWvPmGtdjFBskMXnKrxxnJjIekXkXdj2lLswSP9MP96wM8ha5Ui8a wmzpPj0A14TRgrNAMnLHzUEVFDIKIfjNv2NIgmyuzgZ3mGh5mRpu5KH7VeG/gMCZm2Gm 4Fxb9TuX08u7G6UXUL2ZT+1ziMHU83tz5ryy2QfK0bP9OTlNA/MTHvHQSSAfT1T4QBMj G9KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9lJcUz8QfXwF8vJaUpaGnd9A5ljqxkWw2E3euLf1b2E=; b=SHNy/u5bouKKucPJwotmMq8oyJOjSIxl5nr/V1nj7hlDCa32Oh/KqF1gzkUgpETsr5 4xyRP8YGzM/GZ/upFfct4VYL5bXR6ppcT6wBUojnFz1KW0knOCYSowRM8luKuKIZehEp Yr7HKQ8eA7QLMrqh9hSOFMTdR1o6IqjLXL3rq6Wyxe73238A20JncYnCXOVSFccYi3Kf 05xfQSpb2eAQYIDNgNT0Sx8NM5OsaM9DiCH25wwRiboUax/NVAZx13Va8t2GCcqRFdQy qN3vhpFLIOFd5nMs6pUwbLvDidGhaO8ywVYquNoEVzS03OHKs5WduLkQRXhK9de4yfEJ F2mQ== X-Gm-Message-State: AOAM531n5f58urQW/qWCjvr+zc6n7QeUq9fNCpDMs5irZV3yHsyMO/66 7w/EVCdUUOt8kN5Kx40Uwm65aDUw83LDzw== X-Google-Smtp-Source: ABdhPJwqsr5xF26n/tPUD6Z4pRNeNivTmqj6ig/i4bu+22DhlBd1aMreC2lH1lbgk57ruKYkPvxlGQ== X-Received: by 2002:a2e:8e3b:: with SMTP id r27mr8614266ljk.466.1605115904037; Wed, 11 Nov 2020 09:31:44 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id r12sm288509lfc.80.2020.11.11.09.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 09:31:43 -0800 (PST) Subject: Re: [PATCH V2 17/23] xen/ioreq: Introduce domain_has_ioreq_server() To: Jan Beulich Cc: 'Oleksandr Tyshchenko' , 'Stefano Stabellini' , 'Julien Grall' , 'Volodymyr Babchuk' , 'Andrew Cooper' , 'George Dunlap' , 'Ian Jackson' , 'Wei Liu' , 'Julien Grall' , paul@xen.org, xen-devel@lists.xenproject.org References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-18-git-send-email-olekstysh@gmail.com> <004e01d6a6cf$09cd9f40$1d68ddc0$@xen.org> <700a643e-641e-c243-cb2d-7ad8b5a9b8ad@gmail.com> <0ab03a33-5056-0de8-e5f7-b54a661a09c5@suse.com> From: Oleksandr Message-ID: Date: Wed, 11 Nov 2020 19:31:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0ab03a33-5056-0de8-e5f7-b54a661a09c5@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 11.11.20 15:27, Jan Beulich wrote: Hi Jan. > >>>>>> } >>>>>> >>>>>> #define GET_IOREQ_SERVER(d, id) \ >>>>>> diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h >>>>>> index 7b03ab5..0679fef 100644 >>>>>> --- a/xen/include/xen/ioreq.h >>>>>> +++ b/xen/include/xen/ioreq.h >>>>>> @@ -55,6 +55,20 @@ struct ioreq_server { >>>>>> uint8_t bufioreq_handling; >>>>>> }; >>>>>> >>>>>> +#ifdef CONFIG_IOREQ_SERVER >>>>>> +static inline bool domain_has_ioreq_server(const struct domain *d) >>>>>> +{ >>>>>> + ASSERT((current->domain == d) || atomic_read(&d->pause_count)); >>>>>> + >>>>> This seems like an odd place to put such an assertion. >>>> I might miss something or interpreted incorrectly but these asserts are >>>> the result of how I understood the review comment on previous version [1]. >>>> >>>> I will copy a comment here for the convenience: >>>> "This is safe only when d == current->domain and it's not paused, >>>> or when they're distinct and d is paused. Otherwise the result is >>>> stale before the caller can inspect it. This wants documenting by >>>> at least a comment, but perhaps better by suitable ASSERT()s." >>> The way his reply was worded, I think Paul was wondering about the >>> place where you put the assertion, not what you actually assert. >> Shall I put the assertion at the call sites of this helper instead? > Since Paul raised the question, I expect this is a question to him > rather than me? Yes, it was primarily a question to Paul, but I wanted to hear your opinion as well. Sorry for the confusion. -- Regards, Oleksandr Tyshchenko