From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 17/17] ARM: dts: Add missing hwmod related properties for dra7 Date: Mon, 28 Aug 2017 16:52:53 -0500 Message-ID: References: <20170828211918.11573-1-tony@atomide.com> <20170828211918.11573-18-tony@atomide.com> <8c0ecbf6-26fb-1998-6bb5-0a74d9daa2ab@ti.com> <20170828213753.GP6008@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170828213753.GP6008-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?Q?Beno=c3=aet_Cousson?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J . Wysocki" , Tero Kristo List-Id: devicetree@vger.kernel.org On 08/28/2017 04:37 PM, Tony Lindgren wrote: > * Nishanth Menon [170828 14:35]: >> On 08/28/2017 04:19 PM, Tony Lindgren wrote: >>> On dra7 we're missing the smartreflex and hdq nodes with their >>> related "ti,hwmods" property that the SoC interconnect code needs. >>> >>> Note that this will only show up as a bug with "doesn't have >>> mpu register target base" boot errors when the legacy platform >>> data is removed. >>> >>> Note that the related driver also needs to be updated to probe >>> using device tree and get the platform data passed to it using >>> auxdata with arch/arm/mach-omap2/pdata-quirks.c. >>> >>> Let's also update the related binding documentation while at it. > ... >>> @@ -1489,6 +1497,18 @@ >>> }; >>> }; >>> + smartreflex_core: smartreflex4a0dd000 { >>> + compatible = "ti,dra7-smartreflex-core"; >>> + ti,hwmods = "smartreflex_core"; >>> + reg = <0x4a0dd000 0x80>; >>> + }; >>> + >>> + smartreflex_mpu: smartreflex@4a0d9000 { >>> + compatible = "ti,dra7-smartreflex-mpu"; >>> + ti,hwmods = "smartreflex_mpu"; >>> + reg = <0x4a0d9000 0x80>; >>> + }; >> >> >> Have you checked TRM for these? >> http://www.ti.com/lit/ug/sprui30d/sprui30d.pdf >> >> These are disabled on the SoC and marked as reserved. > > Then why do we still have legacy hwmod data for them? We should probably drop them - probably legacy of autogeneration at some point in history. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html