From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Xiaoyao Li <xiaoyao.li@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] KVM: MMU: Add support for PKS emulation
Date: Thu, 29 Jul 2021 19:45:27 +0200 [thread overview]
Message-ID: <fd1b39b1-ce99-3626-b502-eb1324001163@redhat.com> (raw)
In-Reply-To: <YQLkczVfCsFp4IxW@google.com>
On 29/07/21 19:25, Sean Christopherson wrote:
>> - unsigned int cr4_pke:1;
>> + unsigned int cr4_pkr:1;
> Smushing these together will not work, as this code (from below)
>
>> - ext.cr4_pke = !!kvm_read_cr4_bits(vcpu, X86_CR4_PKE);
>> + ext.cr4_pkr = !!kvm_read_cr4_bits(vcpu, X86_CR4_PKE) ||
>> + !!kvm_read_cr4_bits(vcpu, X86_CR4_PKS);
> will generate the same mmu_role for CR4.PKE=0,PKS=1 and CR4.PKE=1,PKS=1 (and
> other combinations). I.e. KVM will fail to reconfigure the MMU and thus skip
> update_pkr_bitmask() if the guest toggles PKE or PKS while the other PK* bit is set.
>
I'm also not sure why there would be issues in just using cr4_pks.
Paolo
next prev parent reply other threads:[~2021-07-29 17:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 8:37 [PATCH v4 0/5] KVM: PKS Virtualization support Chenyi Qiang
2021-02-05 8:37 ` [PATCH v4 1/5] KVM: VMX: Introduce PKS VMCS fields Chenyi Qiang
2021-02-05 8:37 ` [PATCH v4 2/5] KVM: X86: Expose PKS to guest Chenyi Qiang
2021-02-05 9:23 ` Paolo Bonzini
2021-02-05 9:25 ` Paolo Bonzini
2021-02-05 9:56 ` Borislav Petkov
2021-02-05 10:10 ` Paolo Bonzini
2021-02-05 11:29 ` Thomas Gleixner
2021-02-05 11:51 ` Paolo Bonzini
2021-07-29 16:44 ` Sean Christopherson
2021-08-03 8:50 ` Chenyi Qiang
2021-02-05 8:37 ` [PATCH v4 3/5] KVM: MMU: Rename the pkru to pkr Chenyi Qiang
2021-02-05 8:37 ` [PATCH v4 4/5] KVM: MMU: Add support for PKS emulation Chenyi Qiang
2021-02-05 9:20 ` Paolo Bonzini
2021-07-29 17:25 ` Sean Christopherson
2021-07-29 17:45 ` Paolo Bonzini [this message]
2021-08-03 8:52 ` Chenyi Qiang
2021-02-05 8:37 ` [PATCH v4 5/5] KVM: VMX: Enable PKS for nested VM Chenyi Qiang
2021-02-05 9:24 ` [PATCH v4 0/5] KVM: PKS Virtualization support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1b39b1-ce99-3626-b502-eb1324001163@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.