From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Date: Mon, 9 Mar 2020 15:52:12 +0800
Subject: [LTP] [PATCH v1 2/2] syscalls/settimeofday02: convert to new
 library
In-Reply-To: <20200309074701.GA299736@x230>
References: <1583311467-2379-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
 <1583311467-2379-2-git-send-email-xuyang2018.jy@cn.fujitsu.com>
 <20200309074701.GA299736@x230>
Message-ID: <fd1bed86-4590-cf73-a121-b9f9f0271e13@cn.fujitsu.com>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi


> Hi Xu,
> 
>> +static void verify_settimeofday(unsigned int n)
> ...
>> +	struct tcase *tc = &tcases[n];
>> +
>> +	flag = 0;
>> +	tst_res(TINFO, "%s", tc->message);
>> +	TEST(settimeofday(&tc->tv, NULL));
>> +	if (TST_RET != -1) {
>> +		tst_res(TFAIL, "settimeofday() succeeded unexpectedly");
> Maybe add TTERRNO here as well?
Why? When run into here, settimeofyday succeeded unexpectedly, errno 
should be 0.

Best Regards
Yang Xu
>> +		flag = 1;
>> +		return;
> 
> Kind regards,
> Petr
> 
>