From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Mon, 28 Nov 2016 15:54:51 +0900
Subject: [U-Boot] [PATCH] cmd: usb: run 'usb start' when USB is stopped
In-Reply-To: <9c898974-68be-2c1b-1060-9f1388d25770@samsung.com>
References: <1473416416-4643-1-git-send-email-jh80.chung@samsung.com>
 <CGME20160923041554epcas1p486b97021455c6f2d2a38f35f9ce6ad47@epcas1p4.samsung.com>
 <CAPnjgZ2rn7Bz=Jncj3eVXOk8t4er6vETsGJ8O+7v6AWs8aXe7Q@mail.gmail.com>
 <9c898974-68be-2c1b-1060-9f1388d25770@samsung.com>
Message-ID: <fd1e1c2d-1cda-1912-2261-85a703a36946@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jaehoon,

On 28/11/16 14:08, Jaehoon Chung wrote:
> Hi Marek,
> 
> On 09/23/2016 01:15 PM, Simon Glass wrote:
>> +Marek
>>
>> On 9 September 2016 at 04:20, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> If USB is stopped, just run 'usb start' instead of printing message.
>>> Then user didn't consider whether usb is started or stopped.
> 
> Do you have any other opinion for this? :)
> 
> Best Regards,
> Jaehoon Chung
> 
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> ---
>>>  cmd/usb.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/cmd/usb.c b/cmd/usb.c
>>> index 455127c..4970851 100644
>>> --- a/cmd/usb.c
>>> +++ b/cmd/usb.c
>>> @@ -651,8 +651,8 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>>>                 return 0;
>>>         }
>>>         if (!usb_started) {
>>> -               printf("USB is stopped. Please issue 'usb start' first.\n");
>>> -               return 1;
>>> +               printf("USB is stopped. Running 'usb start' first.\n");
>>> +               do_usb_start();
>>>         }

It seems to ambiguous whether initialization was succeed or not.

Thanks,
Minkyu Kang.