From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FB26C433EF for ; Mon, 28 Feb 2022 18:56:17 +0000 (UTC) Received: from localhost ([::1]:32926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOlBw-0006eE-GV for qemu-devel@archiver.kernel.org; Mon, 28 Feb 2022 13:56:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOlAn-0004Rn-Lv for qemu-devel@nongnu.org; Mon, 28 Feb 2022 13:55:06 -0500 Received: from [2607:f8b0:4864:20::1030] (port=56042 helo=mail-pj1-x1030.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOlAi-00045H-19 for qemu-devel@nongnu.org; Mon, 28 Feb 2022 13:55:05 -0500 Received: by mail-pj1-x1030.google.com with SMTP id gb21so11941097pjb.5 for ; Mon, 28 Feb 2022 10:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RdtEO95V+Z+FzJlvGTCnOiLt8kaTnSPDLH5064uXZ3U=; b=PRKB0looZbLXWIu3WmK7i4ybs6kTjgp6F6vDPWymBwBz+4XYz/Y9a6IuvTYX4Fcjtr w8b5wpxjDLcpXh6uqWLP0g1bQ1gSpJ29oenBQsC57CSzlOLHdh5YZrcW8MP5hO643PMs DoK/w/X+67J+0kfnhkcDj5f1MO2xukIojCSYEXUzjvQ3L/jaLC8ZNlSGzovDi7tOeQav Etkf/VkyT2tlcMBiotYv7F2TLOM0h6lHam/wBpZ2ApRxXbridEeifRaZXpOlWoyzUW1y wG0nv2JEokr5L/n9IQUPL3IzIHV5kEBhojZko7syIxrME6fbpfDDCOXtKZP5Ia6jM1XG pPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RdtEO95V+Z+FzJlvGTCnOiLt8kaTnSPDLH5064uXZ3U=; b=Jvf72F15f58o1xmxaTBIj0mm7knHPA82bCTRO3TwlH6jmEWshsE3TWjTLYtyquR4yt zJdclQp8fSlOWCKtgnsrNaDoSt8T3IEXgc4xglco74qLhWtNQaXNG8a3jLWvazktCSPy ti/fw1FlHohxl1gH+y/EWqgUAzL/3cKwnTec+ndiESpqGmjqCrtE1maonbWjYvaujoJh YbQKKjIctNwHP3PPNe9dFhcV/FIYXLjVk8iG4bzzBXJ0PtXwdnNLVG+Buc9EbnPJXTaw IX4TxlShz9WoTvz4kFKzjkb+PEShituLlnQ+qxWzhq/8fPnClczIA205T5HhshFulhaG jC/g== X-Gm-Message-State: AOAM5325TT3I+hmuvgjCOzBQphIZTrTSc5cUCYlkX5H9LAliVUeInYFc 5uD0oLxYgRA710k0/9NXBnuecw== X-Google-Smtp-Source: ABdhPJwYZItvJnILPEaVrkG2VO6eTWXtPp2SoKlB+HdGeUJxIhpo00PzDkR3VeTniPyHvOWN2yVf8g== X-Received: by 2002:a17:90a:588c:b0:1b8:91a6:6cdf with SMTP id j12-20020a17090a588c00b001b891a66cdfmr18145309pji.239.1646074488603; Mon, 28 Feb 2022 10:54:48 -0800 (PST) Received: from ?IPV6:2603:800c:1201:c600:483f:d486:138f:7868? (2603-800c-1201-c600-483f-d486-138f-7868.res6.spectrum.com. [2603:800c:1201:c600:483f:d486:138f:7868]) by smtp.gmail.com with ESMTPSA id u37-20020a056a0009a500b004e1414d69besm14575169pfg.151.2022.02.28.10.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 10:54:48 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 08:54:44 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 02/14] target/riscv: rvk: add support for zbkb extension Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20220228144810.7284-1-liweiwei@iscas.ac.cn> <20220228144810.7284-3-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20220228144810.7284-3-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1030 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, luruibo2000@163.com, lustrew@foxmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/28/22 04:47, Weiwei Li wrote: > - reuse partial instructions of zbb extension, update extension check for them > - add brev8, pack, packh, packw, unzip, zip instructions > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Acked-by: Alistair Francis > --- > target/riscv/bitmanip_helper.c | 53 ++++++++++++++ > target/riscv/helper.h | 3 + > target/riscv/insn32.decode | 45 +++++++----- > target/riscv/insn_trans/trans_rvb.c.inc | 94 +++++++++++++++++++++---- > target/riscv/translate.c | 7 ++ > 5 files changed, 174 insertions(+), 28 deletions(-) Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nOlAl-0004N8-4m for mharc-qemu-riscv@gnu.org; Mon, 28 Feb 2022 13:55:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOlAj-0004KK-Kf for qemu-riscv@nongnu.org; Mon, 28 Feb 2022 13:55:01 -0500 Received: from [2607:f8b0:4864:20::1031] (port=54067 helo=mail-pj1-x1031.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOlAi-00045G-1J for qemu-riscv@nongnu.org; Mon, 28 Feb 2022 13:55:01 -0500 Received: by mail-pj1-x1031.google.com with SMTP id bx5so11952122pjb.3 for ; Mon, 28 Feb 2022 10:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RdtEO95V+Z+FzJlvGTCnOiLt8kaTnSPDLH5064uXZ3U=; b=PRKB0looZbLXWIu3WmK7i4ybs6kTjgp6F6vDPWymBwBz+4XYz/Y9a6IuvTYX4Fcjtr w8b5wpxjDLcpXh6uqWLP0g1bQ1gSpJ29oenBQsC57CSzlOLHdh5YZrcW8MP5hO643PMs DoK/w/X+67J+0kfnhkcDj5f1MO2xukIojCSYEXUzjvQ3L/jaLC8ZNlSGzovDi7tOeQav Etkf/VkyT2tlcMBiotYv7F2TLOM0h6lHam/wBpZ2ApRxXbridEeifRaZXpOlWoyzUW1y wG0nv2JEokr5L/n9IQUPL3IzIHV5kEBhojZko7syIxrME6fbpfDDCOXtKZP5Ia6jM1XG pPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RdtEO95V+Z+FzJlvGTCnOiLt8kaTnSPDLH5064uXZ3U=; b=ik9I097W2j3IhlYzVl7sgMAAwlmnzfVAPkondZ6naM4arSoDzhEwke5lXUPKB9fA9/ +t/Lc5A0tSzxjYnrMvTb5wD6eOX25AzEZAcjPQPEbQs+vfcP4SZp163RIRpiWJbVjzeU P3KXFWVlwxVUYKZZ85dbRO43zv5eT9gM75LDS5ZlrhUmVmAwCFf1bzgMzNSbJk728ffp ZIBgL3fYf4GvkYGq7Ji+sIRw6XWLiI5s3jHsypvbqMq2V4Ny4hs0uVO9ELXAvkRvYCSF oGee3MdCAlh/uMTPxpQ362QKg2wGlozK3vz3lfX1hZoeFAv8RIqpH5BYzrqqjdEkVRBR tbKA== X-Gm-Message-State: AOAM530R4ZaeUhPQbF7W7elO6IJSCsQJxiNiHiVffQ8yJDaDDgz7zBqK Z5MFphSKAb2pLljZEY8sRQJ8yg== X-Google-Smtp-Source: ABdhPJwYZItvJnILPEaVrkG2VO6eTWXtPp2SoKlB+HdGeUJxIhpo00PzDkR3VeTniPyHvOWN2yVf8g== X-Received: by 2002:a17:90a:588c:b0:1b8:91a6:6cdf with SMTP id j12-20020a17090a588c00b001b891a66cdfmr18145309pji.239.1646074488603; Mon, 28 Feb 2022 10:54:48 -0800 (PST) Received: from ?IPV6:2603:800c:1201:c600:483f:d486:138f:7868? (2603-800c-1201-c600-483f-d486-138f-7868.res6.spectrum.com. [2603:800c:1201:c600:483f:d486:138f:7868]) by smtp.gmail.com with ESMTPSA id u37-20020a056a0009a500b004e1414d69besm14575169pfg.151.2022.02.28.10.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 10:54:48 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 08:54:44 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 02/14] target/riscv: rvk: add support for zbkb extension Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, lustrew@foxmail.com, luruibo2000@163.com References: <20220228144810.7284-1-liweiwei@iscas.ac.cn> <20220228144810.7284-3-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20220228144810.7284-3-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1031 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 18:55:01 -0000 On 2/28/22 04:47, Weiwei Li wrote: > - reuse partial instructions of zbb extension, update extension check for them > - add brev8, pack, packh, packw, unzip, zip instructions > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Acked-by: Alistair Francis > --- > target/riscv/bitmanip_helper.c | 53 ++++++++++++++ > target/riscv/helper.h | 3 + > target/riscv/insn32.decode | 45 +++++++----- > target/riscv/insn_trans/trans_rvb.c.inc | 94 +++++++++++++++++++++---- > target/riscv/translate.c | 7 ++ > 5 files changed, 174 insertions(+), 28 deletions(-) Reviewed-by: Richard Henderson r~