From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754029AbcHWRRz (ORCPT ); Tue, 23 Aug 2016 13:17:55 -0400 Received: from aserp1050.oracle.com ([141.146.126.70]:46725 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753615AbcHWRRy (ORCPT ); Tue, 23 Aug 2016 13:17:54 -0400 Subject: Re: [PATCH 1/2] jfs: Jump to error_out when filemap_fdatawait fails To: Quorum Laval , shaggy@kernel.org References: <997dc120ca508e8a2e757f201cca29f4dbee395d.1471896658.git.quorum.laval@gmail.com> Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Dave Kleikamp Message-ID: Date: Tue, 23 Aug 2016 09:57:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <997dc120ca508e8a2e757f201cca29f4dbee395d.1471896658.git.quorum.laval@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/22/2016 03:28 PM, Quorum Laval wrote: > filemap_fdatawait may fail, so check the return value and jump to > error_out in the case of error. > > Signed-off-by: Quorum Laval These look good, but I don't see why these shouldn't be combined into a single patch. Thanks, Dave > --- > fs/jfs/resize.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c > index 90b3bc2..b0322da 100644 > --- a/fs/jfs/resize.c > +++ b/fs/jfs/resize.c > @@ -379,7 +379,10 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize) > * cached in meta-data cache, and not written out > * by txCommit(); > */ > - filemap_fdatawait(ipbmap->i_mapping); > + rc = filemap_fdatawait(ipbmap->i_mapping); > + if (rc) > + goto error_out; > + > filemap_write_and_wait(ipbmap->i_mapping); > diWriteSpecial(ipbmap, 0); > >