From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A283FA3740 for ; Mon, 31 Oct 2022 12:08:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC70610E1CD; Mon, 31 Oct 2022 12:08:28 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E4DD10E1CF for ; Mon, 31 Oct 2022 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-296-5sxKC3SFMxOcbjvUzEUs5w-1; Mon, 31 Oct 2022 08:08:20 -0400 X-MC-Unique: 5sxKC3SFMxOcbjvUzEUs5w-1 Received: by mail-wm1-f71.google.com with SMTP id m34-20020a05600c3b2200b003cf549cb32bso6158363wms.1 for ; Mon, 31 Oct 2022 05:08:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=EAr5EfWw3s7p2r63zSPjLkpI4o2JvU3c8gXmD5J+R3gMlt+V5M6dI/+w+VFy6GHl6R vIWY5Tw2xOt+Ig9vIBCSOP3VAsZanXx1pCCRpZaDdxlyESi+VW4CyunyDeNCswHBfn+r g/Lc39Lxio3z7+S2Dk1EGgolHe2QmQRVJDWndIC4La28eUixXeCfYuCZROMFj3nPTvI6 eyt4kDQdmJlaMW1mGJLBauN6uBtm61ztqxZMq/8fp6jx/+3hjkNJfB6ybnaoihCGtWV0 qoXiTfNvyoIcTb0MSvRX1lUk/SchU5m1ynupyGhdjYdmT0kaX/wIHf6GgA6S/RSP3x3r GQOg== X-Gm-Message-State: ACrzQf1xYU/5izfwDKufNrRSOJnzVV4ENER790RkaXZuun9azNN5ux9W +x7BQPVQO0E06528mJ/qVA8uOHPuUO/+f3RILLTuuvDMZ/vM1m+YurQbwof4cwjnDU+SoC8hhP1 nUN5J5huoKLUmmIpezM9wqIKxXw== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691203wry.248.1667218098877; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E2620F2 for ; Mon, 31 Oct 2022 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-499-MfIv9hE4OnSHy7lbqP6ALw-1; Mon, 31 Oct 2022 08:08:20 -0400 X-MC-Unique: MfIv9hE4OnSHy7lbqP6ALw-1 Received: by mail-wr1-f72.google.com with SMTP id t12-20020adfa2cc000000b0022adcbb248bso2971603wra.1 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=OYLD8202OH5RY+GLo+lIbSO6Od0GAxnWNQ8lOOKHshrvS7TMrERjonLA2vxrpb1PLQ e3t9yBIacXcSlcVoyvRvpX0k1GEl42WJ4PF5mTj6qpYR3zPuuRyBlYMDTw18Tt8WFWtg FP9fRk6pv1lk/UUA1Ftg8kYrJVu4WYyiWwGbVvtQLfPcHaDcQBONYQvF4o/aENImjKmG sitsGcWNLlTdd41XjgMN+eXQue3G3Q3/aDM8D8DgPJYPzdB5aKyGL09cjwY77JJTO8bv 55Pn+TgF1/CxBVGCLuxdhz3fHKztbvCM0FUuuRQ2klT5WHMsjsBPj2H0td8k+Ic2rVfd wTBw== X-Gm-Message-State: ACrzQf1fpaxB1OjS64eZHLy/MJr6eGd5IEYAfSsi+kbgL5BJ6LuDTrs6 e+XH0KfDrHgYxGYRFXAAgeROA8WkPLMzQo52+Vnu3WleEX1Q3KRtCcQnFJ/NSyltqQ/UbyQDw+j hg+vNZcnXz6NX6AsmRPOMiYs= X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691198wry.248.1667218098874; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4ED2FA3740 for ; Mon, 31 Oct 2022 12:08:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 663EE10E1C1; Mon, 31 Oct 2022 12:08:27 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E14CC10E1B0 for ; Mon, 31 Oct 2022 12:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-222-0YbmofpLMcqmCZIxv2Ghzg-1; Mon, 31 Oct 2022 08:08:19 -0400 X-MC-Unique: 0YbmofpLMcqmCZIxv2Ghzg-1 Received: by mail-wr1-f69.google.com with SMTP id o13-20020adfa10d000000b00232c00377a0so3002886wro.13 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=TLh99sMyQjEC3ErJ3tj3YzKRGMMb2Bb7Nj5UjWr8NdyniaWADSXkXTqlaUubBpCtis glQZkggxUd4wR2dGWMk/Rgn47aEd3a2VM+UpfauxkGveNc9PtYXegmmmiEwbuqrjz66u IAI40V6CyRVzKytLKNUyExRTbHM664I/R7WRLzt+UHUJUQ7N9sbbgMb0qXqdqRJEEoTu W6jMH1VpJoBDk/kNp1dUoljxfbkdchF9zhuC3QWbCxLd74S4jd8YJtCYZ6S03BWiFxYy OxAC8GJGuhLFEs+K2PDzedT6+JWKCNhC3AQ1e338bl1e7d0HHCaAIMzu4oqaccp5dsTG fIvA== X-Gm-Message-State: ACrzQf2MEBt/hcOacnvO2i5uPVwCXrpzlI47x/7/Bqdk074xbCn+37FW p7VKedKo4awEyMriiaSMyfuf9JlkFGx6i3Mif4FlgNWqUS3DfQGKkuuKcPo72AVaeZuiTf9IE5X W4cx8qVrXKif6VgVb5BU+zPtoIIko X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691179wry.248.1667218098862; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A35E0FA3744 for ; Mon, 31 Oct 2022 12:08:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88E6110E1CB; Mon, 31 Oct 2022 12:08:27 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D4D510E1CB for ; Mon, 31 Oct 2022 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-663-tLKXsMxxMnWgOp6Vw2usTw-1; Mon, 31 Oct 2022 08:08:20 -0400 X-MC-Unique: tLKXsMxxMnWgOp6Vw2usTw-1 Received: by mail-wm1-f69.google.com with SMTP id v23-20020a1cf717000000b003bff630f31aso2532622wmh.5 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=wnJGipGaE3rHsT0JPTQz7x/nUhLoRYm8F2UCjaaU7y5eX6hVkwKGDP03yHvpKpkgoR l4/orSwyKx+whay9P9LeBHw1IQtliuKv+IGnjZKV8YhC+fnnACdLAgC5qH4l/zG2yD3H 4QcMuk02pZx2ZRUDA/4wmjB+JrWX6DqPXDXi+2zh74FnGrZJO3iEWbtUyMergy66P1he zhaDUThgHUj2c/+4S4tv/++PcarIryvSIEiVimt67WRyWiwGjltJQerTNqNonWo2rgJ+ C4/E4EeuDmQNdqv8nciBYrqDSwurBkLgZYG8n9SAJdPZpGIfliGgfH7RhD/YJklFr/Wc GZtA== X-Gm-Message-State: ACrzQf3na3eNk5aaGEh4TGHmi49BLd1jiaS0h9DP/r0fmqki4w2+NUTJ WGZF+swavGtVCSC0/Z/ozy3gnMC3Uu65gi4zHhPl/t96DvKcX8CgWsH9v4LaQRN70OdmR0Qc4NV BxR+vZdnt+1W6UOBSbnduzHwcjopF X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691186wry.248.1667218098869; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B210C38A02 for ; Mon, 31 Oct 2022 12:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=obiW6R5Os7pA9zoKE//Ho6us2egTFiIvQstHakxHHAI=; b=Cyawj+8o4ceMVl 9qdFOG7frk4niHYWI6+xnWvVEzM5e89JPSaAjUch53fd1jAMBNbQDW3gKn4IkQZ7rF0Vw+wAMACuq q2wnq5XvETKAXwHcDiUubkdhLBXWHxgW3A/hOsqTwaldvQd55mAGQ9/qWfDt4m2X37riIi0V+wneD q+Dbcvdb4eMk1aP3wRDUbryIZsV3Lz/YX+7Ik9enMq5t1dMgRUWXP1sYM2dxav0J6ahqBxCoxhhaW +f78S0AsxTMNcve0WPS4usXSWi+NGfkJKtBqLcbOvYbabPTc3VNWvCifftorQUudQzX7+91hUq689 es88ZoIJhr5Vqea44OiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTas-00BXVX-AP; Mon, 31 Oct 2022 12:08:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTaZ-00BXNR-Am for linux-rockchip@lists.infradead.org; Mon, 31 Oct 2022 12:08:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=hTpZZxWmVNbgOUumUIGOnoXK6tML7MS1sKAKBMeqQeQUE7N5xybvsJ2RSKXZzsLUpjBio7 +bmRcOjz0kwATlP6Hxgd4TSp9YQ1MhM2rRoBxhfzSoHbfeNbHy59j2iLuMmaQtOuHQZ1lp AMTyNaBuxjVpApoGKFXvFr/ZsmcgTJ4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-445-Z-Lbt5yeNwOjPBEJia6VhQ-1; Mon, 31 Oct 2022 08:08:20 -0400 X-MC-Unique: Z-Lbt5yeNwOjPBEJia6VhQ-1 Received: by mail-wm1-f70.google.com with SMTP id s7-20020a1cf207000000b003cf56bad2e2so2174641wmc.9 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=FxIamGgSZET7qUfSQ76cvflritK6Ptfr5yc1Bk3fHgQnPGK9PtgcqHvo2MBA/CYoBz t1RzxT8LX4/lr8lgc7OGBFU27ASCu+1FvvduaP6qo0fPX5ZEgwAGcBw/z+NCEucDTvNg XwdnFdF1HCKUv3S4BShFTtk3XyzEgg9n2oAsJaam7kBHxERg8E0hh4Ib4rQXh7vIZuBD rGyeXtrwl6+zSYeoEmemtQm34WF6MK/eXif/zmI1kMBW8DciRrzJ8tgFDvijDFlVocPe kKDO2fEiZiREaVNue2E/Q+D9Ye3eplMIBDyQHH2aezkp2nhUOAoZvLgQEW28ZYilTSJp PaBQ== X-Gm-Message-State: ACrzQf01pRKLFQUyV7MHhaaDzK087PD5LZrgCVkEVUjHwV78TGuV2h5y IeW1zWySQ3bV3kxK2+pJmUKnWhRxJfifT82gj123BrXR/1P/mmDF0ulnpxa7G8pNJU/Y7hdV9IC 1WQgDi5gkwRTA94CzO30Hn4JCpI52BDnU X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691185wry.248.1667218098866; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_050823_457512_557A8C14 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB217C38A02 for ; Mon, 31 Oct 2022 12:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yrBlVv4CSSwa/MmSCO+g31/iZhgvW0I4WuIpX5mgcmk=; b=CgqTIU7U3f9cDN JcXUEHf9ejkDQjqg7pKFgKtjuky4EmKdbZb19OwXwEpLcAnZhMrKaub/br4QHgWzxjDWACfOmTzc7 TVnCEUqfXBVJVDpsmFPoiQcMkoeJyFcDm20pSA4GdDUdHhY7N3YFYvim8CdOGUOs2H1uPHVmm2vAd cRdpbYIQYK3FV2lke+uhyf295WlXIFFfdZ4sinHzg2TjmWrz1Vu9QkmBq2slZ7zqtFp8DpWfyI5Zg 0sYLWK0eh6Vt0xN3GgBHhZy56PowNTdReut0i+5F4K/kx5QpTBgIgn3zLdKvoj/HIXRVXv77JHRio lP4xbZeTf4YP2OznrejQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTae-00BXPT-T4; Mon, 31 Oct 2022 12:08:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTaY-00BXMm-7k for linux-arm-kernel@lists.infradead.org; Mon, 31 Oct 2022 12:08:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-320-TTY8SiiIMLCASPekSkPuzQ-1; Mon, 31 Oct 2022 08:08:19 -0400 X-MC-Unique: TTY8SiiIMLCASPekSkPuzQ-1 Received: by mail-wr1-f69.google.com with SMTP id n16-20020adfc610000000b0023650935090so2971299wrg.5 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=scDMmF1bESbPgGWjVfCAmazqE2lFnSWG2CiVFqhBv5L3ESAZqA0lJtglEYfHJSTJcp qZkaEfqNqs2F89iyuP7JVS+5KpGCyqKhGKh9ibGR9smK5GRIiZCyIohLUdYl7xFOPFBT bveN2QJbWoINMSueMiUa1aqrNHBTeRBT+/SKBJZePgT6cWm5WAIW3S8WbwBdlZ5GFJSw CDIyzIc8Izxb03aZ2Yf2fz/Yl2KMfFcEfFuP76UozKd0i0Qq19i8nCGZ8Xenp5d4rx/V MWGy9rFdg9PRBK86RBP3xwI5LdzWr4SnC7v9ZCM06Y1SCZ7LuwG7DPedl/aQrh28KjkA CYXw== X-Gm-Message-State: ACrzQf3q3PLvUNQ8CGIHBmS4sUrTGP4Fvpo56ldJljSDZmFE/P9KP2Rf g8FcL0DfBbm02XhZv+bINOAf40tRejyf101MJIUWcmU48zw+Z/Mq/nMs5nyqBXdrJLTWHlweD89 VCPTyETQOSWli3+F+f5m7cyYZRsSOoZLj7xk= X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691196wry.248.1667218098875; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_050822_391167_AFCB8231 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 162AEFA3740 for ; Mon, 31 Oct 2022 12:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H3hhRxZH4h3EH9l4eaEOR6hEh+GY2EIWsU63x4VCf7c=; b=El+PLwCYy2nwGz 3pkER+0rdMGOAs3NFfVg1/+EXWfyaU5lC0zi168Jjrb7z+rPtvUrgomrxb5m59e+F4a121jlXpcFv dV7maVp0oiogFWSS7h9nY4saV1rXlPP0g7Ieyq+du+TH9uQJrX/kpclYZseNhG0vdacSF6XE719N/ jfhrvksBp7+Rkl2H0a2B5KOIcpK1ZOEcATTbmppwmO+Qr9d7OkvipWjklH2dahXnq34D7nXhXK7Tc NMIC4R1czf95G6L3CBtFVGHpiXc0l9nztEi3oTw+uqwtvp80OnFqoGCl7CUSWTv/6nQuR4t4y/0mG XjTmgx88QEH3T72XPWMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTar-00BXUo-OU; Mon, 31 Oct 2022 12:08:41 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opTaY-00BXMq-Ae for linux-amlogic@lists.infradead.org; Mon, 31 Oct 2022 12:08:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667218101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-401-8RjR_auMMjCaN0TTM4VLIg-1; Mon, 31 Oct 2022 08:08:19 -0400 X-MC-Unique: 8RjR_auMMjCaN0TTM4VLIg-1 Received: by mail-wr1-f69.google.com with SMTP id p7-20020adfba87000000b0022cc6f805b1so3012250wrg.21 for ; Mon, 31 Oct 2022 05:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=; b=QX2JIsTNCEdMNeYfSlgif++xT00+h4Vhl2cyJ2MZDF6LnY6T0WYHJKcTUgDgMcG3Qc TIEKhAeMsqKKF4fEQEzaJppJF9ikO6F03z69bfw77mBUf1El+HbG+OjsFibhggJo5LJT voOnZMcsDmfMy0A66npXNoXsXSn74VRyDWfLu1tGGflyRvdscsCpvrH2fx/jhyvAcgsl c8pwqcnVce2bMBZrgydUjQJg8iIgxMol//N9Z18VJPYJfN8ta1y0xS+Z3odWswrhOPHV TaVNDNhRuVEBZSfq1Zl4WrKK5Oy1D0LoOgI/3JfE3/A5/42fi1GsaEBOewqxSIibNMkm Tzpw== X-Gm-Message-State: ACrzQf0yfSrIqCmcG1a0Mqsm5fKQORgu17/lHgFK7LIdg0c+UDoDL9+B 2GKNJbyydfEQOP3PNs+3abjPJ9+BM2hPC4FdzXIctfM6ksr1YZAbhEFGbYocApz7tt3zcRqI1Y/ //04hmlvEQyVWb4U7FV2zV9NO440JQfY= X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691202wry.248.1667218098876; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA== X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682; Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:08:18 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-5-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_050822_475509_D8FFCB78 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Don't set struct drm_driver.output_poll_changed. It's used to restore > the fbdev console. But as amdgpu uses generic fbdev emulation, the > console is being restored by the DRM client helpers already. See the > functions drm_kms_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers kernel doc has to be updated to mention that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are not needed when generic fbdev emulation is used? Because by reading that is not clear that's the case: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86 -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic