From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver Date: Wed, 19 Dec 2018 14:41:04 -0600 Message-ID: References: <20181219162626.12297-1-dmurphy@ti.com> <20181219162626.12297-3-dmurphy@ti.com> <20181219193455.GA21159@amd> <8740cfd6-a6b5-ad27-313b-984a9febf18a@ti.com> <20181219201047.GA23448@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181219201047.GA23448@amd> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: > On Wed 2018-12-19 13:41:18, Dan Murphy wrote: >> Pavel >> >> Thanks for the review. >> >> On 12/19/2018 01:34 PM, Pavel Machek wrote: >>> Hi! >>> >>>> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); >>>> +static DEVICE_ATTR_WO(ctrl_bank_b_mix); >>>> +static DEVICE_ATTR_WO(ctrl_bank_c_mix); >>>> + >>>> +static struct attribute *lp5024_ctrl_bank_attrs[] = { >>>> + &dev_attr_ctrl_bank_a_mix.attr, >>>> + &dev_attr_ctrl_bank_b_mix.attr, >>>> + &dev_attr_ctrl_bank_c_mix.attr, >>>> + NULL >>>> +}; >>>> +ATTRIBUTE_GROUPS(lp5024_ctrl_bank); >>> >>> ... >>>> + >>>> +static DEVICE_ATTR_WO(led1_mix); >>>> +static DEVICE_ATTR_WO(led2_mix); >>>> +static DEVICE_ATTR_WO(led3_mix); >>>> + >>>> +static struct attribute *lp5024_led_independent_attrs[] = { >>>> + &dev_attr_led1_mix.attr, >>>> + &dev_attr_led2_mix.attr, >>>> + &dev_attr_led3_mix.attr, >>>> + NULL >>>> +}; >>>> +ATTRIBUTE_GROUPS(lp5024_led_independent); >>> >>> Ok, so you are adding new sysfs files. Are they _really_ neccessary? >>> We'd like to have uniform interfaces for the leds. >> >> Yes I am adding these for this driver. >> They adjust the individual brightness of each LED connected (what the HW guys called mixing). >> >> The standard brightness sysfs adjusts all 3 LEDs simultaneously so that all 3 LEDs brightness are >> uniform. > > 1 LED, 1 brightness file... that's what we do. Why should this one be different? > Yes I understand this and 1 DT child node per LED out but... This device has a single register to control 3 LEDs brightness as a group and individual brightness registers to control the LEDs independently to mix the LEDs to a specific color. There needs to be a way to control both so that developers can mix and adjust the individual RGB and then control the brightness of the group during run time without touching the "mixing" value. I don't think a user needs nor would want to have 24 different LED nodes with 24 different brightness files. Or with the LP5036 that would have 36 LED nodes. Table 1 in the data sheet shows how the outputs map to the control banks to the LED registers. Dan >> I did not think these belonged in the dt as they should be user space configurable >> >>> >>> If they are neccessary, we need documentation for them. >> >> Sure I have no problem documenting them but where do I do that? >> I am assuming Documentation/leds/leds-lp5024.txt > > Documentation/abi/... > > Pavel > -- ------------------ Dan Murphy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292CBC43387 for ; Wed, 19 Dec 2018 20:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7F8F20873 for ; Wed, 19 Dec 2018 20:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QSDLlDgZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730329AbeLSUlL (ORCPT ); Wed, 19 Dec 2018 15:41:11 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:37020 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729585AbeLSUlK (ORCPT ); Wed, 19 Dec 2018 15:41:10 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id wBJKf5OO008999; Wed, 19 Dec 2018 14:41:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1545252065; bh=8n7mFMZsU9E5bR46OHHKnWJuEq1e4yDI7ELGWwTKjmw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QSDLlDgZkHZvnjipEHmKmzq4Sm1O38e/7Yrkniw4u/5mQVdCG3ZX0pLCMv7XWtmI4 gyMbXz4X8Prm94IeaMgIRXRPHRxucW6+RD8d0yZJPJ8HtLKS/KreR5wPBHiwTxyUL4 kOa2E/qKyfwXWbdMHDuSBurFJYr0bJ69xQ2iUPX8= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wBJKf5KT014076 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 19 Dec 2018 14:41:05 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 19 Dec 2018 14:41:05 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 19 Dec 2018 14:41:05 -0600 Received: from [172.22.106.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wBJKf5xI020574; Wed, 19 Dec 2018 14:41:05 -0600 Subject: Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver To: Pavel Machek CC: , , , , References: <20181219162626.12297-1-dmurphy@ti.com> <20181219162626.12297-3-dmurphy@ti.com> <20181219193455.GA21159@amd> <8740cfd6-a6b5-ad27-313b-984a9febf18a@ti.com> <20181219201047.GA23448@amd> From: Dan Murphy Message-ID: Date: Wed, 19 Dec 2018 14:41:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181219201047.GA23448@amd> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: > On Wed 2018-12-19 13:41:18, Dan Murphy wrote: >> Pavel >> >> Thanks for the review. >> >> On 12/19/2018 01:34 PM, Pavel Machek wrote: >>> Hi! >>> >>>> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); >>>> +static DEVICE_ATTR_WO(ctrl_bank_b_mix); >>>> +static DEVICE_ATTR_WO(ctrl_bank_c_mix); >>>> + >>>> +static struct attribute *lp5024_ctrl_bank_attrs[] = { >>>> + &dev_attr_ctrl_bank_a_mix.attr, >>>> + &dev_attr_ctrl_bank_b_mix.attr, >>>> + &dev_attr_ctrl_bank_c_mix.attr, >>>> + NULL >>>> +}; >>>> +ATTRIBUTE_GROUPS(lp5024_ctrl_bank); >>> >>> ... >>>> + >>>> +static DEVICE_ATTR_WO(led1_mix); >>>> +static DEVICE_ATTR_WO(led2_mix); >>>> +static DEVICE_ATTR_WO(led3_mix); >>>> + >>>> +static struct attribute *lp5024_led_independent_attrs[] = { >>>> + &dev_attr_led1_mix.attr, >>>> + &dev_attr_led2_mix.attr, >>>> + &dev_attr_led3_mix.attr, >>>> + NULL >>>> +}; >>>> +ATTRIBUTE_GROUPS(lp5024_led_independent); >>> >>> Ok, so you are adding new sysfs files. Are they _really_ neccessary? >>> We'd like to have uniform interfaces for the leds. >> >> Yes I am adding these for this driver. >> They adjust the individual brightness of each LED connected (what the HW guys called mixing). >> >> The standard brightness sysfs adjusts all 3 LEDs simultaneously so that all 3 LEDs brightness are >> uniform. > > 1 LED, 1 brightness file... that's what we do. Why should this one be different? > Yes I understand this and 1 DT child node per LED out but... This device has a single register to control 3 LEDs brightness as a group and individual brightness registers to control the LEDs independently to mix the LEDs to a specific color. There needs to be a way to control both so that developers can mix and adjust the individual RGB and then control the brightness of the group during run time without touching the "mixing" value. I don't think a user needs nor would want to have 24 different LED nodes with 24 different brightness files. Or with the LP5036 that would have 36 LED nodes. Table 1 in the data sheet shows how the outputs map to the control banks to the LED registers. Dan >> I did not think these belonged in the dt as they should be user space configurable >> >>> >>> If they are neccessary, we need documentation for them. >> >> Sure I have no problem documenting them but where do I do that? >> I am assuming Documentation/leds/leds-lp5024.txt > > Documentation/abi/... > > Pavel > -- ------------------ Dan Murphy