All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
Subject: Re: ANNOUNCE: nfs-utils-2.4.2 released.
Date: Sun, 17 Nov 2019 14:40:13 -0500	[thread overview]
Message-ID: <fd6a75d4-9b52-9c8f-9ad5-d01340fdb89e@RedHat.com> (raw)
In-Reply-To: <04f375d6-e50a-0b5e-7095-dbc3907bfe23@nazar.ca>

Hey,

On 11/17/19 12:47 PM, Doug Nazar wrote:
> This still causes crashes in mountd on 32bit systems without https://marc.info/?l=linux-nfs&m=157250894818731&w=2
> 
> mountd: Version 2.4.2 starting
> mountd: auth_unix_ip: inbuf 'nfsd fde2:2b6c:2d24:0021:0000:0000:0000:0050'
> mountd: auth_unix_ip: client 0x13cd900 '*'
> mountd: nfsd_fh: inbuf '* 6 \xd1fb45ab77b345d99b09b3217dcdf2ec'
> *** stack smashing detected ***: <unknown> terminated
> Aborted
> 
> Call chain looks like:
> 
> get_rootfh                    utils/mountd/mountd.c
>     check_is_mountpoint       support/misc/mountpoint.c
>         nfsd_path_lstat       support/misc/nfsd_path.c    *
>             xlstat            support/misc/xstat.c        *
> 
> where two struct stats are declared on the stack in mountpoint.c without including config.h and getting the __USE_FILE_OFFSET64 define, however the following two files in the call chain include config.h and get a different size struct stat.
> 
> Also attached are a few printf formating fixes for 32 bit.
My apologies... I did miss this patch in the last release, but the
patch is now committed... 

I blame the American Halloween... the day the patch was posted! :-) 
Those darn spooks and goblins of getting in the way!! 8-) 

steved.


  reply	other threads:[~2019-11-17 19:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 17:47 ANNOUNCE: nfs-utils-2.4.2 released Doug Nazar
2019-11-17 19:40 ` Steve Dickson [this message]
2019-11-19 20:54   ` Doug Nazar
  -- strict thread matches above, loose matches on Subject: below --
2019-11-15 16:14 Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd6a75d4-9b52-9c8f-9ad5-d01340fdb89e@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nazard@nazar.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.