From: "Andreas Färber" <afaerber@suse.de>
To: James Tai <james.tai@realtek.com>
Cc: linux-realtek-soc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v4 3/3] arm64: dts: realtek: Add RTD1319 SoC and Realtek Pym Particles EVB
Date: Tue, 23 Jun 2020 04:16:09 +0200 [thread overview]
Message-ID: <fd6ad520-54f2-076c-dd4c-34a4bf426b22@suse.de> (raw)
In-Reply-To: <20200620233227.31585-4-afaerber@suse.de>
Hi James,
Am 21.06.20 um 01:32 schrieb Andreas Färber:
> From: James Tai <james.tai@realtek.com>
>
> Add Device Trees for Realtek RTD1319 SoC family, RTD1319 SoC and
> Realtek Pym Particles EVB.
>
> Signed-off-by: James Tai <james.tai@realtek.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v3 -> v4:
> * Updated Realtek copyright for 2 out of 3 files from v3
> * Renamed from rtd1319-pymparticle.dts to rtd1319-pymparticles.dts
> * Updated compatible from pymparticle to pym-particles
> * Updated PMU compatible from armv8-pmuv3 to cortex-a55-pmu (Robin)
>
> v2 -> v3:
> * Add virtual maintenance interrupt for architecture timer
> * Correct the GIC redistributor address range
[...]
> diff --git a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
> new file mode 100644
> index 000000000000..8c5b6fc7b8eb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi
[...]
> + gic: interrupt-controller@ff100000 {
> + compatible = "arm,gic-v3";
> + reg = <0xff100000 0x10000>,
> + <0xff140000 0x80000>;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
In my testing this appears to cause the following error:
[ 2.239858] irq: type mismatch, failed to map hwirq-25 for
interrupt-controller@ff100000!
...
[ 3.505649] kvm [1]: IPA Size Limit: 40bits
[ 3.506051] kvm [1]: GICv3: no GICV resource entry
[ 3.506058] kvm [1]: disabling GICv2 emulation
[ 3.506081] kvm [1]: GIC system register CPU interface enabled
[ 3.506175] kvm [1]: vgic interrupt IRQ1
[ 3.506293] kvm [1]: Hyp mode initialized successfully
If I change it to IRQ_TYPE_LEVEL_LOW, that error goes away:
[ 3.506030] kvm [1]: IPA Size Limit: 40bits
[ 3.506430] kvm [1]: GICv3: no GICV resource entry
[ 3.506437] kvm [1]: disabling GICv2 emulation
[ 3.506459] kvm [1]: GIC system register CPU interface enabled
[ 3.506551] kvm [1]: vgic interrupt IRQ1
[ 3.506672] kvm [1]: Hyp mode initialized successfully
In-tree RTD1619 has it as HIGH, too, but doesn't show above error:
[ 2.918973] kvm [1]: IPA Size Limit: 40bits
[ 2.919345] kvm [1]: GICv3: no GICV resource entry
[ 2.919352] kvm [1]: disabling GICv2 emulation
[ 2.919373] kvm [1]: GIC system register CPU interface enabled
[ 2.919522] kvm [1]: vgic interrupt IRQ1
[ 2.919700] kvm [1]: Hyp mode initialized successfully
RTD1619 doesn't show an error either if I change it to LOW though:
[ 2.918843] kvm [1]: IPA Size Limit: 40bits
[ 2.919212] kvm [1]: GICv3: no GICV resource entry
[ 2.919218] kvm [1]: disabling GICv2 emulation
[ 2.919240] kvm [1]: GIC system register CPU interface enabled
[ 2.919390] kvm [1]: vgic interrupt IRQ1
[ 2.919567] kvm [1]: Hyp mode initialized successfully
The GICv3 bindings example does have it as 4 == HIGH, but so does the
GICv2 binding example, and yet we used LOW == 8 for in-tree RTD139x,
RTD129x and RTD1195. The downstream BSP uses value 4 == HIGH for both
RTD16xx and RTD13xx - is it possible this was never actually tested?
Thanks in advance for clarifying the correct interrupt polarity.
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + };
[snip]
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2020-06-23 2:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 23:32 [PATCH v4 0/3] arm64: dts: realtek: Initial RTD1319 and Pym Particles support Andreas Färber
2020-06-20 23:32 ` [PATCH v4 1/3] dt-bindings: arm: realtek: Convert comments to descriptions Andreas Färber
2020-06-27 6:42 ` James Tai [戴志峰]
2020-06-27 6:42 ` James Tai [戴志峰]
2020-06-20 23:32 ` [PATCH v4 2/3] dt-bindings: arm: realtek: Document RTD1319 and Realtek Pym Particles EVB Andreas Färber
2020-06-27 6:46 ` James Tai [戴志峰]
2020-06-27 6:46 ` James Tai [戴志峰]
2020-06-20 23:32 ` [PATCH v4 3/3] arm64: dts: realtek: Add RTD1319 SoC " Andreas Färber
2020-06-23 0:53 ` Andreas Färber
2020-06-23 2:16 ` Andreas Färber [this message]
2020-06-22 12:55 [PATCH v4 0/3] arm64: dts: realtek: Initial RTD1319 and Pym Particles support Andreas Färber
2020-06-22 12:55 ` [PATCH v4 3/3] arm64: dts: realtek: Add RTD1319 SoC and Realtek Pym Particles EVB Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6ad520-54f2-076c-dd4c-34a4bf426b22@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.