All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
@ 2017-06-22  9:24 Sabrina Dubroca
  2017-06-27  8:38 ` Masami Hiramatsu
  0 siblings, 1 reply; 4+ messages in thread
From: Sabrina Dubroca @ 2017-06-22  9:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: Sabrina Dubroca, Steven Rostedt, Ingo Molnar, Hannes Frederic Sowa

Always try to parse an address, since kstrtoul() will safely fail when
given a symbol as input. If that fails (which will be the case for a
symbol), try to parse a symbol instead.

This allows creating a probe such as:

    p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0

Which is necessary for this command to work:

    perf probe -m 8021q -a vlan_gro_receive

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
---
 kernel/trace/trace_kprobe.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index c129fca6ec99..b53c8d369163 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -707,20 +707,16 @@ static int create_trace_kprobe(int argc, char **argv)
 		pr_info("Probe point is not specified.\n");
 		return -EINVAL;
 	}
-	if (isdigit(argv[1][0])) {
-		/* an address specified */
-		ret = kstrtoul(&argv[1][0], 0, (unsigned long *)&addr);
-		if (ret) {
-			pr_info("Failed to parse address.\n");
-			return ret;
-		}
-	} else {
+
+	/* try to parse an address. if that fails, try to read the
+	 * input as a symbol. */
+	if (kstrtoul(argv[1], 0, (unsigned long *)&addr)) {
 		/* a symbol specified */
 		symbol = argv[1];
 		/* TODO: support .init module functions */
 		ret = traceprobe_split_symbol_offset(symbol, &offset);
 		if (ret) {
-			pr_info("Failed to parse symbol.\n");
+			pr_info("Failed to parse either an address or a symbol.\n");
 			return ret;
 		}
 		if (offset && is_return &&
-- 
2.13.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
  2017-06-22  9:24 [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit Sabrina Dubroca
@ 2017-06-27  8:38 ` Masami Hiramatsu
  2017-06-27 14:07   ` Steven Rostedt
  0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2017-06-27  8:38 UTC (permalink / raw)
  To: Sabrina Dubroca
  Cc: linux-kernel, Steven Rostedt, Ingo Molnar, Hannes Frederic Sowa

On Thu, 22 Jun 2017 11:24:42 +0200
Sabrina Dubroca <sd@queasysnail.net> wrote:

> Always try to parse an address, since kstrtoul() will safely fail when
> given a symbol as input. If that fails (which will be the case for a
> symbol), try to parse a symbol instead.
> 
> This allows creating a probe such as:
> 
>     p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> 
> Which is necessary for this command to work:
> 
>     perf probe -m 8021q -a vlan_gro_receive
> 

Ah, I forgot that case.
Nice catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> ---
>  kernel/trace/trace_kprobe.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index c129fca6ec99..b53c8d369163 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -707,20 +707,16 @@ static int create_trace_kprobe(int argc, char **argv)
>  		pr_info("Probe point is not specified.\n");
>  		return -EINVAL;
>  	}
> -	if (isdigit(argv[1][0])) {
> -		/* an address specified */
> -		ret = kstrtoul(&argv[1][0], 0, (unsigned long *)&addr);
> -		if (ret) {
> -			pr_info("Failed to parse address.\n");
> -			return ret;
> -		}
> -	} else {
> +
> +	/* try to parse an address. if that fails, try to read the
> +	 * input as a symbol. */
> +	if (kstrtoul(argv[1], 0, (unsigned long *)&addr)) {
>  		/* a symbol specified */
>  		symbol = argv[1];
>  		/* TODO: support .init module functions */
>  		ret = traceprobe_split_symbol_offset(symbol, &offset);
>  		if (ret) {
> -			pr_info("Failed to parse symbol.\n");
> +			pr_info("Failed to parse either an address or a symbol.\n");
>  			return ret;
>  		}
>  		if (offset && is_return &&
> -- 
> 2.13.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
  2017-06-27  8:38 ` Masami Hiramatsu
@ 2017-06-27 14:07   ` Steven Rostedt
  2017-06-27 22:05     ` Masami Hiramatsu
  0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2017-06-27 14:07 UTC (permalink / raw)
  To: Masami Hiramatsu
  Cc: Sabrina Dubroca, linux-kernel, Ingo Molnar, Hannes Frederic Sowa

On Tue, 27 Jun 2017 17:38:30 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Thu, 22 Jun 2017 11:24:42 +0200
> Sabrina Dubroca <sd@queasysnail.net> wrote:
> 
> > Always try to parse an address, since kstrtoul() will safely fail when
> > given a symbol as input. If that fails (which will be the case for a
> > symbol), try to parse a symbol instead.
> > 
> > This allows creating a probe such as:
> > 
> >     p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> > 
> > Which is necessary for this command to work:
> > 
> >     perf probe -m 8021q -a vlan_gro_receive
> >   
> 
> Ah, I forgot that case.
> Nice catch!
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>

Thanks Masami,

I can take this. Should this go to stable?

-- Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
  2017-06-27 14:07   ` Steven Rostedt
@ 2017-06-27 22:05     ` Masami Hiramatsu
  0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2017-06-27 22:05 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Sabrina Dubroca, linux-kernel, Ingo Molnar, Hannes Frederic Sowa

On Tue, 27 Jun 2017 10:07:45 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 27 Jun 2017 17:38:30 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > On Thu, 22 Jun 2017 11:24:42 +0200
> > Sabrina Dubroca <sd@queasysnail.net> wrote:
> > 
> > > Always try to parse an address, since kstrtoul() will safely fail when
> > > given a symbol as input. If that fails (which will be the case for a
> > > symbol), try to parse a symbol instead.
> > > 
> > > This allows creating a probe such as:
> > > 
> > >     p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> > > 
> > > Which is necessary for this command to work:
> > > 
> > >     perf probe -m 8021q -a vlan_gro_receive
> > >   
> > 
> > Ah, I forgot that case.
> > Nice catch!
> > 
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> >
> 
> Thanks Masami,
> 
> I can take this. Should this go to stable?

Yes, it should go to stable. 

Thank you,

-- 
Masami Hiramatsu <mhiramat@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-27 22:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22  9:24 [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit Sabrina Dubroca
2017-06-27  8:38 ` Masami Hiramatsu
2017-06-27 14:07   ` Steven Rostedt
2017-06-27 22:05     ` Masami Hiramatsu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.