From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20356C433E0 for ; Tue, 2 Jun 2020 19:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6C90206E2 for ; Tue, 2 Jun 2020 19:29:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="BGjm8Ah3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbgFBT3Y (ORCPT ); Tue, 2 Jun 2020 15:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgFBT3X (ORCPT ); Tue, 2 Jun 2020 15:29:23 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 934E8C08C5C0 for ; Tue, 2 Jun 2020 12:29:23 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id p30so5599018pgl.11 for ; Tue, 02 Jun 2020 12:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jt9wTvbBB9l8BA385ydswer9G/ASNFMgQz2sVTAlGwY=; b=BGjm8Ah3Pr7hHscdoJXTL21nGZPG4PnLKU6jA9IWJJGiA3WnGcbIzvTS7bxWuFIUQw DPDRWnq2PLJmKzmq5Uf8cCKL7sHZKR5bCnU/j65E0birBHYZWTXje41hiOgnXH/qTjow ijI6FUsie6nRXhrLqyHtL+qqUQrZ4bpjgliRZtslnm1Vt4k9hkLunsOH+efJeWr01hLj dz/uqXkmODoVaCaF2mdefg2ay3SvWLgY93xskoihdt1S3hQ3siqSAumw2cYrhovzu4SV u+OwNhe5YYDzQaxC9jimnrgVzhr3cV5o4cYRthNKu3/euNBxL6MW2ywxy4cd4kbCMYMF V4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jt9wTvbBB9l8BA385ydswer9G/ASNFMgQz2sVTAlGwY=; b=O2EONbgnFOm32O1U0wApYmHngBh3eD+RJ3nTw3VvXo8AQ4seF3B9y5Ysk6UcTXmUew vpcA3BktBNjS1orfek6QOFcsfE5cLRWSsGfvo73UH1D+dLhXFnMKyZyXtqkAVRVI90Gr KgDBLoC4UK4G1kJ2F6sGNFgP+przRnLgTB8gCSZoGtX5KsW3EhbZhN5OuNCX0nc9+5HI pPRqic93VTGFo7n4SwQt75+ch9RhmXOTPJ7JKz/upj7vC+ml9f23jifBJ5U/SZqz39Me CoZDmwMMhrOWzajDIJaA5fk1KAQMzyFrRHTCz/VzUekEKDsdyvIU9YfOlv1WXkFf20az 28DA== X-Gm-Message-State: AOAM5314nPkZIqrcWDroCNvwANC3uMz4LpFc6yAvhrh2coj9clN5mwhu LMj+mQG7xl7qOfdRD1YpU3JyoA== X-Google-Smtp-Source: ABdhPJzONNh6ti+mI0rlAqkmgvqRBA1IcAxfDD8TOiWcba6fmr7wI9/I20P9retKbEDJLLAu40knuQ== X-Received: by 2002:a63:565b:: with SMTP id g27mr24394556pgm.166.1591126163012; Tue, 02 Jun 2020 12:29:23 -0700 (PDT) Received: from ?IPv6:2a02:8084:e84:2480:228:f8ff:fe6f:83a8? ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id s197sm3267932pfc.188.2020.06.02.12.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 12:29:21 -0700 (PDT) Subject: Re: [PATCH 3/6] arm64/vdso: Add time namespace page To: Andrei Vagin , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, Vincenzo Frascino , Mark Rutland , Thomas Gleixner References: <20200602180259.76361-1-avagin@gmail.com> <20200602180259.76361-4-avagin@gmail.com> From: Dmitry Safonov Message-ID: Date: Tue, 2 Jun 2020 20:29:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200602180259.76361-4-avagin@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrei, On 6/2/20 7:02 PM, Andrei Vagin wrote: [..] > --- a/arch/arm64/include/asm/vdso.h > +++ b/arch/arm64/include/asm/vdso.h > @@ -12,6 +12,12 @@ > */ > #define VDSO_LBASE 0x0 > > +#ifdef CONFIG_TIME_NS > +#define __VVAR_PAGES 2 > +#else > +#define __VVAR_PAGES 1 > +#endif > + > #ifndef __ASSEMBLY__ Not an issue as-is, but: on x86 vdso+vvar is always the same size with/without CONFIG_TIME_NAMESPACE. Timens page isn't allocated on !CONFIG_TIME_NAMESPACE, but vma is the same size. Which simplifies criu/vdso migration between different kernel configs. Not any critical, but just to note.. Thanks, Dima From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6C4C433E0 for ; Tue, 2 Jun 2020 19:29:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1A1D206E2 for ; Tue, 2 Jun 2020 19:29:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+7TkXKZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=arista.com header.i=@arista.com header.b="BGjm8Ah3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1A1D206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=arista.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dIoTeOyIfy/m7M/CbREyZ0izPEH9cE2rchjmaoNYekE=; b=V+7TkXKZcEByGh ItnAfr6VAo1X+iLwSRGxuJNL4hzxg46XcBPBSGNSFm55jaJgVMFl9brH7XCA+JPiwgs/csomB55dF uw/u2KpW0PskFZt5uhaOXY+tPfuyUDNURfK+FNXekcvyTQ34dwaZ/okPSfNjo4UC5OUUq98X00g2l 48mlKhJD9zJ2rsVKCfaJYwHUUlGz9M3gvp3Q5UT9S219DmTVSsLjgY8b7/NxnPBvnRK9JHKk0zJTQ NeC4Y43QxAQizwaVS4gc23YkaLaklc7/9RAoULac1/KfdTY35XAzUe/sjRICGaP6OGMmPSaejQJmo gib0LCNSAAcGNTCVERFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgCbM-0002kH-QM; Tue, 02 Jun 2020 19:29:32 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgCbJ-0002jG-5i for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2020 19:29:31 +0000 Received: by mail-pg1-x543.google.com with SMTP id w20so5604533pga.6 for ; Tue, 02 Jun 2020 12:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jt9wTvbBB9l8BA385ydswer9G/ASNFMgQz2sVTAlGwY=; b=BGjm8Ah3Pr7hHscdoJXTL21nGZPG4PnLKU6jA9IWJJGiA3WnGcbIzvTS7bxWuFIUQw DPDRWnq2PLJmKzmq5Uf8cCKL7sHZKR5bCnU/j65E0birBHYZWTXje41hiOgnXH/qTjow ijI6FUsie6nRXhrLqyHtL+qqUQrZ4bpjgliRZtslnm1Vt4k9hkLunsOH+efJeWr01hLj dz/uqXkmODoVaCaF2mdefg2ay3SvWLgY93xskoihdt1S3hQ3siqSAumw2cYrhovzu4SV u+OwNhe5YYDzQaxC9jimnrgVzhr3cV5o4cYRthNKu3/euNBxL6MW2ywxy4cd4kbCMYMF V4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jt9wTvbBB9l8BA385ydswer9G/ASNFMgQz2sVTAlGwY=; b=aXPiAjI1pW1i3kHYl86fJh+qwmzcITXbIvQiNjaJ0/l8ZXMiSgtuR6CKyr3XH1YGfb AEgmw+7z+PqQqUtIVXJw/Kf3bOR4fnI2s628Ka/Ch6c0/G1XtL6XOy71DiKBIlYdyEgj Zd6EjhoJyFQMX1HqmT6btuxO9wNXVcYcEpeHLvEFA5g3EUsCrCHDYgbBOb8hAtE7FyyE W6ZuKcLTvgvqRnMVN/HOChmijt0ZcDRKaba9R6ZBjXLZ0GyDuLrmZYsZu8BM/273uqe7 Uw4U9XM0vHBQZ+gDAjhbl2dxu0rGGYy7OKvM30qu3TcBT6YMPeW+ExtDNt5AEtmesbZJ b2oQ== X-Gm-Message-State: AOAM530AzSvoSPBcNAL+/XdjSZ8RzZ8V4P3B11u0HOIy4h8YT5KXDx8q tyGIdcDvLp9YoLq+VMYDIhtx4LoQhwAHGw== X-Google-Smtp-Source: ABdhPJzONNh6ti+mI0rlAqkmgvqRBA1IcAxfDD8TOiWcba6fmr7wI9/I20P9retKbEDJLLAu40knuQ== X-Received: by 2002:a63:565b:: with SMTP id g27mr24394556pgm.166.1591126163012; Tue, 02 Jun 2020 12:29:23 -0700 (PDT) Received: from ?IPv6:2a02:8084:e84:2480:228:f8ff:fe6f:83a8? ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id s197sm3267932pfc.188.2020.06.02.12.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 12:29:21 -0700 (PDT) Subject: Re: [PATCH 3/6] arm64/vdso: Add time namespace page To: Andrei Vagin , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon References: <20200602180259.76361-1-avagin@gmail.com> <20200602180259.76361-4-avagin@gmail.com> From: Dmitry Safonov Message-ID: Date: Tue, 2 Jun 2020 20:29:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200602180259.76361-4-avagin@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_122929_212768_FA677B3A X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrei, On 6/2/20 7:02 PM, Andrei Vagin wrote: [..] > --- a/arch/arm64/include/asm/vdso.h > +++ b/arch/arm64/include/asm/vdso.h > @@ -12,6 +12,12 @@ > */ > #define VDSO_LBASE 0x0 > > +#ifdef CONFIG_TIME_NS > +#define __VVAR_PAGES 2 > +#else > +#define __VVAR_PAGES 1 > +#endif > + > #ifndef __ASSEMBLY__ Not an issue as-is, but: on x86 vdso+vvar is always the same size with/without CONFIG_TIME_NAMESPACE. Timens page isn't allocated on !CONFIG_TIME_NAMESPACE, but vma is the same size. Which simplifies criu/vdso migration between different kernel configs. Not any critical, but just to note.. Thanks, Dima _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel