All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien.grall@arm.com>
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v7 10/11] arm: vsmc: remove 64 bit mode check in PSCI handler
Date: Tue, 10 Oct 2017 16:14:32 +0100	[thread overview]
Message-ID: <fd7e1010-99ab-c5fb-204d-b5161dfe1734@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1710091331420.3105@sstabellini-ThinkPad-X260>

Hi,

On 09/10/17 21:32, Stefano Stabellini wrote:
> On Fri, 6 Oct 2017, Julien Grall wrote:
>> Hi Volodymyr,
>>
>> On 04/10/17 22:00, Volodymyr Babchuk wrote:
>>> PSCI handling code had helper routine that checked calling convention.
>>> It does not needed anymore, because:
>>>
>>>    - Generic handler checks that 64 bit calls can be made only by
>>>      64 bit guests.
>>>
>>>    - SMCCC requires that 64-bit handler should support both 32 and 64 bit
>>>      calls even if they originate from 64 bit caller.
>>>
>>> This patch removes that extra check.
>>>
>>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>> Sorry I just noticed this. This is odd to keep a reviewed-by from Stefano in a
>> patch that changed quite a bit since he gave it (patch #2).
>>
>> Usually reviewed-by means the person has reviewed the code and happy with it.
>> Technically, he didn't review the new changes and if not dropped, you should
>> have at least asked whether he is happy with it.
>>
>> Stefano are you happy if Volodymyr keeping your tag?
> 
> No, the patch changed too much, I'll have to review it again. Drop it
> for now.

I will have a look. Only this patch and #4 are not acked and I would 
really like to see it merged in Xen 4.10 (code freeze tomorrow night).

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-10-10 15:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 21:00 [PATCH v7 00/11] Handle SMCs and HVCs in conformance with SMCCC Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 01/11] arm: traps: use only least 32 bits of fid in PSCI handler Volodymyr Babchuk
2017-10-06 13:48   ` Julien Grall
2017-10-04 21:00 ` [PATCH v7 02/11] arm: traps: use generic register accessors in the PSCI code Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 03/11] arm: traps: check if SMC was conditional before handling it Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 04/11] public: xen.h: add definitions for UUID handling Volodymyr Babchuk
2017-10-05 13:03   ` Konrad Rzeszutek Wilk
2017-10-05 14:50     ` Volodymyr Babchuk
2017-10-09  9:40       ` George Dunlap
2017-10-10 15:19         ` Julien Grall
2017-10-10 15:26           ` Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 05/11] arm: processor.h: add definition for immediate value mask Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 06/11] arm: add SMCCC protocol definitions Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 07/11] arm: smccc: handle SMCs according to SMCCC Volodymyr Babchuk
2017-10-04 21:00 ` [PATCH v7 08/11] arm: traps: handle PSCI calls inside `vsmc.c` Volodymyr Babchuk
2017-10-06 13:52   ` Julien Grall
2017-10-04 21:00 ` [PATCH v7 09/11] arm: PSCI: use definitions provided by asm/smccc.h Volodymyr Babchuk
2017-10-06 13:55   ` Julien Grall
2017-10-04 21:00 ` [PATCH v7 10/11] arm: vsmc: remove 64 bit mode check in PSCI handler Volodymyr Babchuk
2017-10-06 14:00   ` Julien Grall
2017-10-09 20:32     ` Stefano Stabellini
2017-10-10 15:14       ` Julien Grall [this message]
2017-10-10 15:17   ` Julien Grall
2017-10-04 21:00 ` [PATCH v7 11/11] public: add and enable XENFEAT_ARM_SMCCC_supported feature Volodymyr Babchuk
2017-10-06 14:01   ` Julien Grall
2017-10-06 14:17     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd7e1010-99ab-c5fb-204d-b5161dfe1734@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=edgar.iglesias@xilinx.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=volodymyr_babchuk@epam.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.